{"id":2223152,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2223152/?format=json","web_url":"http://patchwork.ozlabs.org/project/ovn/patch/20260414152254.991243-3-xsimonar@redhat.com/","project":{"id":68,"url":"http://patchwork.ozlabs.org/api/1.1/projects/68/?format=json","name":"Open Virtual Network development","link_name":"ovn","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"","webscm_url":""},"msgid":"<20260414152254.991243-3-xsimonar@redhat.com>","date":"2026-04-14T15:22:52","name":"[ovs-dev,3/5] pinctrl: Fix ip_mcast_sync waking up pinctrl thread too often.","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c962cd5d9ff2d72bcadf17c274a63ab6ae33458b","submitter":{"id":82231,"url":"http://patchwork.ozlabs.org/api/1.1/people/82231/?format=json","name":"Xavier Simonart","email":"xsimonar@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/ovn/patch/20260414152254.991243-3-xsimonar@redhat.com/mbox/","series":[{"id":499860,"url":"http://patchwork.ozlabs.org/api/1.1/series/499860/?format=json","web_url":"http://patchwork.ozlabs.org/project/ovn/list/?series=499860","date":"2026-04-14T15:22:51","name":"[ovs-dev,1/5] pinctrl: Add pinctrl_notify_handler_thread counter.","version":1,"mbox":"http://patchwork.ozlabs.org/series/499860/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223152/comments/","check":"success","checks":"http://patchwork.ozlabs.org/api/patches/2223152/checks/","tags":{},"headers":{"Return-Path":"<ovs-dev-bounces@openvswitch.org>","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=KXt0PQz+;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp4.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=KXt0PQz+","smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fw7ML1WZdz1yHH\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 15 Apr 2026 01:23:10 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id E796942AE6;\n\tTue, 14 Apr 2026 15:23:07 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id d7mKfrUc9Erx; Tue, 14 Apr 2026 15:23:06 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp4.osuosl.org (Postfix) with ESMTPS id 9263242AD7;\n\tTue, 14 Apr 2026 15:23:06 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 6C1D7C0903;\n\tTue, 14 Apr 2026 15:23:06 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists.linuxfoundation.org (Postfix) with ESMTP id A40A0C054A\n for <dev@openvswitch.org>; Tue, 14 Apr 2026 15:23:03 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 8A71B42ABB\n for <dev@openvswitch.org>; Tue, 14 Apr 2026 15:23:02 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id gDVEM4L9A2ls for <dev@openvswitch.org>;\n Tue, 14 Apr 2026 15:23:01 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 71DFA42ABC\n for <dev@openvswitch.org>; Tue, 14 Apr 2026 15:23:01 +0000 (UTC)","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-711-fw9jycx5Nyepea8WjFjg5g-1; Tue,\n 14 Apr 2026 11:22:57 -0400","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 374F91956054\n for <dev@openvswitch.org>; Tue, 14 Apr 2026 15:22:57 +0000 (UTC)","from wsfd-netdev90.anl.eng.rdu2.dc.redhat.com\n (wsfd-netdev90.anl.eng.rdu2.dc.redhat.com [10.6.38.135])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id C427F195608E; Tue, 14 Apr 2026 15:22:56 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections -\n client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN> ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 9263242AD7","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 71DFA42ABC"],"Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=xsimonar@redhat.com;\n receiver=<UNKNOWN>","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 71DFA42ABC","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776180180;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=8WCE6oR1gNYSQk+UGWRc11cDDBC/vGYhILn2+f9ULwM=;\n b=KXt0PQz+lR6oW3+KUrEvJEGCGs6r60S2hWi7IabZuyzr+EHncAD/whjXd/PkoAdm2uErP9\n ZbPD2IcqnCL/wzMZwAXNa4D5c7wBCCY1fcyeEc3ec+VHVECJD2eaQqS5l6PSnym4h7xQdQ\n 6W1TgGssZJLnI0f3uWm+rpqr6Itq4TU=","X-MC-Unique":"fw9jycx5Nyepea8WjFjg5g-1","X-Mimecast-MFC-AGG-ID":"fw9jycx5Nyepea8WjFjg5g_1776180177","To":"xsimonar@redhat.com,\n\tdev@openvswitch.org","Date":"Tue, 14 Apr 2026 11:22:52 -0400","Message-ID":"<20260414152254.991243-3-xsimonar@redhat.com>","In-Reply-To":"<20260414152254.991243-1-xsimonar@redhat.com>","References":"<20260414152254.991243-1-xsimonar@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"7grv3SK5N9TDqDK-1DyEBOl67ojvL_FL0gKwgGiKJ1k_1776180177","X-Mimecast-Originator":"redhat.com","Subject":"[ovs-dev] [PATCH ovn 3/5] pinctrl: Fix ip_mcast_sync waking up\n pinctrl thread too often.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"<ovs-dev.openvswitch.org>","List-Unsubscribe":"<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>","List-Archive":"<http://mail.openvswitch.org/pipermail/ovs-dev/>","List-Post":"<mailto:ovs-dev@openvswitch.org>","List-Help":"<mailto:ovs-dev-request@openvswitch.org?subject=help>","List-Subscribe":"<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=subscribe>","From":"Xavier Simonart via dev <ovs-dev@openvswitch.org>","Reply-To":"Xavier Simonart <xsimonar@redhat.com>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" <ovs-dev-bounces@openvswitch.org>"},"content":"Not local datapath related entries were added and removed in every loops,\ncausing constant pinctrl wakeup.\n\nFixes: 70ff8243040f (\"OVN: Add IGMP SB definitions and ovn-controller support\")\nSigned-off-by: Xavier Simonart <xsimonar@redhat.com>\n---\n controller/pinctrl.c | 3 +++\n tests/system-ovn.at  | 3 +++\n 2 files changed, 6 insertions(+)","diff":"diff --git a/controller/pinctrl.c b/controller/pinctrl.c\nindex f62022361..0a0891ef3 100644\n--- a/controller/pinctrl.c\n+++ b/controller/pinctrl.c\n@@ -5749,6 +5749,9 @@ ip_mcast_sync(struct ovsdb_idl_txn *ovnsb_idl_txn,\n         struct ip_mcast_snoop_cfg cfg;\n         bool flush_groups = false;\n \n+        if (!get_local_datapath(local_datapaths, dp_key)) {\n+            continue;\n+        }\n         ip_mcast_snoop_cfg_load(&cfg, ip_mcast);\n         if (ip_mcast_snoop_state_update(dp_key, &cfg, &flush_groups)) {\n             notify = true;\ndiff --git a/tests/system-ovn.at b/tests/system-ovn.at\nindex 8d1f21609..717a5d767 100644\n--- a/tests/system-ovn.at\n+++ b/tests/system-ovn.at\n@@ -5027,6 +5027,9 @@ OVS_WAIT_UNTIL([\n     test \"${n_reset}\" = \"1\"\n ])\n \n+ovn-appctl coverage/show > ovn_counters\n+AT_CHECK([test 50 -gt $(grep -c pinctrl_notify_handler_thread ovn_counters)], [0])\n+\n # Check that we do not get too many immediate wake up.\n # Tolerate a few for any race conditions.\n AT_CHECK([test 5 -gt `cat ovn-controller.log | \\\n","prefixes":["ovs-dev","3/5"]}