{"id":2222907,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222907/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260414003001.97571-26-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260414003001.97571-26-philmd@linaro.org>","date":"2026-04-14T00:29:57","name":"[v3,25/27] target/sparc: Replace target_monitor_defs -> SysemuCPUOps::monitor_defs","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"233a83f8e92067cf71d073aca2304f3123f9886a","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.1/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260414003001.97571-26-philmd@linaro.org/mbox/","series":[{"id":499762,"url":"http://patchwork.ozlabs.org/api/1.1/series/499762/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499762","date":"2026-04-14T00:29:32","name":"monitor: Remove need of per-target handlers","version":3,"mbox":"http://patchwork.ozlabs.org/series/499762/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222907/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222907/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=ufCm6J0f;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvlcZ3JPsz1yCv\n\tfor ; Tue, 14 Apr 2026 10:33:18 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCRiK-0001B5-4y; Mon, 13 Apr 2026 20:33:12 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wCRiI-0001AE-3C\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 20:33:10 -0400","from mail-wm1-x331.google.com ([2a00:1450:4864:20::331])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wCRiG-0003b4-Hk\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 20:33:09 -0400","by mail-wm1-x331.google.com with SMTP id\n 5b1f17b1804b1-4887fd35e60so35228265e9.2\n for ; Mon, 13 Apr 2026 17:33:08 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488ede24eb0sm5829775e9.8.2026.04.13.17.33.05\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Mon, 13 Apr 2026 17:33:06 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776126787; x=1776731587; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=P+MkKHTxKAsGH7mkXb7QOys2aguqDNuWH1H2LcjP2Ig=;\n b=ufCm6J0fs61FwhPg5m4XSAoo5iYs3af31GLjX/BGJHbcwo1neesSsWV7EMFdRVAGD+\n yewAks2lfdH+39Gk6kSrF76D0Fe6kT8i4VjzlYRZrm7DOE5tlFWW637HXAkxHYkg6Y0u\n mbpxTC57uEsEIildL8Fl5FmRFixQGVOhhVFzTRxuG+vYGFX46XTqKiX/1cBn1E9is/Fy\n 0wAiDInD2W2uHCUweieFDm8c41OgYALUKUOpVMgo/o6KDqDNlW1gkBElw8dP84N+hppq\n cRt9EHtJwUhL5nmhAz7lGgq+Xreii+JmssbK7AShLXIBXdvT0LP6kbvH5Wk+nAf/TkgA\n fSGg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776126787; x=1776731587;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=P+MkKHTxKAsGH7mkXb7QOys2aguqDNuWH1H2LcjP2Ig=;\n b=jJzr7bFvETX8yjcQxm6E11a+j7hwihWRN/qtPkAS8N5EFGeEojuQxLZe1Wqwrw6uV2\n FK3x0bzI6zfRFzySLuvR4m8YXxP3GStIjDkaP4D9RG2Vc95OjbVYqSqylfiieRovYjkr\n yfhVs1Ap22EdGNgWxU2k9glQOS0ZgSwo0aRvLkw+kNLSega4+g7H3KFgNeIaLXPEXzwO\n qxJrM9uek+pcRdhIEOqGZQwF+8FutbWsfYZiBdJ+nJMMYnzSck9MVPUTzoSBxg/hs/Iu\n jvLS2toUU7lv9+tc6UOHB4spEQWbsToVYHyzhyGe+LE/PkuEIF6zNuh0kfHPzgteZcJt\n MGuA==","X-Gm-Message-State":"AOJu0Yyq1oLYgdYHlj9vgP+Gx6+SDks+SFrYGiN0kx3fdbXMmejx3nhf\n O85Qrp+GH+MIXVWFSOZ2KA+vGK1NZEUtGHhbIjuxAUGVn5zSvaPo5gCnGYEqL6WzHKVRAkxUdYq\n AqhIYok0=","X-Gm-Gg":"AeBDiesiesbhbHFdPA64WNRd684ENI8WEcKPt9DfR8pHdBSWqq6/OFXWilvSA+GczdB\n hhxUiQ8AnhAsocI/UbcNQCZbwNvzgDEumYlWFXpvBPDGf3aF1sdP2Er1ALUBEN2XqtAC3U6OLa1\n N06iSyDn3oSa6qaI0v77npJBpg/cfsbhXBZL2PQdAUdrxS7DdP9MxURh1vvbVjhzA29cmqvqNxq\n B1qNjD/1A5G//OhA2Ls2yIfVYF/7oWGv30qwI+UoKma55Sz0JbMZ6dHAK3cXLDmh//PScAAKokf\n PLSDBwRjFabC1H2hIQ0Kddw8qFlF1M1AcFYMHgh9UvWNUHe583kNcOnXmMntRvc6Ny8y+il6/yA\n PY3XpsY7qKnHtw38w+xR/ORzEfmH+i5kd8YafZA3kRMX3rA4ZKuBedsNJJeLgIO953sPs1p8mxy\n g91cq+Oc1qY1Id+oAKB3UDEv5sg+b8w7DIqe9FORq3dKqLYCCtmDr89Kbnekmba/1sJ1rytMRW","X-Received":"by 2002:a05:600c:3ba8:b0:488:af7f:7707 with SMTP id\n 5b1f17b1804b1-488d6836621mr210119185e9.18.1776126786861;\n Mon, 13 Apr 2026 17:33:06 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Pierrick Bouvier ,\n Markus Armbruster ,\n Richard Henderson ,\n \"Dr. David Alan Gilbert\" ,\n Paolo Bonzini ,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Mark Cave-Ayland ,\n Artyom Tarasenko ","Subject":"[PATCH v3 25/27] target/sparc: Replace target_monitor_defs ->\n SysemuCPUOps::monitor_defs","Date":"Tue, 14 Apr 2026 02:29:57 +0200","Message-ID":"<20260414003001.97571-26-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260414003001.97571-1-philmd@linaro.org>","References":"<20260414003001.97571-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::331;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Restrict sparc64_monitor_defs[] to cpu.c, register it\nas SysemuCPUOps::monitor_defs hook (taking care to not\nregister it on 32-bit SPARC target), allowing to remove\nthe target_monitor_defs() method.\n\nSigned-off-by: Philippe Mathieu-Daudé \nReviewed-by: Richard Henderson \n---\n target/sparc/cpu.c | 19 +++++++++++++++++++\n target/sparc/monitor.c | 18 ------------------\n 2 files changed, 19 insertions(+), 18 deletions(-)","diff":"diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c\nindex 1493336e7a2..9c5175aca34 100644\n--- a/target/sparc/cpu.c\n+++ b/target/sparc/cpu.c\n@@ -993,12 +993,31 @@ static const Property sparc_cpu_properties[] = {\n };\n \n #ifndef CONFIG_USER_ONLY\n+\n+#ifdef TARGET_SPARC64\n+#include \"monitor/hmp.h\"\n+\n+static const MonitorDef sparc64_monitor_defs[] = {\n+ { \"asi\", offsetof(CPUSPARCState, asi) },\n+ { \"pstate\", offsetof(CPUSPARCState, pstate) },\n+ { \"cansave\", offsetof(CPUSPARCState, cansave) },\n+ { \"canrestore\", offsetof(CPUSPARCState, canrestore) },\n+ { \"otherwin\", offsetof(CPUSPARCState, otherwin) },\n+ { \"wstate\", offsetof(CPUSPARCState, wstate) },\n+ { \"cleanwin\", offsetof(CPUSPARCState, cleanwin) },\n+ { NULL },\n+};\n+#endif\n+\n #include \"hw/core/sysemu-cpu-ops.h\"\n \n static const struct SysemuCPUOps sparc_sysemu_ops = {\n .has_work = sparc_cpu_has_work,\n .get_phys_page_debug = sparc_cpu_get_phys_page_debug,\n .legacy_vmsd = &vmstate_sparc_cpu,\n+#if defined(TARGET_SPARC64)\n+ .monitor_defs = sparc64_monitor_defs,\n+#endif\n };\n #endif\n \ndiff --git a/target/sparc/monitor.c b/target/sparc/monitor.c\nindex 99abddbf1e0..36f3d8d58e9 100644\n--- a/target/sparc/monitor.c\n+++ b/target/sparc/monitor.c\n@@ -37,21 +37,3 @@ void hmp_info_tlb(Monitor *mon, const QDict *qdict)\n }\n dump_mmu(env1);\n }\n-\n-const MonitorDef monitor_defs[] = {\n-#ifdef TARGET_SPARC64\n- { \"asi\", offsetof(CPUSPARCState, asi) },\n- { \"pstate\", offsetof(CPUSPARCState, pstate) },\n- { \"cansave\", offsetof(CPUSPARCState, cansave) },\n- { \"canrestore\", offsetof(CPUSPARCState, canrestore) },\n- { \"otherwin\", offsetof(CPUSPARCState, otherwin) },\n- { \"wstate\", offsetof(CPUSPARCState, wstate) },\n- { \"cleanwin\", offsetof(CPUSPARCState, cleanwin) },\n-#endif\n- { NULL },\n-};\n-\n-const MonitorDef *target_monitor_defs(void)\n-{\n- return monitor_defs;\n-}\n","prefixes":["v3","25/27"]}