{"id":2222906,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222906/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260414003001.97571-23-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260414003001.97571-23-philmd@linaro.org>","date":"2026-04-14T00:29:54","name":"[v3,22/27] cpus: Introduce SysemuCPUOps::monitor_defs hook","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"07f39719becfcebaaf4b3bfab16d284507e1f7ec","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.1/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260414003001.97571-23-philmd@linaro.org/mbox/","series":[{"id":499762,"url":"http://patchwork.ozlabs.org/api/1.1/series/499762/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499762","date":"2026-04-14T00:29:32","name":"monitor: Remove need of per-target handlers","version":3,"mbox":"http://patchwork.ozlabs.org/series/499762/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222906/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222906/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=G7u7xKi0;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvlcW48kSz1yHH\n\tfor ; Tue, 14 Apr 2026 10:33:15 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCRhx-0000Fc-EP; Mon, 13 Apr 2026 20:32:49 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wCRhv-000070-NM\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 20:32:47 -0400","from mail-wm1-x331.google.com ([2a00:1450:4864:20::331])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wCRhu-0003R8-6k\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 20:32:47 -0400","by mail-wm1-x331.google.com with SMTP id\n 5b1f17b1804b1-4888375f735so48729125e9.3\n for ; Mon, 13 Apr 2026 17:32:45 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488ede15cfbsm6671665e9.1.2026.04.13.17.32.43\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Mon, 13 Apr 2026 17:32:43 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776126764; x=1776731564; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=CX4HMtCLtaKxWP+CnhHEeurJGMT23nAqgS5xqErMf6U=;\n b=G7u7xKi0tZu3txuhUQEw4Dq7y8/C1MGPYCs7P6udmIu+w8eeerjH8S/AjyosUdrUd3\n 38YOPlWX3YuFPJhl1yPoJ0UC7Y0F/+dxWs+x1orgFWe4i2UtZ+A2h1eRqk3Z9jnTX97C\n 8Z1GqZgpqA0uSBpuqMuwUQWR0UDxz83JbZxHx+0BS4p45ta1qRkoApbi91jl3bLpJN/X\n /plioCzsOo/iA3iyDyKk7BzoSrcU0FPjmajxwPOhKYqokeiSUvTeWJ4uf5hciFrh5h0R\n sE0RvjiNS1VbtKwUwByuC7JxpVDmZwx0IDxFKt6PGw06sgRO6GpRhwBJhvseG8DhMVau\n FB3A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776126764; x=1776731564;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=CX4HMtCLtaKxWP+CnhHEeurJGMT23nAqgS5xqErMf6U=;\n b=NRkq1TlMBCwaV92wfBPychL4nV7+0TbkCfVboNiTT9cGtuSowqM8TGA2Bk/YJwD3yY\n mXjGCZJJmELOnZY8hQiJSGDD3bLwmSAe6WJyDHdkk14Ep9LQd+Ir22ghzYLtAeWvNpI+\n vH2s3wMHTkCRSdO6VFLW+mFNgG0mBoLI9lEGTRTiKzgf04r1RQnCj2rz6HYhTv2dxxHf\n /v44T5U2urkiQ0dpYjCK3L1fZYc/UG5Xw9y2mFh5+Lh3Q6TROB1YOLtWFkZr6vyODx97\n 9JnIGRKeUAlP2im+AomescneS6C4Bajb2DHgvqYyr0jKOPxSad0CNQIQimiu2ShxvEvg\n Kfqw==","X-Gm-Message-State":"AOJu0YzRObQuNN5O+SaDJXQ7630Fz1/7t1xyTsbfadzdH/lL5Uhk5WbX\n vmosyvkd4/MBFm7Ewegf80s0r8Odk1YavF+Wlpndi2qhZiJ3XWQAqzCKNWTCm5KZ1QPOMjR4kb7\n KxvA892s=","X-Gm-Gg":"AeBDies3M/QM3i7HkYHCi2GeTnnk4pZzV7FXBS9UPrcj17bSIc9ZKS0qtCzeQlmsfxV\n AuilmP6qHMw9LJAO3OS/3Gj76l60pwUOUyrr0xL++LmnYOh604YzKzmKb6yL7pV1zamL93eW7l2\n qC/OG6KNSx/ts8ZsAxunI/KFpD870jvkaxsPt1LpuMF68mrS9JmlZR511r58Q8Nr+MYsaa9e/o8\n EdHFu8T0gDjjaQSRzLvQc1Byw8CMZ8wcopKCbYf+20ZjuFSI8qvlkRNZ7fiRSrTRt0v8Q2ZIwLU\n KpYiHGKp60lwQpltKnvsGqgnF3dUbmqwPv0fHcVT6gc9Vuqe29NKO0FzdOxk6qCXgAZWQqLaPow\n nIICdaIJV9XLsltbKlI7AngXAkkiRBollfgpCSWD29IVlHkCrKa+P1ahtNUyWeYPj2Knev8ahpb\n SyXqN+pnhhNixMgQg/qy8ongl56lP8/h5E+Zs97zRx1G74zrXh64FFpDOaJYisxcbbMsNFE9NY","X-Received":"by 2002:a05:600c:c08e:b0:480:3ad0:93bf with SMTP id\n 5b1f17b1804b1-488d6864d41mr142234575e9.24.1776126764432;\n Mon, 13 Apr 2026 17:32:44 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Pierrick Bouvier ,\n Markus Armbruster ,\n Richard Henderson ,\n \"Dr. David Alan Gilbert\" ,\n Paolo Bonzini ,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Subject":"[PATCH v3 22/27] cpus: Introduce SysemuCPUOps::monitor_defs hook","Date":"Tue, 14 Apr 2026 02:29:54 +0200","Message-ID":"<20260414003001.97571-23-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260414003001.97571-1-philmd@linaro.org>","References":"<20260414003001.97571-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::331;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Allow targets to register their legacy target_monitor_defs()\nin SysemuCPUOps; check it first in get_monitor_def() otherwise\nfall back to previous per-target helper.\n\nSigned-off-by: Philippe Mathieu-Daudé \nReviewed-by: Richard Henderson \n---\n include/hw/core/sysemu-cpu-ops.h | 6 ++++++\n monitor/hmp.c | 8 ++++++--\n 2 files changed, 12 insertions(+), 2 deletions(-)","diff":"diff --git a/include/hw/core/sysemu-cpu-ops.h b/include/hw/core/sysemu-cpu-ops.h\nindex 5b831393cf4..94e36ecdd18 100644\n--- a/include/hw/core/sysemu-cpu-ops.h\n+++ b/include/hw/core/sysemu-cpu-ops.h\n@@ -93,6 +93,12 @@ typedef struct SysemuCPUOps {\n */\n int (*monitor_get_register)(CPUState *cs, const char *name, int64_t *pval);\n \n+ /**\n+ * @monitor_defs: Array of MonitorDef entries. This field is legacy,\n+ * use @gdb_core_xml_file to dump registers instead.\n+ */\n+ const MonitorDef *monitor_defs;\n+\n /**\n * @legacy_vmsd: Legacy state for migration.\n * Do not use in new targets, use #DeviceClass::vmsd instead.\ndiff --git a/monitor/hmp.c b/monitor/hmp.c\nindex d7b2f731def..70e5e5c2367 100644\n--- a/monitor/hmp.c\n+++ b/monitor/hmp.c\n@@ -1608,11 +1608,15 @@ void monitor_register_hmp_info_hrt(const char *name,\n */\n static int get_monitor_def(Monitor *mon, int64_t *pval, const char *name)\n {\n- const MonitorDef *md = target_monitor_defs();\n CPUState *cs = mon_get_cpu(mon);\n+ const MonitorDef *md;\n void *ptr;\n \n- if (cs == NULL || md == NULL) {\n+ if (cs == NULL) {\n+ return -1;\n+ }\n+ md = cs->cc->sysemu_ops->monitor_defs ?: target_monitor_defs();\n+ if (md == NULL) {\n return -1;\n }\n \n","prefixes":["v3","22/27"]}