{"id":2222905,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222905/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260414003001.97571-25-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260414003001.97571-25-philmd@linaro.org>","date":"2026-04-14T00:29:56","name":"[v3,24/27] target/m68k: Replace target_monitor_defs -> SysemuCPUOps::monitor_defs","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"66bb3c3f047b989c882ef94d7947382c15c5ec02","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.1/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260414003001.97571-25-philmd@linaro.org/mbox/","series":[{"id":499762,"url":"http://patchwork.ozlabs.org/api/1.1/series/499762/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499762","date":"2026-04-14T00:29:32","name":"monitor: Remove need of per-target handlers","version":3,"mbox":"http://patchwork.ozlabs.org/series/499762/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222905/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222905/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=nK3t8jmh;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvlcW3sDvz1yCv\n\tfor ; Tue, 14 Apr 2026 10:33:15 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCRiD-0000w8-7Y; Mon, 13 Apr 2026 20:33:05 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wCRiB-0000ku-A5\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 20:33:03 -0400","from mail-wr1-x435.google.com ([2a00:1450:4864:20::435])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wCRi9-0003Tf-Lb\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 20:33:02 -0400","by mail-wr1-x435.google.com with SMTP id\n ffacd0b85a97d-43cf906b007so2985560f8f.0\n for ; Mon, 13 Apr 2026 17:33:01 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d63e46713sm37894676f8f.21.2026.04.13.17.32.57\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Mon, 13 Apr 2026 17:32:58 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776126780; x=1776731580; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=pWkinHow/eylS7JBe+fWXt/Nq4YrC48hyztEBorpfGw=;\n b=nK3t8jmhtQO5RI4gnnisp8pJg3GE/3iuDWY0WOyZK/2z7rW0lJAX5FSIBncYFvvDmu\n xhTjXen1rgEw6oP75MQ+9cyKr1iF6fo3MeMEEPDHFvBj86/j1YuMIJHlUHoEDadUbMxV\n KOTQ/K4e2N9TkQZ7onCVK6+1cu4Ci8qDNiirQ5p4an6Jn22Sq990K/a4Wdfb9efGQkTJ\n Ppjlo1tkZkMbQMz1NY2PmqwBnKpeMU/E/fgK2rqPsmAd7jRZfzCv+e//T3nX0kZaJqY9\n kh/FVGYVsGlvslS06eFJI2l8hBizpQM/y4zvnvqXkKgHZBMDW4b5JmSQf6P+gDedvwRh\n nSSQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776126780; x=1776731580;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=pWkinHow/eylS7JBe+fWXt/Nq4YrC48hyztEBorpfGw=;\n b=VZFgXZPhDic3kCSutU1mmX20pyRzXemS+WNEtZye+fz2xL/Z6/gLghpUpfnhbVE5ey\n ZScdqLDid3fahuPRnxnkJ1EWw98L9QRIeTidSwjVShh7Yo2XgTJHGQX8y3vVP2geEh5H\n gFVdskF+odL8d3Iq0su0ekJtMCU/SNFzckZ2Tur9c/q27csIjJiZce0nCTxi0i040y8m\n W7Ja35d+KFGa+wJxGwXLfte9vbY50oZhYsAlHOtjVrDXRZsn+HwxEu3Ia+IW1ilFr8EM\n /FjKkG23o2bLGjhZPTkNuee74gs8e1s00H2OmlBK/FHx5PhXyHurUchdqf+jyeaIcNhd\n rP2A==","X-Gm-Message-State":"AOJu0YzxaTVOnn2bp6VcbdBSW7FGiSUjNYhNHKiZUerEgy2Bpk6CSUgI\n IzXbPHdUD9AZy84RSyoG1GuK6jbYefYxUJy4lVS6Ax5upBv/uJQDu/BsuxsPq2BCJGpAGI4JHD/\n hOhHSh+I=","X-Gm-Gg":"AeBDiesIk6sktejIhiD58K2j2ncuU6Jq0PR+m7jj7diiTg3wfz7bUn1weLyOJd9rh0h\n CbjT6wKYOY11Y6uy/Uv9n/yk9hi1VS7nFdHq8+SNY+Ct1j143xmmq1Qa2cnjaHBBJ6+GGoIKl3g\n x5XpvAJ63XGks63VOM3NDkYdg/v2GBfYBuEXEVPZ42Z5JecdHUmDn101sFNHF6pyenoeoE1r1Qj\n V/oV/bIaIYSK/walK8mj/Ejbvh9XkoqU6ydoABwDD29/7ICEpI5sdWOypwpStEoqDir+UWuSn2t\n VBKhSzOMXTjACUs5v3z3eaQCfKaV76LG5iKUoEZPUxmCr3/xlfWuKeJwyWw4ffKm5riyx7nt6pu\n 3Z/DVzQyg4Z2dqE7buzp75tRgVXlDDzrhkYnXZPww6ptbfyj8BqicJszNBJ8gWw5HvgKRizMoDr\n vDz7MtvF8X2PvgK1VpNZFE/S0GvuZ5AQWAYnReY1m8uz1tjAGTstxF67bmbUm/678KvJN0c5vL","X-Received":"by 2002:a05:6000:200f:b0:43b:9a9f:8956 with SMTP id\n ffacd0b85a97d-43d6428e889mr21221402f8f.22.1776126779907;\n Mon, 13 Apr 2026 17:32:59 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Pierrick Bouvier ,\n Markus Armbruster ,\n Richard Henderson ,\n \"Dr. David Alan Gilbert\" ,\n Paolo Bonzini ,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Laurent Vivier ","Subject":"[PATCH v3 24/27] target/m68k: Replace target_monitor_defs ->\n SysemuCPUOps::monitor_defs","Date":"Tue, 14 Apr 2026 02:29:56 +0200","Message-ID":"<20260414003001.97571-25-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260414003001.97571-1-philmd@linaro.org>","References":"<20260414003001.97571-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::435;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x435.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Restrict m68k_monitor_defs[] to cpu.c, register it as\nSysemuCPUOps::monitor_defs hook, allowing to remove\nthe target_monitor_defs() method.\n\nSigned-off-by: Philippe Mathieu-Daudé \nReviewed-by: Richard Henderson \n---\n target/m68k/cpu.c | 18 ++++++++++++++++++\n target/m68k/monitor.c | 21 ---------------------\n 2 files changed, 18 insertions(+), 21 deletions(-)","diff":"diff --git a/target/m68k/cpu.c b/target/m68k/cpu.c\nindex d849a4a90fc..f704a6af613 100644\n--- a/target/m68k/cpu.c\n+++ b/target/m68k/cpu.c\n@@ -25,6 +25,7 @@\n \n #ifndef CONFIG_USER_ONLY\n #include \"migration/vmstate.h\"\n+#include \"monitor/hmp.h\"\n #endif\n \n #include \"cpu.h\"\n@@ -602,11 +603,28 @@ static const VMStateDescription vmstate_m68k_cpu = {\n },\n };\n \n+static const MonitorDef m68k_monitor_defs[] = {\n+ { \"ssp\", offsetof(CPUM68KState, sp[0]) },\n+ { \"usp\", offsetof(CPUM68KState, sp[1]) },\n+ { \"isp\", offsetof(CPUM68KState, sp[2]) },\n+ { \"sfc\", offsetof(CPUM68KState, sfc) },\n+ { \"dfc\", offsetof(CPUM68KState, dfc) },\n+ { \"urp\", offsetof(CPUM68KState, mmu.urp) },\n+ { \"srp\", offsetof(CPUM68KState, mmu.srp) },\n+ { \"dttr0\", offsetof(CPUM68KState, mmu.ttr[M68K_DTTR0]) },\n+ { \"dttr1\", offsetof(CPUM68KState, mmu.ttr[M68K_DTTR1]) },\n+ { \"ittr0\", offsetof(CPUM68KState, mmu.ttr[M68K_ITTR0]) },\n+ { \"ittr1\", offsetof(CPUM68KState, mmu.ttr[M68K_ITTR1]) },\n+ { \"mmusr\", offsetof(CPUM68KState, mmu.mmusr) },\n+ { NULL },\n+};\n+\n #include \"hw/core/sysemu-cpu-ops.h\"\n \n static const struct SysemuCPUOps m68k_sysemu_ops = {\n .has_work = m68k_cpu_has_work,\n .get_phys_page_debug = m68k_cpu_get_phys_page_debug,\n+ .monitor_defs = m68k_monitor_defs,\n };\n #endif /* !CONFIG_USER_ONLY */\n \ndiff --git a/target/m68k/monitor.c b/target/m68k/monitor.c\nindex be7411edca6..3e0df40a6b8 100644\n--- a/target/m68k/monitor.c\n+++ b/target/m68k/monitor.c\n@@ -21,24 +21,3 @@ void hmp_info_tlb(Monitor *mon, const QDict *qdict)\n \n dump_mmu(env1);\n }\n-\n-static const MonitorDef monitor_defs[] = {\n- { \"ssp\", offsetof(CPUM68KState, sp[0]) },\n- { \"usp\", offsetof(CPUM68KState, sp[1]) },\n- { \"isp\", offsetof(CPUM68KState, sp[2]) },\n- { \"sfc\", offsetof(CPUM68KState, sfc) },\n- { \"dfc\", offsetof(CPUM68KState, dfc) },\n- { \"urp\", offsetof(CPUM68KState, mmu.urp) },\n- { \"srp\", offsetof(CPUM68KState, mmu.srp) },\n- { \"dttr0\", offsetof(CPUM68KState, mmu.ttr[M68K_DTTR0]) },\n- { \"dttr1\", offsetof(CPUM68KState, mmu.ttr[M68K_DTTR1]) },\n- { \"ittr0\", offsetof(CPUM68KState, mmu.ttr[M68K_ITTR0]) },\n- { \"ittr1\", offsetof(CPUM68KState, mmu.ttr[M68K_ITTR1]) },\n- { \"mmusr\", offsetof(CPUM68KState, mmu.mmusr) },\n- { NULL },\n-};\n-\n-const MonitorDef *target_monitor_defs(void)\n-{\n- return monitor_defs;\n-}\n","prefixes":["v3","24/27"]}