{"id":2222894,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222894/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260414003001.97571-14-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260414003001.97571-14-philmd@linaro.org>","date":"2026-04-14T00:29:45","name":"[v3,13/27] monitor: Do not check TARGET_I386/RISCV to build 'info mem' command","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3dedd15334ad116b3d7979d45285f88189bec90a","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.1/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260414003001.97571-14-philmd@linaro.org/mbox/","series":[{"id":499762,"url":"http://patchwork.ozlabs.org/api/1.1/series/499762/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499762","date":"2026-04-14T00:29:32","name":"monitor: Remove need of per-target handlers","version":3,"mbox":"http://patchwork.ozlabs.org/series/499762/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222894/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222894/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=QQ1XdI2Y;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvlbR4R1bz1yCv\n\tfor ; Tue, 14 Apr 2026 10:32:19 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCRgs-0003BB-Vr; Mon, 13 Apr 2026 20:31:43 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wCRgs-00038F-28\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 20:31:42 -0400","from mail-wr1-x431.google.com ([2a00:1450:4864:20::431])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wCRgq-0003FN-E3\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 20:31:41 -0400","by mail-wr1-x431.google.com with SMTP id\n ffacd0b85a97d-43d43e09de5so2934452f8f.1\n for ; Mon, 13 Apr 2026 17:31:40 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d63de2a69sm37588554f8f.4.2026.04.13.17.31.37\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Mon, 13 Apr 2026 17:31:38 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776126699; x=1776731499; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=L00sTYsnDkewYLMKY3Xwi/QsSf8SDpEAlxJYefdp+KA=;\n b=QQ1XdI2YiJreBBpp7xQlOEpJh6qKdkNE/w0Hvq+Qlsm8xDXHrmUmMc4krfjcPA7K4Q\n uCagRIXaNKnxfeJLnRg5da5P6zuil9EwcYgH7rQ6aXnIHTtYJMqB8KavW3sHjZQzGmaM\n Gkd91WIZl3zzHVkMtJirf3+lIYiUskEFmnqNX19nEjWFCFwHT08TaraBLcwojA/qXw0M\n txQ+euOyhH/bHeuqSJeVqdfzPuuIC0XMug0CpdigK3rwZuaX5u0UNdx8PTVST74UH5n9\n MFCrVXmXe4GGPkTS+27rMCrvefX/ZUw6p7y+BS85DWuzl4q6Rs7e/P3JIwE0l9f7hKZ4\n wS3g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776126699; x=1776731499;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=L00sTYsnDkewYLMKY3Xwi/QsSf8SDpEAlxJYefdp+KA=;\n b=H0/nX67lnbaIl2MiO6+X5dcXL6J9y+hWlP6IEUwR3S1H6Ng87sHNcVfF0e0A9Dp/tD\n E/0woraVg+wSCmhJikpPkwkgqSUtmtR/sEtyBKNvdRR9nS8d0NvnQ6maxtpuV1lxhGhA\n JoICVPXsmbpmwuqZea7FqogpNGuvoNALhR8EuRcaNfHd9UXA/wrYtIk6XE9rIoDlZr6f\n XiAd5+sDDKuqLqUZUTiCqsAjTtRPeYsNgPXcsdrRk1VN3pfNoHVZTCbHEOmU4tN6n458\n RY9YAGsDzrI/Q+st1OOGhUn1pGqo6E38ylXXbp8hoL4UJo0+bGwqJWkf39vU33edYQG4\n ObgQ==","X-Gm-Message-State":"AOJu0YwHGgExZA12P6Uch37ztTddXFHVYvlHhFNExxg4HB9L97Z7broa\n ccEuZivV3gjisMkaBbcOwIy2lscw2vPWJXU5Pf/dra8xpECRgaqHRf1+qhCZk5IZxC0aMZ8M6vn\n pmenUO/I=","X-Gm-Gg":"AeBDievZjv6Ho3tFiQmDAIv4eKRW++fjYlsBpyYQEJ9EEx4dLV7DrAWrsykMRjnxEqr\n 548fhNH0I/6dFgbUbFqzM5boHnr+CIPHSg2O3E0LDYpZlZZ+/WD1s4ViUUSI0RZ3Jh2iwpdaqHM\n aZwMGjCF7giwJ+qTI35jnrz3pUnyYQPyE+YYPBZDjqF3X0Z2sO3X9sOkpwOb2GamjDlV5MmdDgP\n DvGvZDKcYvt2UhakVqQaR0v4V1nS8dSgpusEDMPrmYL/PBx3MRIdpn62HWM8W8+VbHAlkcPWzzn\n fbMYAj5bLILiQHvX5avwTTON2I34x8rL4+8soEBqSdp9CmINQaChXy8Pti1bwU+SwpocWwZupxG\n f4c7fhtW5GDwOJLzHA+qTsGh0grdyPctUZBcFbw3XZtvyhrFF2P+xl4Zk/0P1s0lrfcYyGdgZ4e\n 56ic535+5Qnb9IDXFbCqsUhMNcW8xczuoUgTG4L3pGbFRQXupJAY0sRUPNPUwG4C1HS82BvXDh","X-Received":"by 2002:a05:6000:2585:b0:43d:73d4:b34 with SMTP id\n ffacd0b85a97d-43d73d4185bmr10976447f8f.16.1776126698629;\n Mon, 13 Apr 2026 17:31:38 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Pierrick Bouvier ,\n Markus Armbruster ,\n Richard Henderson ,\n \"Dr. David Alan Gilbert\" ,\n Paolo Bonzini ,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Subject":"[PATCH v3 13/27] monitor: Do not check TARGET_I386/RISCV to build\n 'info mem' command","Date":"Tue, 14 Apr 2026 02:29:45 +0200","Message-ID":"<20260414003001.97571-14-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260414003001.97571-1-philmd@linaro.org>","References":"<20260414003001.97571-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::431;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x431.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"This command is filtered at build-time for i386/x86_64 and\nriscv32/riscv64 binaries. By using the recently introduced\nHMPCommand::arch_bitmask flag we can filter it at runtime,\nmaking it possible to compile hmp-commands-info.hx once.\n\nSince the method depends on a pair of distinct targets,\ndefine it in its own stub file.\n\nSigned-off-by: Philippe Mathieu-Daudé \nReviewed-by: Richard Henderson \n---\n stubs/hmp-cmd-info_mem.c | 12 ++++++++++++\n hmp-commands-info.hx | 3 +--\n stubs/meson.build | 1 +\n 3 files changed, 14 insertions(+), 2 deletions(-)\n create mode 100644 stubs/hmp-cmd-info_mem.c","diff":"diff --git a/stubs/hmp-cmd-info_mem.c b/stubs/hmp-cmd-info_mem.c\nnew file mode 100644\nindex 00000000000..8a53e367a9f\n--- /dev/null\n+++ b/stubs/hmp-cmd-info_mem.c\n@@ -0,0 +1,12 @@\n+/*\n+ * Human Monitor 'info mem' stub\n+ *\n+ * Copyright (c) Linaro\n+ *\n+ * SPDX-License-Identifier: GPL-2.0-or-later\n+ */\n+\n+#include \"qemu/osdep.h\"\n+#include \"monitor/hmp.h\"\n+\n+HMP_STUB(info_mem)\ndiff --git a/hmp-commands-info.hx b/hmp-commands-info.hx\nindex 336ab870a2c..2d0a8f7d48f 100644\n--- a/hmp-commands-info.hx\n+++ b/hmp-commands-info.hx\n@@ -209,15 +209,14 @@ SRST\n Show virtual to physical memory mappings.\n ERST\n \n-#if defined(TARGET_I386) || defined(TARGET_RISCV)\n {\n .name = \"mem\",\n .args_type = \"\",\n .params = \"\",\n .help = \"show the active virtual memory mappings\",\n .cmd = hmp_info_mem,\n+ .arch_bitmask = QEMU_ARCH_I386 | QEMU_ARCH_RISCV,\n },\n-#endif\n \n SRST\n ``info mem``\ndiff --git a/stubs/meson.build b/stubs/meson.build\nindex 4a1d687a111..9aaf80e6c1b 100644\n--- a/stubs/meson.build\n+++ b/stubs/meson.build\n@@ -86,6 +86,7 @@ if have_system\n stub_ss.add(files('qmp-cpu.c'))\n stub_ss.add(files('qmp-cpu-s390x.c'))\n stub_ss.add(files('qmp-cpu-s390x-kvm.c'))\n+ stub_ss.add(files('hmp-cmd-info_mem.c'))\n stub_ss.add(files('hmp-cmd-info_sev.c'))\n stub_ss.add(files('hmp-cmds-hw-s390x.c'))\n stub_ss.add(files('hmp-cmds-target-i386.c'))\n","prefixes":["v3","13/27"]}