{"id":2222893,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222893/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260414003001.97571-16-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260414003001.97571-16-philmd@linaro.org>","date":"2026-04-14T00:29:47","name":"[v3,15/27] cpus: Introduce SysemuCPUOps::monitor_get_register() hook","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"fce56202ceb92af08c170c6d8a55909109f74b1b","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.1/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260414003001.97571-16-philmd@linaro.org/mbox/","series":[{"id":499762,"url":"http://patchwork.ozlabs.org/api/1.1/series/499762/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499762","date":"2026-04-14T00:29:32","name":"monitor: Remove need of per-target handlers","version":3,"mbox":"http://patchwork.ozlabs.org/series/499762/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222893/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222893/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=ioRPO7nz;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvlbH0CMLz1yCv\n\tfor ; Tue, 14 Apr 2026 10:32:11 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCRh8-00051m-KO; Mon, 13 Apr 2026 20:31:58 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wCRh6-0004hr-Io\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 20:31:56 -0400","from mail-wr1-x436.google.com ([2a00:1450:4864:20::436])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wCRh4-0003M0-Ls\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 20:31:56 -0400","by mail-wr1-x436.google.com with SMTP id\n ffacd0b85a97d-43d64313c39so2752313f8f.3\n for ; Mon, 13 Apr 2026 17:31:54 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d7c135fd6sm14694414f8f.28.2026.04.13.17.31.51\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Mon, 13 Apr 2026 17:31:52 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776126713; x=1776731513; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=e+EDDgWhJI3ORltCGjgBjB3nc854c+rlyGvs0etBPgA=;\n b=ioRPO7nzNfpEFh2dn+h8ECnRhycx3trFIglluKEpAa5BNKXQZ09IxuQGVKI7Jc5RV3\n BixTxW4/gCJ7EIYHPC6v0lDwPrPwU13V9Pd/VkCqJ7clH54LfM+p9kCMRvAwT3BnRROE\n kERI4nxGnS2w012DSJIAeVszbAEw1QCHrkIRkz7ywl3GfqWNs0xj1WTD09r55jHcYkmd\n ZW4nO3ZPkCij/JNnQ0hWFlV+56V43CA4Jh5MUolJwT4Q78jkB7facb2ADgNZFcI8pyD6\n EQn/6VHfqDKfzevmHlyv4Yuxyrah9DouRqMfdKgrGvqP1wTE0m7UNv8CIS/56hF7yLOF\n FNAQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776126713; x=1776731513;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=e+EDDgWhJI3ORltCGjgBjB3nc854c+rlyGvs0etBPgA=;\n b=QV35nZK6V/F3bu9Oj1HvccBwgZmnvMfJsgIyZM03+Zf0zToPKg885E9fijF7RAP9Ss\n IuBsudzkFAiKxGTthPMfm4CWQ1QtqgHWJjBwvgAgYegH2SbeEn0TUDOJrzZ/+r7KpRAH\n lXozQqdmxlfjINqPNeltHkNLk/bEwjFXg/9ZJFFp6VpnNj6BBNoBKSLKxLNMXxyeD+Hb\n 8fZZ9jjuZNbEhzjeAAxfjVbhCy8Jgy9PPLWbf6KVNcq78/xy4fSiuK5e2T1t+fjQJuvR\n wuHWOW/1NJK8Oc8KRlh9Ywy3/ZsV6w13809DPf9LHznhs3Ho0h98IfObCIKTVOOsTV1I\n fwKg==","X-Gm-Message-State":"AOJu0Yym7mwLIHD1ck27+jcp7mkUJZLqWBZ2FHoTS9eq+RFjbQenZs5+\n wYFOXbwJzbUJyp/CBHIfE3Osf8PQLIG2Ym9/FCBTyqH5gndOAg6QyhO6GpJfpNmcgG0wT4hRX9B\n WwSv91wQ=","X-Gm-Gg":"AeBDieuU6fFe4xeeKfLVQwWByFkkTAzKRrGYCB5Xd5zeTMvXNWqxJGB+XG7rb1Xm7bc\n oayZ/Xea86/Wl+sawo325WI55l1eo5/39oG/Q8TWFseaj8YleJj1zUKE6AkIbDyEkoIslxAz9bM\n 3ZhQmGNHtb+kAbQkrNO7KPTAh5imPupNH3jNEM8IEFwJWw8X2vwAeZXXaQXc182bZkGSAowIAre\n 5W5eXVrSmzU7h4vWY2pNW91en98kh/USN98HN/geh9L0UKv2hb4tqGKPEhP8B14WCiFBVuEO3s6\n 3EiggP90k4QZ8I3igNxOggo6Xzn47kecaMMJCp0tKKMV4iBp1lhrIiTshfFkCdWnB0IgVSNvqYl\n D6NtGOiM2fBcZE5JHl/M69jf+gUNH25AQ9ODR6LNMxvYmf1UNP5iCuy0zrGFlL2zQDoAGxkjvzV\n Yux/pLPLXMNbZzm2CPUqp+U9p+PqFoN3gANGP/HdCiLfOZMcmAIC8r2X3o7Nfs9T4n1+QehHUh","X-Received":"by 2002:a05:6000:1a8b:b0:43d:7e6f:37fa with SMTP id\n ffacd0b85a97d-43d7e6f38cemr3183194f8f.19.1776126712801;\n Mon, 13 Apr 2026 17:31:52 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Pierrick Bouvier ,\n Markus Armbruster ,\n Richard Henderson ,\n \"Dr. David Alan Gilbert\" ,\n Paolo Bonzini ,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Subject":"[PATCH v3 15/27] cpus: Introduce SysemuCPUOps::monitor_get_register()\n hook","Date":"Tue, 14 Apr 2026 02:29:47 +0200","Message-ID":"<20260414003001.97571-16-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260414003001.97571-1-philmd@linaro.org>","References":"<20260414003001.97571-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::436;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x436.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Allow targets to register their legacy target_get_monitor_def()\nin SysemuCPUOps; check it first in get_monitor_def() otherwise\nfall back to previous per-target helper.\n\nSigned-off-by: Philippe Mathieu-Daudé \nReviewed-by: Richard Henderson \n---\n include/hw/core/sysemu-cpu-ops.h | 8 ++++++++\n monitor/hmp-target.c | 11 ++++++++---\n 2 files changed, 16 insertions(+), 3 deletions(-)","diff":"diff --git a/include/hw/core/sysemu-cpu-ops.h b/include/hw/core/sysemu-cpu-ops.h\nindex 7b2d2d2610f..5b831393cf4 100644\n--- a/include/hw/core/sysemu-cpu-ops.h\n+++ b/include/hw/core/sysemu-cpu-ops.h\n@@ -85,6 +85,14 @@ typedef struct SysemuCPUOps {\n */\n bool (*internal_is_big_endian)(CPUState *cpu);\n \n+ /**\n+ * @monitor_get_register: Callback to fill @pval with register @name value.\n+ * This field is legacy, use @gdb_core_xml_file\n+ * to dump registers instead.\n+ * Returns: 0 on success or negative errno on failure.\n+ */\n+ int (*monitor_get_register)(CPUState *cs, const char *name, int64_t *pval);\n+\n /**\n * @legacy_vmsd: Legacy state for migration.\n * Do not use in new targets, use #DeviceClass::vmsd instead.\ndiff --git a/monitor/hmp-target.c b/monitor/hmp-target.c\nindex a222fd4c96a..46ccbd14aec 100644\n--- a/monitor/hmp-target.c\n+++ b/monitor/hmp-target.c\n@@ -35,6 +35,7 @@\n #include \"qapi/qapi-commands-control.h\"\n #include \"qapi/qapi-commands-misc.h\"\n #include \"qapi/qapi-commands-machine.h\"\n+#include \"hw/core/sysemu-cpu-ops.h\"\n \n /* Make devices configuration available for use in hmp-commands*.hx templates */\n #include CONFIG_DEVICES\n@@ -85,9 +86,13 @@ int get_monitor_def(Monitor *mon, int64_t *pval, const char *name)\n }\n }\n \n- ret = target_get_monitor_def(cs, name, &tmp);\n- if (!ret) {\n- *pval = (target_long) tmp;\n+ if (cs->cc->sysemu_ops->monitor_get_register) {\n+ ret = cs->cc->sysemu_ops->monitor_get_register(cs, name, pval);\n+ } else {\n+ ret = target_get_monitor_def(cs, name, &tmp);\n+ if (!ret) {\n+ *pval = (target_long) tmp;\n+ }\n }\n \n return ret;\n","prefixes":["v3","15/27"]}