{"id":2222858,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222858/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260413210608.2912-4-alifm@linux.ibm.com/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.1/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260413210608.2912-4-alifm@linux.ibm.com>","date":"2026-04-13T21:06:04","name":"[v13,3/7] PCI: Fail FLR when config space is inaccessible","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a355180002f8673c4c7681faf735629c2063de7f","submitter":{"id":73785,"url":"http://patchwork.ozlabs.org/api/1.1/people/73785/?format=json","name":"Farhan Ali","email":"alifm@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260413210608.2912-4-alifm@linux.ibm.com/mbox/","series":[{"id":499754,"url":"http://patchwork.ozlabs.org/api/1.1/series/499754/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=499754","date":"2026-04-13T21:06:01","name":"Error recovery for vfio-pci devices on s390x","version":13,"mbox":"http://patchwork.ozlabs.org/series/499754/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222858/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222858/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=U2bEXJjX;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-pci+bounces-52453-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com\n header.b=\"U2bEXJjX\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=148.163.156.1","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linux.ibm.com"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvg6M2K4kz1xtJ\n\tfor ; Tue, 14 Apr 2026 07:10:19 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 6D07F302462A\n\tfor ; Mon, 13 Apr 2026 21:07:28 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 2C6EC39891C;\n\tMon, 13 Apr 2026 21:06:46 +0000 (UTC)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n [148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id B6389395256;\n\tMon, 13 Apr 2026 21:06:31 +0000 (UTC)","from pps.filterd (m0360083.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63DIPdpv1434207;\n\tMon, 13 Apr 2026 21:06:17 GMT","from ppma21.wdc07v.mail.ibm.com\n (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dfdt3stq5-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tMon, 13 Apr 2026 21:06:17 +0000 (GMT)","from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1])\n\tby ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 63DHitiJ003581;\n\tMon, 13 Apr 2026 21:06:15 GMT","from smtprelay03.wdc07v.mail.ibm.com ([172.16.1.70])\n\tby ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4dg1mn6uvv-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tMon, 13 Apr 2026 21:06:15 +0000","from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com\n [10.39.53.230])\n\tby smtprelay03.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63DL5nn721955232\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tMon, 13 Apr 2026 21:05:49 GMT","from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id BD9425805C;\n\tMon, 13 Apr 2026 21:06:14 +0000 (GMT)","from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 60F2D5805A;\n\tMon, 13 Apr 2026 21:06:13 +0000 (GMT)","from IBM-D32RQW3.ibm.com (unknown [9.61.254.131])\n\tby smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n\tMon, 13 Apr 2026 21:06:13 +0000 (GMT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776114406; cv=none;\n b=rm5gRbvOzECq4GccEpbuSECsAmD9ayfvjaGdXdhtqKvrn+U+frvgY+iiuWJJ+fU2+VJI/lPFFMdsHdV5HBrEtmxdmP4luerVKE9OJAqI45EuWy4fJLXACpP2wjPycng2h6v7yKu7lf3HoTCMZuHv8KAuCBWKJIGQ+HE7ZEGCOFs=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776114406; c=relaxed/simple;\n\tbh=/A4i7jVvjy73WaQOU6JOmUh4l/ODHy9wJnwVOUgyG1k=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=JqtydYZxXO4E2x7QEndPYYgjo4CTY11GujY1FD1Qlu4EL//pU/u9oZ/zVb4fnV57tNwpjEIpXTYB83X8CaN9Z/I32E3mrWI71r/5qUdoLnG/ft9JlJ+JMgIhXPoEGyInLSnZnHNGNF6ZGRP024g/TC3GQDzNklvnLID65dfa0dE=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n spf=pass smtp.mailfrom=linux.ibm.com;\n dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com\n header.b=U2bEXJjX; arc=none smtp.client-ip=148.163.156.1","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n\t:content-transfer-encoding:date:from:in-reply-to:message-id\n\t:mime-version:references:subject:to; s=pp1; bh=Xr+EsZK/+1s603aWr\n\t/wUgOxtfADRseSmWFfwoV44DZo=; b=U2bEXJjXiQuYSV96yvTjwcVcwy/41cOVK\n\tgVyLy+lLDMJn5l1IZAtMr/Zj2ABYxdO3KkfwgkQK1qsoo7Qrd1wwfeLzypkk9IZH\n\tl48Xf8qiasWg4p7EMCxGfym1WY6/ab0mV5YCrM0ej15w/P/RmteYpIw8tlG+xdQq\n\tkFwUCdcPDuI7LM6EfnTMO0sby5QlopjcTeXGYvq4mjhQSbOg54Rf+reV1Dj4d81N\n\tBfb6ozvr6lwyTbW8RYQBmNCts72TxqQNCMo6wfxt+DNC5BSv0Xgkr9/Kqi4j7Alc\n\tep7Nk3/l1rmAyI2bovpZe5e2W0L9rbR0KjRMOB+i5d5UyV4h7UCnQ==","From":"Farhan Ali ","To":"linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,\n linux-pci@vger.kernel.org","Cc":"helgaas@kernel.org, lukas@wunner.de, alex@shazbot.org, clg@redhat.com,\n kbusch@kernel.org, alifm@linux.ibm.com, schnelle@linux.ibm.com,\n mjrosato@linux.ibm.com, Benjamin Block ","Subject":"[PATCH v13 3/7] PCI: Fail FLR when config space is inaccessible","Date":"Mon, 13 Apr 2026 14:06:04 -0700","Message-ID":"<20260413210608.2912-4-alifm@linux.ibm.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260413210608.2912-1-alifm@linux.ibm.com>","References":"<20260413210608.2912-1-alifm@linux.ibm.com>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Proofpoint-ORIG-GUID":"4zPxh-wgXZo_Nm4reROeeWPQYZrckS9D","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDEzMDIwNSBTYWx0ZWRfX+wFh33SAYx5/\n q+bnS2nraZA7Pec5cKPfP2rGL3n9tkmyKLwy3g4Vf5hYiuZUSaKU5CYxQbNJQ+S4lGAzTl0m38I\n Vj2tGNQsAh/a8j8N0DedUkXWZ1rGWEqtY9QEhzBl31VNYbJfBCdfT1F8/T1ypau0u/ne1wjiSst\n HBOQNv8IwfzOd/wZ73xj2TisUdez60wZUg23PbiH/ElTVgReefCXRO3NNbAyxIYXy8YClxB50G2\n pMVRKiPj5SaFL34x9ypoDAL+MIcVwY7Npkoz0De8l5viNz2f1ahGUUXKY0hZUFxKQyedly36Aa2\n FiWpddV3oWxVM2KnduDKlBOaVT0XIS3I+W145OimIz6OsqIAD8ZOuY7h7fi44B0d8ta3tJwMJre\n jWY/RMVQckSlOyEQYY4BwlQsZ6IKHScIJnvFI27iw8UNfGN2jpdy9cB46alN8XgnUpSi3+HV45i\n Mwce3Ai0S+IZ30WCa5g==","X-Proofpoint-GUID":"4zPxh-wgXZo_Nm4reROeeWPQYZrckS9D","X-Authority-Analysis":"v=2.4 cv=WpEb99fv c=1 sm=1 tr=0 ts=69dd5ac9 cx=c_pps\n a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17\n a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=iQ6ETzBq9ecOQQE5vZCe:22 a=VnNF1IyMAAAA:8 a=1owyFLT6pZZ0tE0DW5YA:9","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-13_03,2026-04-13_04,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n priorityscore=1501 phishscore=0 bulkscore=0 adultscore=0 spamscore=0\n malwarescore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0\n impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000\n definitions=main-2604130205"},"content":"If a device is in an error state, then it's config space may not be\naccssible. Add additional check to validate if a device's config space is\naccessible before doing an FLR reset.\n\nReviewed-by: Benjamin Block \nReviewed-by: Niklas Schnelle \nSigned-off-by: Farhan Ali \n---\n drivers/pci/pci.c | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c\nindex e71b81415392..c50418f5e318 100644\n--- a/drivers/pci/pci.c\n+++ b/drivers/pci/pci.c\n@@ -4396,6 +4396,9 @@ int pcie_reset_flr(struct pci_dev *dev, bool probe)\n \tif (!(dev->devcap & PCI_EXP_DEVCAP_FLR))\n \t\treturn -ENOTTY;\n \n+\tif (!pci_dev_config_accessible(dev, \"FLR\"))\n+\t\treturn -ENOTTY;\n+\n \tif (probe)\n \t\treturn 0;\n \n","prefixes":["v13","3/7"]}