{"id":2222857,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222857/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260413210608.2912-8-alifm@linux.ibm.com/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.1/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260413210608.2912-8-alifm@linux.ibm.com>","date":"2026-04-13T21:06:08","name":"[v13,7/7] vfio/pci: Remove the pcie check for VFIO_PCI_ERR_IRQ_INDEX","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7edb0e1820a58c686ff3c4e7f6b7837713f55fa8","submitter":{"id":73785,"url":"http://patchwork.ozlabs.org/api/1.1/people/73785/?format=json","name":"Farhan Ali","email":"alifm@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260413210608.2912-8-alifm@linux.ibm.com/mbox/","series":[{"id":499754,"url":"http://patchwork.ozlabs.org/api/1.1/series/499754/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=499754","date":"2026-04-13T21:06:01","name":"Error recovery for vfio-pci devices on s390x","version":13,"mbox":"http://patchwork.ozlabs.org/series/499754/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222857/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222857/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=iLlC6uLc;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-pci+bounces-52452-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com\n header.b=\"iLlC6uLc\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=148.163.156.1","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linux.ibm.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvg6C1ZQlz1xtJ\n\tfor ; Tue, 14 Apr 2026 07:10:11 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 23D933087413\n\tfor ; Mon, 13 Apr 2026 21:07:19 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 6B32139A7F4;\n\tMon, 13 Apr 2026 21:06:43 +0000 (UTC)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n [148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 20902395254;\n\tMon, 13 Apr 2026 21:06:31 +0000 (UTC)","from pps.filterd (m0360083.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63DEYuqS3427021;\n\tMon, 13 Apr 2026 21:06:23 GMT","from ppma22.wdc07v.mail.ibm.com\n (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dfdt3stqj-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tMon, 13 Apr 2026 21:06:23 +0000 (GMT)","from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1])\n\tby ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 63DHF68e031138;\n\tMon, 13 Apr 2026 21:06:22 GMT","from smtprelay05.dal12v.mail.ibm.com ([172.16.1.7])\n\tby ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4dg10y6yn8-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tMon, 13 Apr 2026 21:06:21 +0000","from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com\n [10.39.53.230])\n\tby smtprelay05.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63DL6KU633292992\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tMon, 13 Apr 2026 21:06:20 GMT","from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 87F7D58054;\n\tMon, 13 Apr 2026 21:06:20 +0000 (GMT)","from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 3ECB65805F;\n\tMon, 13 Apr 2026 21:06:19 +0000 (GMT)","from IBM-D32RQW3.ibm.com (unknown [9.61.254.131])\n\tby smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n\tMon, 13 Apr 2026 21:06:19 +0000 (GMT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776114403; cv=none;\n b=M8fqHKGxQgTWEUGEXWv2gzmYw3v5cgw+G2JRlpYIhWkprucwButc58LsOgSB5Qo20Z33AjR20HHJksSZb5i9GVg9wadqE3BbtSW7+G6vzwsxm4ndnCCqXcq2k/jZENANzb+52UxG1Z8mw3CGFXTnlxJL0ImaAR3c7+GSPFMDk0g=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776114403; c=relaxed/simple;\n\tbh=BI37w9SjuKL3yvCM7bDoU4en5ns30NyXBnAazDt1Q0I=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=XGRfQZDk/EBbrLr1e6mv+oWGp+EhuIeLFiHyKTeslwCFqZeZ38NrBsOFwnI21np6SngNxted2BUOP8e0cND1VEipimOIY0XuHkQJGQ8RiXrOJE15XtJgDGotxxIUtN3P+M6OIyga4Op2W4mDWqzNVThowp6xnqA+eVKDqjI8v8Y=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n spf=pass smtp.mailfrom=linux.ibm.com;\n dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com\n header.b=iLlC6uLc; arc=none smtp.client-ip=148.163.156.1","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n\t:content-transfer-encoding:date:from:in-reply-to:message-id\n\t:mime-version:references:subject:to; s=pp1; bh=ptCH11AOccuUefO9O\n\t9jqin/FEkhD0OjCVnd7OxBRv5U=; b=iLlC6uLcbE26n48o0XepzwF7Q9EZptPHI\n\t0Cj5k5S6xDW1805uGn1GpGNE87hA6ZBgbyhW+nl67YFK+QMAD4yrAVmerRViEqWK\n\tkBTFlDJS0gxkFlrfkAls3MFYsgYhqp0CRLls4uUHttD+vDr21tZBxk/JCGSN5k5c\n\tB+crE6EUmg2TnQ3BPPifIQDQq0t0O/8N3076TlVZr7Ob6a5iopvDJ9VOw5TzPobh\n\toKCiT9NjyCE5UBh/A1pFf1hHd+yWd/yA1H+isiaxDurUBu+dronYbmmIuYrbsC+5\n\tSjvAZG6g9SP2XxXZ44zG4+SK9al6dgam26OOHJxewMjwFxpAXLy5Q==","From":"Farhan Ali ","To":"linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,\n linux-pci@vger.kernel.org","Cc":"helgaas@kernel.org, lukas@wunner.de, alex@shazbot.org, clg@redhat.com,\n kbusch@kernel.org, alifm@linux.ibm.com, schnelle@linux.ibm.com,\n mjrosato@linux.ibm.com, Julian Ruess ","Subject":"[PATCH v13 7/7] vfio/pci: Remove the pcie check for\n VFIO_PCI_ERR_IRQ_INDEX","Date":"Mon, 13 Apr 2026 14:06:08 -0700","Message-ID":"<20260413210608.2912-8-alifm@linux.ibm.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260413210608.2912-1-alifm@linux.ibm.com>","References":"<20260413210608.2912-1-alifm@linux.ibm.com>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Proofpoint-ORIG-GUID":"01gz8V8Ky8gYhg-6ytjpBlEhjBTwiVYv","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDEzMDIwNSBTYWx0ZWRfX+jsbmIsLaAHv\n 0kUTzSiPoI6zzTm3Tb7CFFCW9S8tF5g7vq9r9ynoczdrA4mTTGOKVvfv/rtWkR8jreZFukrLAa1\n +5k0J8sIngfSsDXJiSUGEwyXO/nEty6jCJQ7lEKqRKYKt777G7BzMO2MMgnunVA1KXZbZf+zj3C\n 9hlv2qBFlZ7/If3nLfayz6AU2bCf/4QkbnwI/GVOfgf4l7ir6ezD4xG97vbt8L3JgQISe5xg1l4\n O65LM3BcmnYSuflnAOZL3z4bp4PhOZ9PV0Z2mdUfhIaDd2VVhBZZCSy7Sk0vGtkyqsTKJOrTZjk\n 6reWcSoXiDvQUnx137c1MtMzvbeDXHlxp+UWLzZoLJsMhkzb5J0b5tLUjk36j1Zp/H8P//ZA5Jd\n yPPaYB+TgKhGTTTgz4wUqA8Ek6Y9d/ZXwXwP3bv6/pODMGtN8j9VTMpaB5bfK7EWMbiwktR8AhT\n RG0wgirIamiIIuCrqaA==","X-Proofpoint-GUID":"01gz8V8Ky8gYhg-6ytjpBlEhjBTwiVYv","X-Authority-Analysis":"v=2.4 cv=WpEb99fv c=1 sm=1 tr=0 ts=69dd5acf cx=c_pps\n a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17\n a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=iQ6ETzBq9ecOQQE5vZCe:22 a=VnNF1IyMAAAA:8 a=r1p2_3pzAAAA:8\n a=bf5i11FZjm5gBOpVircA:9 a=r_pkcD-q9-ctt7trBg_g:22","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-13_03,2026-04-13_04,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n priorityscore=1501 phishscore=0 bulkscore=0 adultscore=0 spamscore=0\n malwarescore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0\n impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000\n definitions=main-2604130205"},"content":"The error signaling is configured for the vast majority of devices and it's\nextremely rare that it fires anyway. Removing the pcie check will allow\nuserspace to be notified on errors for legacy PCI devices. The Internal\nShared Memory (ISM) device on s390 is one such device. For PCI devices on\nIBM s390 error recovery involves platform firmware and notification to\noperating system is done by architecture specific way. So the ISM device\ncan still be recovered when notified of an error.\n\nReviewed-by: Julian Ruess \nReviewed-by: Niklas Schnelle \nReviewed-by: Alex Williamson \nSigned-off-by: Farhan Ali \n---\n drivers/vfio/pci/vfio_pci_core.c | 8 ++------\n drivers/vfio/pci/vfio_pci_intrs.c | 3 +--\n 2 files changed, 3 insertions(+), 8 deletions(-)","diff":"diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c\nindex 4485d85e4419..407be85dd565 100644\n--- a/drivers/vfio/pci/vfio_pci_core.c\n+++ b/drivers/vfio/pci/vfio_pci_core.c\n@@ -786,8 +786,7 @@ static int vfio_pci_get_irq_count(struct vfio_pci_core_device *vdev, int irq_typ\n \t\t\treturn (flags & PCI_MSIX_FLAGS_QSIZE) + 1;\n \t\t}\n \t} else if (irq_type == VFIO_PCI_ERR_IRQ_INDEX) {\n-\t\tif (pci_is_pcie(vdev->pdev))\n-\t\t\treturn 1;\n+\t\treturn 1;\n \t} else if (irq_type == VFIO_PCI_REQ_IRQ_INDEX) {\n \t\treturn 1;\n \t}\n@@ -1163,11 +1162,8 @@ static int vfio_pci_ioctl_get_irq_info(struct vfio_pci_core_device *vdev,\n \tswitch (info.index) {\n \tcase VFIO_PCI_INTX_IRQ_INDEX ... VFIO_PCI_MSIX_IRQ_INDEX:\n \tcase VFIO_PCI_REQ_IRQ_INDEX:\n-\t\tbreak;\n \tcase VFIO_PCI_ERR_IRQ_INDEX:\n-\t\tif (pci_is_pcie(vdev->pdev))\n-\t\t\tbreak;\n-\t\tfallthrough;\n+\t\tbreak;\n \tdefault:\n \t\treturn -EINVAL;\n \t}\ndiff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c\nindex 33944d4d9dc4..64f80f64ff57 100644\n--- a/drivers/vfio/pci/vfio_pci_intrs.c\n+++ b/drivers/vfio/pci/vfio_pci_intrs.c\n@@ -859,8 +859,7 @@ int vfio_pci_set_irqs_ioctl(struct vfio_pci_core_device *vdev, uint32_t flags,\n \tcase VFIO_PCI_ERR_IRQ_INDEX:\n \t\tswitch (flags & VFIO_IRQ_SET_ACTION_TYPE_MASK) {\n \t\tcase VFIO_IRQ_SET_ACTION_TRIGGER:\n-\t\t\tif (pci_is_pcie(vdev->pdev))\n-\t\t\t\tfunc = vfio_pci_set_err_trigger;\n+\t\t\tfunc = vfio_pci_set_err_trigger;\n \t\t\tbreak;\n \t\t}\n \t\tbreak;\n","prefixes":["v13","7/7"]}