{"id":2222795,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222795/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260413164338.42894-2-mohamed@unpredictable.fr/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260413164338.42894-2-mohamed@unpredictable.fr>","date":"2026-04-13T16:43:36","name":"[1/3] serial COM: windows serial COM PollingFunc don't sleep","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2549b72c1d4859f9d1994899bcd5b035048b1d72","submitter":{"id":91318,"url":"http://patchwork.ozlabs.org/api/1.1/people/91318/?format=json","name":"Mohamed Mediouni","email":"mohamed@unpredictable.fr"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260413164338.42894-2-mohamed@unpredictable.fr/mbox/","series":[{"id":499732,"url":"http://patchwork.ozlabs.org/api/1.1/series/499732/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499732","date":"2026-04-13T16:43:36","name":"win32: Windows-specific fixes from the mailing list","version":1,"mbox":"http://patchwork.ozlabs.org/series/499732/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222795/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222795/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=unpredictable.fr header.i=@unpredictable.fr\n header.a=rsa-sha256 header.s=sig1 header.b=DU7QJL1N;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvYTN459Lz1xtJ\n\tfor ; Tue, 14 Apr 2026 02:56:24 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCKZv-0004JQ-9w; Mon, 13 Apr 2026 12:56:03 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCKZu-0004JG-3J\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 12:56:02 -0400","from qs-2004f-snip4-1.eps.apple.com ([57.103.84.54]\n helo=outbound.qs.icloud.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCKZs-0006Mn-Kg\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 12:56:01 -0400","from outbound.qs.icloud.com (unknown [127.0.0.2])\n by p00-icloudmta-asmtp-us-east-2d-100-percent-5 (Postfix) with ESMTPS id\n A4F9F1800B1C; Mon, 13 Apr 2026 16:55:56 +0000 (UTC)","from localhost.localdomain (unknown [17.57.155.37])\n by p00-icloudmta-asmtp-us-east-2d-100-percent-5 (Postfix) with ESMTPSA id\n 1D0A41800543; Mon, 13 Apr 2026 16:43:43 +0000 (UTC)"],"Dkim-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr;\n s=sig1; t=1776099360; x=1778691360;\n bh=UzCpYCxioU37a8LihFnYJRJpzhI5QkED2mBVZIjSzck=;\n h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme;\n b=DU7QJL1Nv8KQtdMjuIJrUY5vBbyZdUZy0HHSywLwLbITXs/Ha3F5To6TcYSibeOvoGl+9UUftrWQarTXEL4jJP/1TVSnzGgbWAVgMtroxGoUsfRTuDuiNJ3qX8LiOywpUt6tjjzI7ynwiGWIC+wZ0LU3BPRlaZMlMkz6yrHHC7Jx2P8JIk/9Lbx9FsMB/3tZ5RI5iGtaSxPxYq+0bSYyiHSKXEiN/6FNIc0Gb5lCaKvBF7bTn+db+YSy4SpO+GcPfP0WgByP2ur80v3yV3NpeLwV5qv/FgO5jvPbd4CLa4z9V8gyDapRym9anqw2Og3j+Z/UoJ0BkOizpWM/foFTaQ==","mail-alias-created-date":"1752046281608","From":"Mohamed Mediouni ","To":"qemu-devel@nongnu.org","Cc":"Stefan Weil , Paolo Bonzini ,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n Jason Wang , Werner de Carne ","Subject":"[PATCH 1/3] serial COM: windows serial COM PollingFunc don't sleep","Date":"Mon, 13 Apr 2026 18:43:36 +0200","Message-ID":"<20260413164338.42894-2-mohamed@unpredictable.fr>","X-Mailer":"git-send-email 2.50.1","In-Reply-To":"<20260413164338.42894-1-mohamed@unpredictable.fr>","References":"<20260413164338.42894-1-mohamed@unpredictable.fr>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDEzMDE2NiBTYWx0ZWRfX+9BrMHpOftiv\n vGsR3UKdQZBbBFwcBn3+VS3Kl6wi9Fj3Rg6mT6xy+p1GiQjtm23gYehe0+a1tv/LYTJZu52E3S5\n /r/2u+R0rJFedqIPFwl6m0JTp1Q1tALu9vCoOED6m55r0qMMEPII9AACdDB0QmQmpKTGi/MMea+\n 93Kz5556jusU4ei/jR4aoKE53rWRVjUdD00liJ7IPCU2Uo0lgJjgFRLwqyOU9o+nf/0tioPyJKc\n DZ5fe8GUzW5/7aDKypfpQt1UjqhmSEp+sQx+GuG93gHg9Cc38vvvE8Ptlh1QbAYpbgzY1RyF+cR\n VBh599MsCxrtKuIuZuTlJDFTEwN/bYcWv99Z5xgCueCfEkEJK2vliS6SQxA2w0=","X-Authority-Info-Out":"v=2.4 cv=I4hohdgg c=1 sm=1 tr=0 ts=69dd201d\n cx=c_apl:c_pps:t_out a=bsP7O+dXZ5uKcj+dsLqiMw==:117\n a=bsP7O+dXZ5uKcj+dsLqiMw==:17 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=p0WdMEafAAAA:8 a=Unios6BkgxOyw5t3swQA:9","X-Proofpoint-GUID":"M1xfhkaEUfnbwya6K2NO8vctu68hy48b","X-Proofpoint-ORIG-GUID":"M1xfhkaEUfnbwya6K2NO8vctu68hy48b","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-13_03,2026-04-13_04,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=notspam policy=default score=0 bulkscore=0\n spamscore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 mlxlogscore=679\n mlxscore=0 phishscore=0 clxscore=1030 malwarescore=0 classifier=spam\n authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2604130166","Received-SPF":"pass client-ip=57.103.84.54;\n envelope-from=mohamed@unpredictable.fr; helo=outbound.qs.icloud.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Werner de Carne \n\nResolves: https://gitlab.com/qemu-project/qemu/-/issues/1802\nSigned-off-by: Werner de Carne \n---\n chardev/char-win.c | 16 ++++++++++------\n 1 file changed, 10 insertions(+), 6 deletions(-)","diff":"diff --git a/chardev/char-win.c b/chardev/char-win.c\nindex fef45e83aa..f13d526e2f 100644\n--- a/chardev/char-win.c\n+++ b/chardev/char-win.c\n@@ -28,7 +28,7 @@\n #include \"qapi/error.h\"\n #include \"chardev/char-win.h\"\n \n-static void win_chr_read(Chardev *chr, DWORD len)\n+static int win_chr_read(Chardev *chr, DWORD len)\n {\n WinChardev *s = WIN_CHARDEV(chr);\n int max_size = qemu_chr_be_can_write(chr);\n@@ -40,7 +40,7 @@ static void win_chr_read(Chardev *chr, DWORD len)\n len = max_size;\n }\n if (len == 0) {\n- return;\n+ return 0;\n }\n \n ZeroMemory(&s->orecv, sizeof(s->orecv));\n@@ -56,6 +56,8 @@ static void win_chr_read(Chardev *chr, DWORD len)\n if (size > 0) {\n qemu_chr_be_write(chr, buf, size);\n }\n+ \n+ return size > 0 ? 1 : 0;\n }\n \n static int win_chr_serial_poll(void *opaque)\n@@ -67,8 +69,9 @@ static int win_chr_serial_poll(void *opaque)\n \n ClearCommError(s->file, &comerr, &status);\n if (status.cbInQue > 0) {\n- win_chr_read(chr, status.cbInQue);\n- return 1;\n+ if (win_chr_read(chr, status.cbInQue)) {\n+\t\t\treturn 1;\n+\t\t}\n }\n return 0;\n }\n@@ -147,8 +150,9 @@ int win_chr_pipe_poll(void *opaque)\n \n PeekNamedPipe(s->file, NULL, 0, NULL, &size, NULL);\n if (size > 0) {\n- win_chr_read(chr, size);\n- return 1;\n+ \tif (win_chr_read(chr, size)) {\n+\t\t\treturn 1;\n+\t\t}\n }\n return 0;\n }\n","prefixes":["1/3"]}