{"id":2222789,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222789/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260413165217.47105-15-mohamed@unpredictable.fr/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260413165217.47105-15-mohamed@unpredictable.fr>","date":"2026-04-13T16:52:16","name":"[v11,14/15] hw/intc: apic: disallow APIC reads when disabled","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"6585ef04a1f1285be77ac67d756710ee109417b2","submitter":{"id":91318,"url":"http://patchwork.ozlabs.org/api/1.1/people/91318/?format=json","name":"Mohamed Mediouni","email":"mohamed@unpredictable.fr"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260413165217.47105-15-mohamed@unpredictable.fr/mbox/","series":[{"id":499730,"url":"http://patchwork.ozlabs.org/api/1.1/series/499730/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499730","date":"2026-04-13T16:52:04","name":"whpx: i386: bug fixes, feature probing and CPUID","version":11,"mbox":"http://patchwork.ozlabs.org/series/499730/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222789/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222789/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=unpredictable.fr header.i=@unpredictable.fr\n header.a=rsa-sha256 header.s=sig1 header.b=KM9nd+mz;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvYRp6JyYz1yDG\n\tfor ; Tue, 14 Apr 2026 02:55:02 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCKYK-0007Y0-1K; Mon, 13 Apr 2026 12:54:24 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCKXl-0006wM-74\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 12:53:50 -0400","from p-west2-cluster1-host6-snip4-7.eps.apple.com ([57.103.68.60]\n helo=outbound.mr.icloud.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCKXj-0005bA-RA\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 12:53:48 -0400","from outbound.mr.icloud.com (unknown [127.0.0.2])\n by p00-icloudmta-asmtp-us-west-2a-10-percent-1 (Postfix) with ESMTPS id\n 1F0DB1800EBA; Mon, 13 Apr 2026 16:53:44 +0000 (UTC)","from localhost.localdomain (unknown [17.57.152.38])\n by p00-icloudmta-asmtp-us-west-2a-10-percent-1 (Postfix) with ESMTPSA id\n 4EA1118023A5; Mon, 13 Apr 2026 16:53:41 +0000 (UTC)"],"Dkim-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr;\n s=sig1; t=1776099226; x=1778691226;\n bh=SCqUAJvB1zqKRh44vHU0QIqywz/suuWsKXqtx/ZiPkM=;\n h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme;\n b=KM9nd+mzg2DuAAMpzJ9/tpGllWc3XQK533a1LrsD8mDgbRDK6UwCAo6A9hfWAtKYH6+Dp+S6jjJYyECFP5cjDTPYs+8MPgewGZMjPoTNx60gYi8Sv4c8/A3+T9Bcexq9w5IqpLl0NsxVabhltdVqqQB9M7niXcgtrY1Pk219/DYHqQVf3eNQPmlcw+e+T7R0GITOmcmwUg81Ge0GP8H7gIwO8k/F1hPP6fbIc80zyIyPQaOwxeqmSKXNwWEpo1ILfXzNQNy8OKYXyoRC93vpiKJZ1kLV/Zo7HiePfomEpeH56zWVMOt1V3qODq0zDyOAozx0GlNf0J4pZs4t7VodoA==","mail-alias-created-date":"1752046281608","From":"Mohamed Mediouni ","To":"qemu-devel@nongnu.org","Cc":"\"Michael S. Tsirkin\" ,\n Pedro Barbuda ,\n Mohamed Mediouni ,\n Paolo Bonzini , Zhao Liu ,\n Roman Bolshakov , Wei Liu ,\n Phil Dennis-Jordan ","Subject":"[PATCH v11 14/15] hw/intc: apic: disallow APIC reads when disabled","Date":"Mon, 13 Apr 2026 18:52:16 +0200","Message-ID":"<20260413165217.47105-15-mohamed@unpredictable.fr>","X-Mailer":"git-send-email 2.50.1","In-Reply-To":"<20260413165217.47105-1-mohamed@unpredictable.fr>","References":"<20260413165217.47105-1-mohamed@unpredictable.fr>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Proofpoint-ORIG-GUID":"NcsbE5_Bg3kp2_1-i5uRuQEyXNbecz4D","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDEzMDE2NiBTYWx0ZWRfX43q0zF5F96mb\n 0HcNCH5sSnKnfk71SLJ4kUIbnqLPwWPZVS8snrG+Zqwcv5ACnOs/DzVYxJY0Bmw40KWLCXr7oEq\n 81rZFy3aAmoyav2R1ykUegP4kEBGJcrS4rpcgs2eTV6dyWxseEikdgKE3/18Wzm7JOmPHdPmKeH\n ovyU4tA1AMoYZKLb20WmqAT3UCy2Llb4uHA48bER8ZdlmRP/GDjdOUvXo91RWRGWFjw20vLV2uG\n 5Y7as/wMsVURBZglsKWkKItPvDob4tGmx65f5ySX5qOMsDinUK2qtT2q+DFFquUkb0m2y4FYtuJ\n R0cB8E0IhuIU1jDie1V0/V+0LOLpjBtZUoFLuXUJQX89z2f86qqgpNe1MR6OBY=","X-Authority-Info-Out":"v=2.4 cv=RpTI7SmK c=1 sm=1 tr=0 ts=69dd1f9a\n cx=c_apl:c_pps:t_out a=9OgfyREA4BUYbbCgc0Y0oA==:117\n a=9OgfyREA4BUYbbCgc0Y0oA==:17 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=Sz3nRv2TKcqVAncp5HQA:9","X-Proofpoint-GUID":"NcsbE5_Bg3kp2_1-i5uRuQEyXNbecz4D","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-13_03,2026-04-13_04,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=notspam policy=default score=0 spamscore=0\n lowpriorityscore=0 adultscore=0 malwarescore=0 phishscore=0 bulkscore=0\n mlxlogscore=800 mlxscore=0 suspectscore=0 clxscore=1030 classifier=spam\n authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2604130166","Received-SPF":"pass client-ip=57.103.68.60;\n envelope-from=mohamed@unpredictable.fr; helo=outbound.mr.icloud.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"!APICBASE_ENABLE + attempting to read xAPIC registers is not an allowed combination.\n\nAnd neither is x2APIC enabled + attempting to read xAPIC registers\n\nSigned-off-by: Mohamed Mediouni \n---\n hw/intc/apic.c | 9 +++++++++\n 1 file changed, 9 insertions(+)","diff":"diff --git a/hw/intc/apic.c b/hw/intc/apic.c\nindex 8766ed00b9..c09dddef39 100644\n--- a/hw/intc/apic.c\n+++ b/hw/intc/apic.c\n@@ -875,6 +875,15 @@ static uint64_t apic_mem_read(void *opaque, hwaddr addr, unsigned size)\n return -1;\n }\n \n+ /* if the xAPIC is disabled, return early. */\n+ if (!(s->apicbase & MSR_IA32_APICBASE_ENABLE)) {\n+ return 0xffffffff;\n+ }\n+\n+ if (s->apicbase & MSR_IA32_APICBASE_EXTD) {\n+ return 0xffffffff;\n+ }\n+\n index = (addr >> 4) & 0xff;\n apic_register_read(s, index, &val);\n \n","prefixes":["v11","14/15"]}