{"id":2222763,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222763/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260413152326.63738-11-mohamed@unpredictable.fr/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260413152326.63738-11-mohamed@unpredictable.fr>","date":"2026-04-13T15:23:22","name":"[v10,10/14] whpx: i386: IO port fast path cleanup","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"31475a5ad9d98230a9d0aa6d0b833df4a17e1e62","submitter":{"id":91318,"url":"http://patchwork.ozlabs.org/api/1.1/people/91318/?format=json","name":"Mohamed Mediouni","email":"mohamed@unpredictable.fr"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260413152326.63738-11-mohamed@unpredictable.fr/mbox/","series":[{"id":499721,"url":"http://patchwork.ozlabs.org/api/1.1/series/499721/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499721","date":"2026-04-13T15:23:12","name":"whpx: i386: bug fixes, feature probing and CPUID","version":10,"mbox":"http://patchwork.ozlabs.org/series/499721/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222763/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222763/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=unpredictable.fr header.i=@unpredictable.fr\n header.a=rsa-sha256 header.s=sig1 header.b=R6+bE7zo;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvWT14YM7z1xtJ\n\tfor ; Tue, 14 Apr 2026 01:25:57 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCJ8u-0005ji-RQ; Mon, 13 Apr 2026 11:24:04 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCJ8f-0005Xl-H8\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 11:23:51 -0400","from qs-2005g-snip4-5.eps.apple.com ([57.103.86.196]\n helo=outbound.qs.icloud.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCJ8d-0000Uo-Vo\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 11:23:49 -0400","from outbound.qs.icloud.com (unknown [127.0.0.2])\n by p00-icloudmta-asmtp-us-east-2d-100-percent-10 (Postfix) with ESMTPS id\n 4097C1800135; Mon, 13 Apr 2026 15:23:45 +0000 (UTC)","from localhost.localdomain (unknown [17.57.155.37])\n by p00-icloudmta-asmtp-us-east-2d-100-percent-10 (Postfix) with ESMTPSA id\n 6C58318000A9; Mon, 13 Apr 2026 15:23:43 +0000 (UTC)"],"Dkim-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr;\n s=sig1; t=1776093827; x=1778685827;\n bh=G89W4sMC3YwwxzvqsgVypuGjICEkNIb9nBQsRfciAZw=;\n h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme;\n b=R6+bE7zoj7oBfFP8RsZg6QlDDBHEMqvM6EoWDWkqWx/a8tpRS4isnHMcRsSL3Ude3uZv2pn7deopafIoXo7iIQThFOhYXWWkONN/+mFnpSNhf7ZZ/l/kzhxzwSsSFusjMOu6JCLe7uUVoJtuN8SrKvTFm5J5zZULCrAukoIYybyJS9NAFVG+dWNS/Xa7R4XwgxUIAvG70xFv6j3c2u4BRMOPO5cjR+mQyoZg9gd0Z/qsbJ60g/ppcai13dEPlvxz2MxCoQuDwLy+3WQYr2yb5mcdr+NHzWc/OAW5O22iW0cqtQz7rJsrnJ4N76DCvkF8ebjG29HXtdRVzcYYGWHXnA==","mail-alias-created-date":"1752046281608","From":"Mohamed Mediouni ","To":"qemu-devel@nongnu.org","Cc":"Zhao Liu , \"Michael S. Tsirkin\" ,\n Paolo Bonzini , Wei Liu ,\n Roman Bolshakov ,\n Pedro Barbuda ,\n Mohamed Mediouni ,\n Phil Dennis-Jordan ","Subject":"[PATCH v10 10/14] whpx: i386: IO port fast path cleanup","Date":"Mon, 13 Apr 2026 17:23:22 +0200","Message-ID":"<20260413152326.63738-11-mohamed@unpredictable.fr>","X-Mailer":"git-send-email 2.50.1","In-Reply-To":"<20260413152326.63738-1-mohamed@unpredictable.fr>","References":"<20260413152326.63738-1-mohamed@unpredictable.fr>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDEzMDE1MSBTYWx0ZWRfXx6LjKkf+MynM\n dDLk/MJBRWwfZQ8Z5Sf1vixAZ07Qp2MTPwS2zF2cQfxwaqExK/YUw5Q6nOJluHJkwIWLEFtTR0x\n 2KUwu2VhNxNAMn4+yt3LTyP2oupnMSI+qh7g51xZ/JkzRZaUbe9HdrcVHtQZAp/HW0wa2Zm392B\n BQy0T45LsbHq2KUIe1Na5VSX/xlu7E+ZARfMCu9qVBCsSJV7XMg0GekscvBxGSOCu3wUc2MItq/\n EuqVecthFNKOZhBcjPywS/3UL4A53ZpcLaKxQ4Pwqsq7EUh8lPdBHUt8VVtiEAhElF4VHhOZJ1S\n 7kVG3FdSENKUpxQ9Ug9PJOrDmd9frXMb4UFIqKr1Y28C53IF1V7jq66FQRIZ1Y=","X-Proofpoint-GUID":"LDp9tnS6bRPzTsZA8uhi45_bHLsXLKmh","X-Authority-Info-Out":"v=2.4 cv=LNRrgZW9 c=1 sm=1 tr=0 ts=69dd0a82\n cx=c_apl:c_pps:t_out a=bsP7O+dXZ5uKcj+dsLqiMw==:117\n a=bsP7O+dXZ5uKcj+dsLqiMw==:17 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=Vrzv6M8N8vcM0KmfSJEA:9","X-Proofpoint-ORIG-GUID":"LDp9tnS6bRPzTsZA8uhi45_bHLsXLKmh","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-13_03,2026-04-13_04,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=notspam policy=default score=0 clxscore=1030\n lowpriorityscore=0 spamscore=0 mlxlogscore=805 bulkscore=0 adultscore=0\n suspectscore=0 malwarescore=0 phishscore=0 mlxscore=0 classifier=spam\n authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2604130151","Received-SPF":"pass client-ip=57.103.86.196;\n envelope-from=mohamed@unpredictable.fr; helo=outbound.qs.icloud.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"vmport calls synchronise_state within an I/O port read.\nSupport that properly.\n\nWhat was there before worked because of a side effect of\nwhpx_get_reg synchronising context if cpu->vcpu_dirty.\n\nRemove that whpx_get_reg call in whpx_bump_rip too as it's no longer\nneeded now.\n\nSigned-off-by: Mohamed Mediouni \n---\n target/i386/whpx/whpx-all.c | 17 +++++++++++++----\n 1 file changed, 13 insertions(+), 4 deletions(-)","diff":"diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c\nindex 7c80d653d1..61aec98e66 100644\n--- a/target/i386/whpx/whpx-all.c\n+++ b/target/i386/whpx/whpx-all.c\n@@ -862,7 +862,6 @@ static void handle_io(CPUState *env, uint16_t port, void *buffer,\n static void whpx_bump_rip(CPUState *cpu, WHV_RUN_VP_EXIT_CONTEXT *exit_ctx)\n {\n WHV_REGISTER_VALUE reg;\n- whpx_get_reg(cpu, WHvX64RegisterRip, ®);\n reg.Reg64 = exit_ctx->VpContext.Rip + exit_ctx->VpContext.InstructionLength;\n whpx_set_reg(cpu, WHvX64RegisterRip, reg);\n }\n@@ -890,13 +889,23 @@ static int whpx_handle_portio(CPUState *cpu,\n } else {\n reg.Reg64 = (uint64_t)val;\n }\n- whpx_bump_rip(cpu, exit_ctx);\n- whpx_set_reg(cpu, WHvX64RegisterRax, reg);\n+ /* vmport calls cpu_synchronize_state on an I/O port read */\n+ if (!cpu->vcpu_dirty) {\n+ whpx_bump_rip(cpu, exit_ctx);\n+ whpx_set_reg(cpu, WHvX64RegisterRax, reg);\n+ } else {\n+ env->eip = exit_ctx->VpContext.Rip + exit_ctx->VpContext.InstructionLength;\n+ env->regs[R_EAX] = reg.Reg64;\n+ }\n return 0;\n } else if (!ctx->AccessInfo.StringOp && ctx->AccessInfo.IsWrite) {\n RAX(env) = ctx->Rax;\n handle_io(cpu, ctx->PortNumber, &RAX(env), 1, ctx->AccessInfo.AccessSize, 1);\n- whpx_bump_rip(cpu, exit_ctx);\n+ if (!cpu->vcpu_dirty) {\n+ whpx_bump_rip(cpu, exit_ctx);\n+ } else {\n+ env->eip = exit_ctx->VpContext.Rip + exit_ctx->VpContext.InstructionLength;\n+ }\n return 0;\n }\n \n","prefixes":["v10","10/14"]}