{"id":2222690,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222690/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260413130007.1987326-5-sjg@chromium.org/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.1/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260413130007.1987326-5-sjg@chromium.org>","date":"2026-04-13T12:59:55","name":"[v3,4/8] test: Add a check for a missing kernel","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"121d2111987a108509e2ad9ab8e4badd6b416bc9","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/1.1/people/6170/?format=json","name":"Simon Glass","email":"sjg@chromium.org"},"delegate":{"id":3651,"url":"http://patchwork.ozlabs.org/api/1.1/users/3651/?format=json","username":"trini","first_name":"Tom","last_name":"Rini","email":"trini@ti.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260413130007.1987326-5-sjg@chromium.org/mbox/","series":[{"id":499699,"url":"http://patchwork.ozlabs.org/api/1.1/series/499699/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=499699","date":"2026-04-13T12:59:52","name":"test: Refactor FIT test for clarity and extensibility","version":3,"mbox":"http://patchwork.ozlabs.org/series/499699/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222690/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222690/checks/","tags":{},"headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=Hg3yK/Vy;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"Hg3yK/Vy\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvSH26sFSz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 13 Apr 2026 23:02:06 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id E0CCC8420C;\n\tMon, 13 Apr 2026 15:01:46 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id E8DE684206; Mon, 13 Apr 2026 15:01:43 +0200 (CEST)","from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com\n [IPv6:2607:f8b0:4864:20::32d])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 2D9238421E\n for <u-boot@lists.denx.de>; Mon, 13 Apr 2026 15:01:40 +0200 (CEST)","by mail-ot1-x32d.google.com with SMTP id\n 46e09a7af769-7dbd2a0211bso3198826a34.0\n for <u-boot@lists.denx.de>; Mon, 13 Apr 2026 06:01:39 -0700 (PDT)","from chromium.org ([73.34.74.121]) by smtp.gmail.com with ESMTPSA id\n 46e09a7af769-7dc2696532bsm8369144a34.21.2026.04.13.06.01.30\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 13 Apr 2026 06:01:30 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1776085298; x=1776690098; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ZP3cEdp5tuFD39RdYbKTOiJH5T0HwxarL8EsOAFcnho=;\n b=Hg3yK/VyHDjlYgH5PHqCDlnWr5tvRmqVqfK6mNiFz66OEnz5d9MiVOR/Ndarh8V3BD\n ryIvcjTneh0ZzdnsgJrWL1lU6OpYr0OqRgTTssMraepVqZ3/DOGAFDDpsbfk3aotqrAH\n 9TSPAoS6D5K0eNdnt7+ZMqk/7e6UyG909hrIA=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776085298; x=1776690098;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=ZP3cEdp5tuFD39RdYbKTOiJH5T0HwxarL8EsOAFcnho=;\n b=MsKOQSyOyF+YKL76iZaXKFuUl80Foum/VfogUJyAbww0fwpbOwunNPHZCGAtAoMszU\n 7JQyNZjl59TyJH8VMEhdmViffaq4PX6WaY+jgaGdnjNqAVE7+m4f9aix0qChvJFAut4D\n zImQMGssYguvGii63OjOeHrHNIu7auQxLXmI2zgQw/LifIqEjEriyuGXgYd3T8cv3svg\n k6yM0GuVbqEZXjIJ/iOtw8z4Wq3bBpf3n8V/1nlry7GTUazxeBfL/oNkWttojr9GPscG\n yway/93S0qcTXMJDNd9NYt2QoalYS68BZkHZS5kBrM0pJ/5Rw5TMI7q/+/BQc0TnkEaP\n kUvw==","X-Gm-Message-State":"AOJu0YxjMKNcP3opdZ0LLvsOkKPHNdLKYh7MUt2r9TPnWoZ3LG3yQYKF\n bmQD7gJSo0aPUCiPn41wV1Rn/Oow/qxL0INbxoTQpJO01pZlf5BYvwKv8rQyUZcERrUChUAEqMX\n JaRb2vQ==","X-Gm-Gg":"AeBDietF/Zeio4EZo8Z+2uKEa+FKhdm41Zhpwn+FWNX4j/9K9b2MlGtRjL278Z6Kz1z\n KYCtdKjMT+eC5WenVp4KKwVZJ2N5C0h4r+e5k6GRtG99o3Uy69iOXWTyJtYSiQviNJU8j7trx3k\n bFVAlmTZA740s2Y3CeFFgCxS7gfzAxzjRiwicgndhB/FwXdcaWi1qV59n25Co9I2zXfPcret+pE\n F3VST2f5yj3HxO54eCSqLQbP8Q5G+r65Hb807TanyXJo26G0kjulvIsGxQWHMwy2WW1Dt2I9Hoz\n RTKi5uijLW1N1fTBlJdE24y4ol1QLf9bNBb4CQppBP8ny071YT6dLECDVH+aB/DQ1RBzyUDYoba\n EoPT+NgjQoZpAKqOK3X2ga+x2IBswrLYAvqYMCC7ZEXX+/UzdVwxT8sHtaMRPIvyC470imL4b38\n uLNuKp4zl/yf+fgBeqB2Wshux1Qgts","X-Received":"by 2002:a05:6830:3745:b0:7dc:67:8c9b with SMTP id\n 46e09a7af769-7dc27d93540mr8854543a34.4.1776085291233;\n Mon, 13 Apr 2026 06:01:31 -0700 (PDT)","From":"Simon Glass <sjg@chromium.org>","To":"u-boot@lists.denx.de","Cc":"Simon Glass <sjg@chromium.org>,\n\tTom Rini <trini@konsulko.com>","Subject":"[PATCH v3 4/8] test: Add a check for a missing kernel","Date":"Mon, 13 Apr 2026 06:59:55 -0600","Message-ID":"<20260413130007.1987326-5-sjg@chromium.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260413130007.1987326-1-sjg@chromium.org>","References":"<20260413130007.1987326-1-sjg@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"U-Boot should complain if the kernel is missing, so add a check for this\nin test_fit_base()\n\nSigned-off-by: Simon Glass <sjg@chromium.org>\n---\n\n(no changes since v1)\n\n test/py/tests/test_fit.py | 13 +++++++++++--\n 1 file changed, 11 insertions(+), 2 deletions(-)","diff":"diff --git a/test/py/tests/test_fit.py b/test/py/tests/test_fit.py\nindex 4c7d400bc6a..9bfe25c0a51 100755\n--- a/test/py/tests/test_fit.py\n+++ b/test/py/tests/test_fit.py\n@@ -70,7 +70,7 @@ base_its = '''\n         configurations {\n                 default = \"conf-1\";\n                 conf-1 {\n-                        kernel = \"kernel-1\";\n+                        %(kernel_config)s\n                         fdt = \"fdt-1\";\n                         %(ramdisk_config)s\n                         %(loadables_config)s\n@@ -281,6 +281,7 @@ def test_fit_base(ubman):\n             'kernel_out' : kernel_out,\n             'kernel_addr' : 0x40000,\n             'kernel_size' : filesize(kernel),\n+            'kernel_config' : 'kernel = \"kernel-1\";',\n \n             'fdt' : fdt,\n             'fdt_out' : fdt_out,\n@@ -389,8 +390,16 @@ def test_fit_base(ubman):\n             check_equal(kernel, kernel_out, 'Kernel not loaded')\n             check_equal(fdt_data, fdt_out, 'FDT not loaded')\n             check_not_equal(ramdisk, ramdisk_out, 'Ramdisk got decompressed?')\n-            check_equal(ramdisk + '.gz', ramdisk_out, 'Ramdist not loaded')\n+            check_equal(ramdisk + '.gz', ramdisk_out, 'Ramdisk not loaded')\n \n+        # Try without a kernel\n+        with ubman.log.section('No kernel + FDT'):\n+            params['kernel_config'] = ''\n+            params['ramdisk_config'] = ''\n+            params['ramdisk_load'] = ''\n+            fit = fit_util.make_fit(ubman, mkimage, base_its, params)\n+            output = ubman.run_command_list(cmd.splitlines())\n+            assert \"can't get kernel image!\" in '\\n'.join(output)\n \n     mkimage = ubman.config.build_dir + '/tools/mkimage'\n     run_fit_test(mkimage)\n","prefixes":["v3","4/8"]}