{"id":2222666,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222666/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260413-casey-qcom-geni-rpmh-fixes-v1-2-2a83a67ac0f1@linaro.org/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.1/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260413-casey-qcom-geni-rpmh-fixes-v1-2-2a83a67ac0f1@linaro.org>","date":"2026-04-13T11:06:15","name":"[2/3] soc/qcom: rpmh: only allow rpmh writes of a single command","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ce0ad6a4069088d4b21d026958e49577b748e696","submitter":{"id":90679,"url":"http://patchwork.ozlabs.org/api/1.1/people/90679/?format=json","name":"Casey Connolly","email":"casey.connolly@linaro.org"},"delegate":{"id":151538,"url":"http://patchwork.ozlabs.org/api/1.1/users/151538/?format=json","username":"kcxt","first_name":"Casey","last_name":"Connolly","email":"casey.connolly@linaro.org"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260413-casey-qcom-geni-rpmh-fixes-v1-2-2a83a67ac0f1@linaro.org/mbox/","series":[{"id":499682,"url":"http://patchwork.ozlabs.org/api/1.1/series/499682/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=499682","date":"2026-04-13T11:06:13","name":"Qualcomm: rpmh and regulator fixes","version":1,"mbox":"http://patchwork.ozlabs.org/series/499682/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222666/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222666/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=y0fnwreT;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.b=\"y0fnwreT\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org","phobos.denx.de;\n spf=pass smtp.mailfrom=casey.connolly@linaro.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvPjr6VLMz1yDF\n\tfor ; Mon, 13 Apr 2026 21:06:40 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id E39A3841CD;\n\tMon, 13 Apr 2026 13:06:29 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 31EA084119; Mon, 13 Apr 2026 13:06:23 +0200 (CEST)","from mail-wm1-x336.google.com (mail-wm1-x336.google.com\n [IPv6:2a00:1450:4864:20::336])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 59C5583F75\n for ; Mon, 13 Apr 2026 13:06:19 +0200 (CEST)","by mail-wm1-x336.google.com with SMTP id\n 5b1f17b1804b1-48374014a77so60202815e9.3\n for ; Mon, 13 Apr 2026 04:06:19 -0700 (PDT)","from lion.localdomain (p4fc3dd86.dip0.t-ipconnect.de.\n [79.195.221.134]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488d5347ea5sm327284945e9.8.2026.04.13.04.06.17\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 13 Apr 2026 04:06:17 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776078378; x=1776683178; darn=lists.denx.de;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=KuO7+RKIoPCYl+xOEAftzGlHG2Bn8WUqFrSXa3J/7rc=;\n b=y0fnwreT4sXOmtUX9hiw4VLso5bmvc7xKrn//BcBplms3KWWHVy0UwzkTOYxlsSYVq\n uLq2/eS4uADaBkpVeZVw/aZbraqvWErd5HL/5idFQoiBTulAy5KZonwb8XgsSFfxnPrb\n QcgidN9qUqcf9n6pZEimRORCF31oyx7aoT6NaPCB+jF4l1ezeLEL+N6tP3Lx+BTM3QEg\n MKkAnlCFiTmJQf3F9VOW1VE3/Bu+MRFmHyFs2/zlBQpCxPEbRlyvqLhsKfw+FLyj8RbY\n dmJGbf3ztxFisVJZbAxYHbv9VfQDK7A5jdz8dK0/AoxyxACHXNj7+AAOSQN0mC45eu+N\n R7JQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776078378; x=1776683178;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=KuO7+RKIoPCYl+xOEAftzGlHG2Bn8WUqFrSXa3J/7rc=;\n b=HwizjuF08rGnTZRnLAjFK5Wt+00zIfAVXJDo5ATmHJbjgmzlvgAs1L85Ii9l3AS9vx\n OxJeETSDB/RPdPtD3SEE6D4h2zKuQB/xv+RrldB1mpyNkV0PPbQ5lzz0qMn3DxRHx/95\n l/BjqxLlA7avesAgCjCNh7f+wY3HRWIEZu9hObqUmcemHskSVUq/oTQeB4hpT0UvTvl8\n 5hIQR1WqoK2qB+d9lKB0RlaO2ojb5/9r0HoXn54t3p0t5m6VzByzlCyQvNwm7deMq+v8\n iIaWvBjNLNYzL4PULXBo3QmBFJCJ3Agqy4JLvhHmD0DLp+tfRx5Z/60OoXORZSH5XO17\n QskQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9XZntu/FZd+a9fajbwy4bju50bNla8C6gCObGs6VelpooLaTmoWLBAYGT7B2uJDT7Uc4ifPvI=@lists.denx.de","X-Gm-Message-State":"AOJu0YyBWlb6SrW35YQWa74tIeB7kIubDs/Ht3wAA8o19wB5RQdboKFX\n 1H+6dgQGXkFR4QqWCs+9yaOxbyWLQfQPHkWe14iOMRgdygRo9yfwnJomjpaXbcyDtPeiaxK0M1l\n ntXJTHS8=","X-Gm-Gg":"AeBDieskwJAvoCpYHL5UOU+hd7f+XgUf14se/eVomAswgrcrbsl+0BDLdJ2vtVMKEaQ\n h8/NLJVbvFIToDw792bWnLtmlm0JgaM4XIDXeaobcSV6CCYp2qqQ/KspjnPeQDC7rNjzjpSVVWO\n O8MSHPumgM+R91foRp1RLBZyL1aJrvJRXGWdIb2bt9NI1yi9yq1mR6P5v7qmp76z++8oP7pmFlH\n GfuwsjUgzohbx3TqBs60TV5oQB5jwwQ5qwzijtZNMWB3KLNYi/Oi9LUXjzI0YGdvxLEOSJzvAB1\n bzt4cF+1yXpF/LOq/d963JX8U1JhnKA0B3ISK0gPNE78gCSPA0+ylXXTEMjrjfzqLCuKAx1x6P4\n XKX5GRJZ/Vi1UODhc2d/29Vg+XsKGTE4bqsc4YC4xZB8MPAjcAG0+BvlsNB883IXmZx9UEHFI5t\n /H+caAGZPuu+WfmzGq8wii5xOaCPNMdwwdezhKUv5oMzUJ0aKa9FFqyUUodLhTQOWtjQLt","X-Received":"by 2002:a05:600c:8706:b0:488:a62d:76d7 with SMTP id\n 5b1f17b1804b1-488d67df53cmr181160965e9.1.1776078378373;\n Mon, 13 Apr 2026 04:06:18 -0700 (PDT)","From":"Casey Connolly ","Date":"Mon, 13 Apr 2026 13:06:15 +0200","Subject":"[PATCH 2/3] soc/qcom: rpmh: only allow rpmh writes of a single\n command","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260413-casey-qcom-geni-rpmh-fixes-v1-2-2a83a67ac0f1@linaro.org>","References":"<20260413-casey-qcom-geni-rpmh-fixes-v1-0-2a83a67ac0f1@linaro.org>","In-Reply-To":"\n <20260413-casey-qcom-geni-rpmh-fixes-v1-0-2a83a67ac0f1@linaro.org>","To":"Sumit Garg , u-boot-qcom@groups.io,\n u-boot@lists.denx.de","Cc":"Casey Connolly ,\n Neil Armstrong , Tom Rini ,\n Jaehoon Chung , Peng Fan ,\n Aswin Murugan ","X-Mailer":"b4 0.15-dev-47773","X-Developer-Signature":"v=1; a=openpgp-sha256; l=2331;\n i=casey.connolly@linaro.org; h=from:subject:message-id;\n bh=4BBM5Z9rZMlSFJ/wYNUneY37xxkh5ZLsgZ/9c0ZNpoQ=;\n b=owGbwMvMwCFYaeA6f6eBkTjjabUkhsw759RYWz0PzcpKV3bMr153KaJ9zRHXyulT/nN+aj21t\n 9jz76tpHaUsDIIcDLJiiiziJ5ZZNq29bK+xfcEFmDmsTCBDGLg4BWAi/y8w/OG8/f4+t99U5vKM\n VTN4Wqsbp0ofSPTy09vq8Oye0kal3rsM/yyk729cXlI+jaPpVhG/+rk/6/lM96nk1nc+yp370nv\n P5VcA","X-Developer-Key":"i=casey.connolly@linaro.org; a=openpgp;\n fpr=83B24DA7FE145076BC38BB250CD904EB673A7C47","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"With how we currently handle synchronous RPMh access in U-Boot (being\nderived from the async-heavy Linux driver), with available documentation\nit doesn't seem to be easy to get multiple commands per TCS request\nto work correctly, resulting in a broken state. This likely needs more\ntesting to find a better fix but for now this seems to resolve issues we\nhit in Linux on sm8650.\n\nSigned-off-by: Casey Connolly \n---\n drivers/interconnect/qcom/bcm-voter.c | 16 ++++++++++------\n drivers/soc/qcom/rpmh.c | 6 ++++++\n 2 files changed, 16 insertions(+), 6 deletions(-)","diff":"diff --git a/drivers/interconnect/qcom/bcm-voter.c b/drivers/interconnect/qcom/bcm-voter.c\nindex 361b03f207a9..5d284448fdf4 100644\n--- a/drivers/interconnect/qcom/bcm-voter.c\n+++ b/drivers/interconnect/qcom/bcm-voter.c\n@@ -292,15 +292,19 @@ int qcom_icc_bcm_voter_commit(struct bcm_voter *voter)\n \ttcs_list_gen(voter, QCOM_ICC_BUCKET_AMC, cmds, commit_idx);\n \tif (!commit_idx[0])\n \t\tgoto out;\n \n-\tfor (int i = 0 ; commit_idx[i] ; ++i) {\n-\t\tret = rpmh_write(voter->dev, RPMH_ACTIVE_ONLY_STATE,\n-\t\t\t\t &cmds[i], commit_idx[i]);\n-\t\tif (ret) {\n-\t\t\tpr_err(\"Error sending AMC RPMH requests (%d)\\n\", ret);\n-\t\t\tgoto out;\n+\t/* U-Boot: don't combine votes into a single message since it doesn't work properly */\n+\tfor (int i = 0, k = 0 ; commit_idx[i] ; ++i) {\n+\t\tfor (int j = 0; j < commit_idx[i]; j++) {\n+\t\t\tret = rpmh_write(voter->dev, RPMH_ACTIVE_ONLY_STATE,\n+\t\t\t\t\t &cmds[k + j], 1);\n+\t\t\tif (ret) {\n+\t\t\t\tpr_err(\"Error sending AMC RPMH requests (%d)\\n\", ret);\n+\t\t\t\tgoto out;\n+\t\t\t}\n \t\t}\n+\t\tk += commit_idx[i];\n \t}\n \n \t/* TOFIX vote for WAKE & SLEEP ?? */\n \ndiff --git a/drivers/soc/qcom/rpmh.c b/drivers/soc/qcom/rpmh.c\nindex b55e23c4417d..685ac5d27cef 100644\n--- a/drivers/soc/qcom/rpmh.c\n+++ b/drivers/soc/qcom/rpmh.c\n@@ -132,8 +132,14 @@ int rpmh_write(const struct udevice *dev, enum rpmh_state state,\n {\n \tDEFINE_RPMH_MSG_ONSTACK(dev, state, rpm_msg);\n \tint ret;\n \n+\t// FIXME: can't seem to get multiple commands per message to work properly\n+\tif (n > 1) {\n+\t\tpr_err(\"%s: ERROR: RPMh writes with multiple commands don't work!\\n\", dev->name);\n+\t\treturn -EINVAL;\n+\t}\n+\n \tret = __fill_rpmh_msg(&rpm_msg, state, cmd, n, false);\n \tif (ret)\n \t\treturn ret;\n \n","prefixes":["2/3"]}