{"id":2222648,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222648/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260413092240.3719260-2-daniel@thingy.jp/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.1/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260413092240.3719260-2-daniel@thingy.jp>","date":"2026-04-13T09:22:35","name":"[v4,1/6] sysreset: qemu virt: Use __raw_writel()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"03d77042ecd6a309518600d5df879451ce44a2c1","submitter":{"id":85408,"url":"http://patchwork.ozlabs.org/api/1.1/people/85408/?format=json","name":"Daniel Palmer","email":"daniel@thingy.jp"},"delegate":{"id":14103,"url":"http://patchwork.ozlabs.org/api/1.1/users/14103/?format=json","username":"spectrum","first_name":"Angelo","last_name":"Dureghello","email":"sysamfw@gmail.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260413092240.3719260-2-daniel@thingy.jp/mbox/","series":[{"id":499674,"url":"http://patchwork.ozlabs.org/api/1.1/series/499674/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=499674","date":"2026-04-13T09:22:34","name":"Add virtio-mmio support to m68k virt machine","version":4,"mbox":"http://patchwork.ozlabs.org/series/499674/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222648/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222648/checks/","tags":{},"headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=thingy.jp header.i=@thingy.jp header.a=rsa-sha256\n header.s=google header.b=l4CCnCGB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=thingy.jp","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=thingy.jp header.i=@thingy.jp header.b=\"l4CCnCGB\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=thingy.jp","phobos.denx.de; spf=pass smtp.mailfrom=daniel@0x0f.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvMQW1CTgz1yDF\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 13 Apr 2026 19:23:15 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id C224F8352B;\n\tMon, 13 Apr 2026 11:23:05 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 84F448419E; Mon, 13 Apr 2026 11:23:05 +0200 (CEST)","from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com\n [IPv6:2607:f8b0:4864:20::1031])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 8AD3D840D8\n for <u-boot@lists.denx.de>; Mon, 13 Apr 2026 11:23:01 +0200 (CEST)","by mail-pj1-x1031.google.com with SMTP id\n 98e67ed59e1d1-35fb0bb27e7so620312a91.1\n for <u-boot@lists.denx.de>; Mon, 13 Apr 2026 02:23:01 -0700 (PDT)","from kinako ([2400:2200:776:9b18:a191:7a74:9fd8:591b])\n by smtp.googlemail.com with ESMTPSA id\n 98e67ed59e1d1-35fb617725esm1055930a91.1.2026.04.13.02.22.56\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 13 Apr 2026 02:22:59 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=no\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=thingy.jp; s=google; t=1776072180; x=1776676980; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=EMboHtuP3RpQNEBaDQiDt/x18qG4LDk3R7bkuXEHd3o=;\n b=l4CCnCGBVcwPS6P0R1B5lTVmn/89sxqB0ZjiHrUtOT/CiHGSjQaMO7Q3UnWBsxOkjo\n mXVmxaG/6qwwRAk+bM+9r7Wg+SPwJvWz46dgv88T4lVq/luEmbEZJjQHrzxfbpVZ0Lgp\n LwJy9fj2EGY96cPgslJpOxRQjD9SKDPzapKPM=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776072180; x=1776676980;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=EMboHtuP3RpQNEBaDQiDt/x18qG4LDk3R7bkuXEHd3o=;\n b=pbqyvyNhD2iqooJUiAfrXr1Z7XdUATQM71sVrIewomdXdIzE1VV1m5Ez0W6osNDCbK\n Ck2N7O0H/Mmru/05koBJtHaUJsbtTIWa3bifJEtxqYI1asiDSS3EHOKTnBnnU9og6WQj\n fDBvD4Mal2ZH6qi3akzRmhH+lrGHRPp1kxyrQqhsPjmaobym8mvQlkTKVVkLLmhwqrP5\n 3iy3chqLlLqZqvfA6LiirdY7EcZDFQPDOI+0EVZ9RFAri05zErTxbClfbGsbDA8xt1y2\n cr79FGYEhJf4IAVdFUr6G9kNFUXbHm2hrtmdW+UC2y38e5kGxSYGReP104SHuoYCWedR\n ECig==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9fhDZ8geK4wiaKUMoyip+SMBvWlRblMhwhKjR1gRmBLePxZYHu5d3Kqxet26qESAOrYKTbpaQ=@lists.denx.de","X-Gm-Message-State":"AOJu0YzainLfE15DgRbo+og5Azp+kHZOXAmg24/2xqhejJEq8dfRwpYT\n 3nKtYzBmShmqBcP2AHBUr8CR12AkLfFZiklaeQhtIExAHzJrLKaizP6ETi+AKqoU3A8=","X-Gm-Gg":"AeBDievt/szqoas54J/BQQ66QMc1HGvCFXC+RZ5sgV2bXiB0xmRdCXrIgfT90MU4/4C\n dSkUevo5zRCVN3v2FUAP5+XE+FjKFOr2hl9emE8L++vXRV/7ZlNm7qSyKC96FSVdZlkbjYoYORp\n slG7EiMZDUNoxb5jIbXFPRHJFCUPeJupKz0g1pXJam2k4dzgjIB4DR3QfYrppLfua4mtrCwECay\n O44WSaP8LgBDhJHjnqEzn3mF3Gd/VB+7Apgu/wtyQBgw6RWKh43rLVhlG3NCLaKE8tBMonYimeR\n G8SsEhL3OIQw/0T0v4T0HvbwVlL0wL8SX79HgYIT6lC19KgIAVjl+oGOXMmZcBZJ0GSZuDG+4Uc\n xt++ebWhAjj0Uj8Y2R8hcxHjiVcxN8zroWgEYJZTQK8Kfn7IqVvEvRqXc418EKlkQWA71xx/+YG\n SZzx6pYrq53tC2Pw==","X-Received":"by 2002:a17:90a:d40b:b0:35b:cd3e:c4ab with SMTP id\n 98e67ed59e1d1-35e42815adbmr13182520a91.14.1776072180057;\n Mon, 13 Apr 2026 02:23:00 -0700 (PDT)","From":"Daniel Palmer <daniel@thingy.jp>","To":"visitorckw@gmail.com,\n\tangelo@kernel-space.org,\n\tbmeng.cn@gmail.com","Cc":"sjg@chromium.org, u-boot@lists.denx.de, Daniel Palmer <daniel@thingy.jp>","Subject":"[PATCH v4 1/6] sysreset: qemu virt: Use __raw_writel()","Date":"Mon, 13 Apr 2026 18:22:35 +0900","Message-ID":"<20260413092240.3719260-2-daniel@thingy.jp>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20260413092240.3719260-1-daniel@thingy.jp>","References":"<20260413092240.3719260-1-daniel@thingy.jp>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"The virt ctrl register seems to be native endian, currently this driver\nuses writel(), which works by luck because its currently broken on m68k.\n\nUse __raw_writel() instead to avoid breaking this driver when the\nendianness of writel() is fixed.\n\nSigned-off-by: Daniel Palmer <daniel@thingy.jp>\nAcked-by: Kuan-Wei Chiu <visitorckw@gmail.com>\nReviewed-by: Angelo Dureghello <angelo@kernel-space.org>\nReviewed-by: Simon Glass <sjg@chromium.org>\n---\n drivers/sysreset/sysreset_qemu_virt_ctrl.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/drivers/sysreset/sysreset_qemu_virt_ctrl.c b/drivers/sysreset/sysreset_qemu_virt_ctrl.c\nindex e7cacc9b6e98..5ab16001922b 100644\n--- a/drivers/sysreset/sysreset_qemu_virt_ctrl.c\n+++ b/drivers/sysreset/sysreset_qemu_virt_ctrl.c\n@@ -38,7 +38,7 @@ static int qemu_virt_ctrl_request(struct udevice *dev, enum sysreset_t type)\n \t\treturn -EPROTONOSUPPORT;\n \t}\n \n-\twritel(val, plat->reg + VIRT_CTRL_REG_CMD);\n+\t__raw_writel(val, plat->reg + VIRT_CTRL_REG_CMD);\n \n \treturn -EINPROGRESS;\n }\n","prefixes":["v4","1/6"]}