{"id":2222560,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222560/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260412195947.1982729-7-ravi@prevas.dk/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.1/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260412195947.1982729-7-ravi@prevas.dk>","date":"2026-04-12T19:59:45","name":"[6/8] lib/hashtable.c: use memdup_nul() in himport_r","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"0369244c4d6eb3ae8bff69e562b46acf15ae4cce","submitter":{"id":89443,"url":"http://patchwork.ozlabs.org/api/1.1/people/89443/?format=json","name":"Rasmus Villemoes","email":"ravi@prevas.dk"},"delegate":{"id":3651,"url":"http://patchwork.ozlabs.org/api/1.1/users/3651/?format=json","username":"trini","first_name":"Tom","last_name":"Rini","email":"trini@ti.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260412195947.1982729-7-ravi@prevas.dk/mbox/","series":[{"id":499629,"url":"http://patchwork.ozlabs.org/api/1.1/series/499629/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=499629","date":"2026-04-12T19:59:41","name":"add memdup_nul(), use it and memdup() in a few places","version":1,"mbox":"http://patchwork.ozlabs.org/series/499629/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222560/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222560/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=prevas.dk header.i=@prevas.dk header.a=rsa-sha256\n header.s=selector1 header.b=SaEfmNI8;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=prevas.dk","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=prevas.dk header.i=@prevas.dk header.b=\"SaEfmNI8\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=prevas.dk","phobos.denx.de;\n spf=pass smtp.mailfrom=rasmus.villemoes@prevas.dk","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=prevas.dk;"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fv1cc4qdTz1yGg\n\tfor ; Mon, 13 Apr 2026 06:00:48 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 8E501839D5;\n\tSun, 12 Apr 2026 22:00:09 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 3157084119; Sun, 12 Apr 2026 22:00:07 +0200 (CEST)","from DB3PR0202CU003.outbound.protection.outlook.com\n (mail-northeuropeazlp170100001.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c200::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id C4B2C84198\n for ; Sun, 12 Apr 2026 22:00:02 +0200 (CEST)","from AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:681::18)\n by GV2PR10MB9930.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:150:341::22)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Sun, 12 Apr\n 2026 20:00:01 +0000","from AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM\n ([fe80::ebc6:4e0d:5d6b:95d8]) by AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM\n ([fe80::ebc6:4e0d:5d6b:95d8%5]) with mapi id 15.20.9769.046; Sun, 12 Apr 2026\n 20:00:01 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=ECMG4URG4XCK/6XCytngSHL3UpA4uDSn4PC1hAdP9depa2fiXBQhr6GRtBBmwtlrHsjvlGTK1EbFaGMxOPn6IYSDYFyutKRe6cY9NKTCEOJMvvKahHBay31RlXZw3vKwhTABSgsyNF4bE3T8R6Wtb9nRoPbxpb6EjPI1f8NBiv/ODUwttIjPVhivkkXPypJnYhbukhdQ8U7baqjkZnJg5NcfHGR02wGOWBBFxrPQMbAnIZon+T/rW3sgfEH4lmWWgYsoTamTJ9ZyT018r8c7wugU95Mj+lrJvJQ1uUvgX6oJFdiTB16ZSlyb0zf2Vs7802F3BUxUf5IaAgZfTNhM6A==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=+ToY/RaAjwtEJBhuqtdza2H3OOSxUl8+GTX2LF0BGtQ=;\n b=MurtHF4Fu7HdGVgY0Zq3wBRt2gPzMEiJ8etsEASBGoC0JD6z3OvrK1Nl5LI9nFfNcGfYOXI46pQmy4BrPTiSAVmDKllCxZAlQdTdAEYy5zNC0d/AM+8pOd/BObkpH0FdTjxo/IOktNfsZdq6p7Ci2gv6bVS90z1xYD/WoiFuDUcCyYAAdDF/1KAUETUvl3ZCSasa+RTlTtd1bwin+ZoyR5FBjRM2rVDDYwJqY3Dc5Z1N/KOTtnU9Xl1SxF28jr9JavTZN54/8WTjoZ6ZgvvPSDAsY0nMmqvH+waME++a7b/U2tOG/U6KSIusbjPpKewUlIe+0VfmMsgSg4qTEi85/w==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=prevas.dk; dmarc=pass action=none header.from=prevas.dk;\n dkim=pass header.d=prevas.dk; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=prevas.dk;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=+ToY/RaAjwtEJBhuqtdza2H3OOSxUl8+GTX2LF0BGtQ=;\n b=SaEfmNI8awcXhPxAI/wG4LbB744jHoMwLydvUcAKFpw9gUXMuM17R2iuPDNgtummP9xTZUHDc6bPCzdSmbTyXHtWNDKEAbMaIkgqGllFF/EsiP0KB3VIWMOEO/474pUUvSEFvpH5sy7VE3LPxLtot9L3v+zdRPKa6bfBKn/uYzE=","From":"Rasmus Villemoes ","To":"u-boot@lists.denx.de","Cc":"Tom Rini , Simon Glass ,\n Rasmus Villemoes ","Subject":"[PATCH 6/8] lib/hashtable.c: use memdup_nul() in himport_r","Date":"Sun, 12 Apr 2026 21:59:45 +0200","Message-ID":"<20260412195947.1982729-7-ravi@prevas.dk>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260412195947.1982729-1-ravi@prevas.dk>","References":"<20260412195947.1982729-1-ravi@prevas.dk>","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain","X-ClientProxiedBy":"CPAP307CA0005.DNKP307.PROD.OUTLOOK.COM\n (2603:10a6:380:3::13) To AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM\n (2603:10a6:20b:681::18)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"AS5PR10MB8243:EE_|GV2PR10MB9930:EE_","X-MS-Office365-Filtering-Correlation-Id":"2059ba55-b4c0-4e22-eef5-08de98ce14bf","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|52116014|376014|1800799024|366016|38350700014|18002099003|56012099003|22082099003;","X-Microsoft-Antispam-Message-Info":"\n ycLnAV6Q2DalEOq1pnlGC+Bv1mCE4dBzAP9cuCN/7+ihytGm0Ochsl4lhaelF3TE+MhK+97N3LDH4YySCdMQnPXE3+oAGvmUi7uDMytcGPHAigDogwJ1suL2FOMJyzJJUBXqj7PaBAe1WulyVsdzjIUUE+Uv7VaabvuMLMo2RMTDpiAFPrK+JMBtg9Yhj/oIajprsv1l54fLcLoLskmSWZYCJ+ckNhQqBI/dGA/JzVygf4AEqgY7BB2y0yuQ+mrUJrv3jurbD7StsLX99g7NcDMCuS2OeSH13CMrD3Z7yMQX3/5MyWWteQEhngoKrX1BRYLESmaOrSnOyj91IsQXfKwjzLJ3gqvxnt/fpGHxPxQT/4vU0hgBNq3WfvpgKq63TJxYSvMd3HPd/b5EkniCsk1Jiz0colU/TlZZHCXIn0TQiTB79kpkkvt0YysUbNVOGBxz5L+rrwCoTOKqHZ8Vp1yivfTpFuh6X3ljl3aPSffJ5w0UADsRoHjzWsDgvwBwr5jtjLEp/UDbrHXnpqyYqAPVmdOE0p14nBvHdBcIW7/P9wCxlcMAzFX6FDoBPcWuCtVfa2lTqDAl/LVe+dzU3Nj6bYQyMjusWjN11ldc9N1Pdcq/Pn+EP+E/mSiQYCFxdoqmj7dlQzVwyiVJhHZuHwAZHF+iaUuUFrZNzBpUj2ErxPVeBlWhVc8kf59Lyxh1GecsL4whDgcnv/LLC+zqqkKfczoZAHjCkwyxeDpo2DX8E10ASHdVlCwoHR6+jVkQ8INnqg6Ak2jQix8Iw7CwQ0s8z2n4cKWTutrL1vCqkSc=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE;\n SFS:(13230040)(52116014)(376014)(1800799024)(366016)(38350700014)(18002099003)(56012099003)(22082099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n vWYLO68IXlCfFwxLQ0j+Uc5Dlf/aqrQ/Xowo8vvzEvRRH+u91uT/j5XYMIG0etvjbLzsAZt11vAAil2rf1T2+/X4i2OmXStS5Y/AFPtW3JXNQfv3i/TdDbOsZE+AMfQpfvsUWxtBp/q+zY3JYR3np/YbuGP7MYIAbKL/Bv3tdtS4Lp6Xynnuqxel8omN40Yr9PEYQ72Gj6tn//B3tiphbrv0feEAirgpUa+g716yb0ve6NmRHfokpou33kVujEiTLjBEbxpSIEaTv9AvOF5nSgkq1n7Q0qQYiFevFlN6xHyX9Q4QqpEfY2KGoNK1TN0h1sCen3VGBuAHYHO0NJObhUI5H+zcZ3gj2EE9Cai/Ub816ciAnrIK6bGTH6IIGQJDpGTTQemUcFGyqGpWkFmnyKJnawM8P8gK6KdZ1SG3zTB/9Una1kP5M215H+xIC3GrSzjBpQxQmwzYGCNN64/bdOStd0sPXvYRp6FljqsHEukVsD0nDBnF4uEcoZFLIKndG81/te8Sg2I+9+mtJeQDMZVAWbEZoRCzJY4np1Y9RLA3uJSUTToVHKtwK84wZfTSxkqcxu8ZKkKATWIx55XBPL295BU1Niuxw/BgWBvD5WLgSDEDf/GUltk8WgflBhk/Ut9zZsoM0aefwREGnnddmaGOiyp4qBb80Z1nkDAnnw+KYBny/hpFpqmBaRmitm41qEWBqr5VDTC8Idrvrs6775CgG+WW84gncn4sKY1it8oMArw8EFvLXbhFGflD8OcTMLZhtGoTRgV2oXG1CrXONs36AhyFn0ffScsOJErcC8hSHCB81asjupqYCGce7A800hpnwkNCek3TSoG9nNE+NOzWOyzw0eJKNMFEGG+bpQ1tZ2dtFUjxibF3Oh7bN5i0v81bean5DewzVU6K1vZMUOv9ej3HPBamOFpTok5l8NoKqa7oTgvp0iy2LA8kzQaxp8S5AV9yWqx8hyZ6zzz+hQtrZ7nIbpF8aAq2T3hfiaZoikryu+DROOIQHCVppzDFDra5rS683J6RcBx74YZvcIScqq78lr55kYfnBMsFzQPDDmiKEmL32kYd7Tr6193ZTR0R65a3tKsBCWFDHVHshVn2Vf/yxivf51HtpQcPsHHs3S7itSHOSCqM353N+iR/rBu4C8F4jsrw9fdPaHaZZ7HnzqPk2KI+4C0hHo7N5BY0SgUHw5girRob1T45izbWw1qdp0c4P0bcTBcNy4R0JDzQy6dH5iI/weDI1tkTufIUGEf0cJqNx5BGh+RnWu7rGdKbJDj67h0VSRvTRm0gnCjY+dJFa6EUtw4PHNDw6p/m1C1vdSDOgTw7uZ7W9l99kSiAT7eWIhUnoH3i1VvSp7iBC3n7BIB3UuWbhPtN4x5IDJyqEGufJVyIW96arz0NEyvQwjngvQlgmed6EdyO5nVHQPT0XIubR10cyb/B+CijrrLBj9wSBp5xhNeXpkfbRd5eREMJ58ZeENYJsSJdDVsJYY8pUuA2Ri0QSIaWC6PYWnkboNu5qUf3ZifpPHsqPqps1lzaAfz/0DPIrcawlVqtwLLGyCtgiPGoAri2Rn9P0RbSD1h17QgEAIbdMWk0VEu5KyP+l4Ewr0xWsbAKP8vZyW7CldjVN1rAT3HMNOBT6wjB0TNyQxss15lILwWyGQwPJearrOd4gzHxhPRZ9U0LzI76i6YOhLunUFw9GVi+YpakemFBbTbrGecd6LioRxkNK3ULpK6G4ReUhqhqpNexBCdkAnGvIiIcNbSl9bc=","X-OriginatorOrg":"prevas.dk","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 2059ba55-b4c0-4e22-eef5-08de98ce14bf","X-MS-Exchange-CrossTenant-AuthSource":"AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"12 Apr 2026 20:00:01.2603 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"d350cf71-778d-4780-88f5-071a4cb1ed61","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n 5r1R9qQkBHWuK61LM1220qrwdDOO03gyXW9xMxkCALM3V7Pwk7dOmKolPlF9Aho+Xa8VzVhZD1m34GWWr/eMBqbGFEXE9F+h3jTN/qDRRcU=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"GV2PR10MB9930","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"We have memdup_nul() for exactly this pattern of duplicating a block\nof memory and ensuring there's a nul byte after the copy.\n\nSigned-off-by: Rasmus Villemoes \n---\n lib/hashtable.c | 7 +++----\n 1 file changed, 3 insertions(+), 4 deletions(-)","diff":"diff --git a/lib/hashtable.c b/lib/hashtable.c\nindex 75c263b5053..f96a8e686f6 100644\n--- a/lib/hashtable.c\n+++ b/lib/hashtable.c\n@@ -821,13 +821,12 @@ int himport_r(struct hsearch_data *htab,\n \t}\n \n \t/* we allocate new space to make sure we can write to the array */\n-\tif ((data = malloc(size + 1)) == NULL) {\n-\t\tdebug(\"himport_r: can't malloc %lu bytes\\n\", (ulong)size + 1);\n+\tdata = memdup_nul(env, size);\n+\tif (data == NULL) {\n+\t\tdebug(\"himport_r: can't duplicate env block\\n\");\n \t\t__set_errno(ENOMEM);\n \t\treturn 0;\n \t}\n-\tmemcpy(data, env, size);\n-\tdata[size] = '\\0';\n \tdp = data;\n \n \t/* make a local copy of the list of variables */\n","prefixes":["6/8"]}