{"id":2222485,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222485/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260412110240.93116-3-yangyanglan718@gmail.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260412110240.93116-3-yangyanglan718@gmail.com>","date":"2026-04-12T11:02:40","name":"[v3,2/2] hw/arm/fsl-imx6ul: Wire in the LCDIF device model","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9a220c47b048029d0d52779796fd8f912f399ed4","submitter":{"id":92856,"url":"http://patchwork.ozlabs.org/api/1.1/people/92856/?format=json","name":"Yucai Liu","email":"yangyanglan718@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260412110240.93116-3-yangyanglan718@gmail.com/mbox/","series":[{"id":499594,"url":"http://patchwork.ozlabs.org/api/1.1/series/499594/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499594","date":"2026-04-12T11:02:39","name":"i.MX6UL LCDIF device model and SoC wiring","version":3,"mbox":"http://patchwork.ozlabs.org/series/499594/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222485/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222485/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=fMxopNM4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftnjC4cq5z1yGj\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 12 Apr 2026 21:03:58 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wBsaj-00082r-OX; Sun, 12 Apr 2026 07:03:01 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <yangyanglan718@gmail.com>)\n id 1wBsaf-00081d-23\n for qemu-devel@nongnu.org; Sun, 12 Apr 2026 07:03:00 -0400","from mail-pf1-x430.google.com ([2607:f8b0:4864:20::430])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <yangyanglan718@gmail.com>)\n id 1wBsab-0005i8-E7\n for qemu-devel@nongnu.org; Sun, 12 Apr 2026 07:02:56 -0400","by mail-pf1-x430.google.com with SMTP id\n d2e1a72fcca58-82f07e5ad92so1590254b3a.0\n for <qemu-devel@nongnu.org>; Sun, 12 Apr 2026 04:02:52 -0700 (PDT)","from archlinux ([58.38.119.35]) by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82f0c20aed6sm7996263b3a.0.2026.04.12.04.02.48\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 12 Apr 2026 04:02:51 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775991772; x=1776596572; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=4j53ezDZT7BYP6kTXkpRzKUmnkIoXcUGSbPBONRCBDY=;\n b=fMxopNM4GuvszMDajmHeNheCQuRK63cc5ibSS0GQd5cAbzzHSWDcMil16TiEEO3wfO\n 2mhmvXIU9zdcX1LfWubtF8k9Aox4l1Roaf/VcAOgvqTn5bR90mPfN1Q57BSOnaw2rYrK\n bIEnYEGgL5VHQoTakuuhnQlTcMj+48yfFI5oiBFEwum6wIyCdxkdAZRu+qilc+aoR9HA\n /nwWGki9LaW/kzMYlk+AxLAF+TIFNj2HsbylHljOj7/v+8Vxe70NoQA8+c+c8qUE73lM\n vJhivTObu2KQIKXczd5E8UT+TOOFD8cQiOVPZwKnDOYOu3CUUozB1Ed/6WqeTnyf6fuK\n E5DA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775991772; x=1776596572;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=4j53ezDZT7BYP6kTXkpRzKUmnkIoXcUGSbPBONRCBDY=;\n b=d55d3cldEMXJFnB/CVWdnwfAJIwL7YHOYVlwB07MXYuooadzCqS6OxKaxVKLOYueoP\n A9B+TEM3bqYOXPGF4sQ0sFXinqvW1lIWG4l/NmW80JScx7QdB1dauUVj85NmC1sJ+63P\n JHQsZqfPstrLAHxyhC4NYEjQip/8r3PCmcGfU+DVsVtIIY1pC46dqg0ceaX7UmAQ4zK0\n 4RPk8vTxgnTzH/tgZAqEPI4UZBuaz6opgwY7dqg0KjFnAF4gEmahyGbMHtfa6pj1F7nV\n iQxPnHuqQzi7QxNZoO4El5tZBEdILRC2Svm6dwZe0MN1uvUkhWOoBLjeQBPBhPcRozil\n hKtQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8Ru3Z2mLU1yq0MNaFuz6cax1xJ9hmCoKD2uRk6aUSDNW0RwGkxu6+hZGUw8PNrFzRV/jOmPdCZrNW2@nongnu.org","X-Gm-Message-State":"AOJu0YztsKhQnMhq1rYuR+bOmJrI4C/3DJW9yG5qhBzkSrgpwW1GvlvH\n 0ohYCk8IoB2QvBMpME+Jj7eNBm2judMEQhCDrZhvy1ZeZ1eSCiG/2NB6","X-Gm-Gg":"AeBDiesodp1JZjZk0idRWf2oO7QBXXo4tr0dQYp7NmOOXZK/NrGQyN2Aw65HggqVMde\n B2maDlsuSHwmafJYRYO17BPXwLvNszVy8Lbkqh++VnRPKut/m+1SX7EeKdK3tlt7rdDkhRJhxmG\n 7nld9YFvqSM6Cyth1q7uKADgiUihvRiQPmbxp1+gvs+IOsqyigymyMypbyfr9rheWYSDgQ6U8+m\n nksW8PTRNrK5pOhrrfrF0+AaD+1shhajqqRuMWA9bFurnCxOuFidQRxI94zu+foJ78qfdLHh9BL\n 0Pz3vqX0cBF/qfmJe7DfwgJOB/pvxG69de8WJoD8G4NwK5sqa2Qam9HBN7Ul4V4uAGVXEBp+o2x\n ZlJb0Shsx0sHeywrDV9vk2e5RqvdL63KFRhay9keACcVVJL9X29AEq0Kz+V+Yo0u2I3m+EQMOaU\n 5DGrdbYIb1jExLO8PgOgtB9LJ9","X-Received":"by 2002:a05:6a00:3924:b0:82c:77cd:50e8 with SMTP id\n d2e1a72fcca58-82f0c30f593mr9553975b3a.27.1775991771693;\n Sun, 12 Apr 2026 04:02:51 -0700 (PDT)","From":"Yucai Liu <yangyanglan718@gmail.com>","To":"pbonzini@redhat.com,\n\tpeter.maydell@linaro.org","Cc":"jcd@tribudubois.net,\n\tqemu-devel@nongnu.org,\n\tqemu-arm@nongnu.org","Subject":"[PATCH v3 2/2] hw/arm/fsl-imx6ul: Wire in the LCDIF device model","Date":"Sun, 12 Apr 2026 19:02:40 +0800","Message-ID":"<20260412110240.93116-3-yangyanglan718@gmail.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260412110240.93116-1-yangyanglan718@gmail.com>","References":"<20260412110240.93116-1-yangyanglan718@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::430;\n envelope-from=yangyanglan718@gmail.com; helo=mail-pf1-x430.google.com","X-Spam_score_int":"-17","X-Spam_score":"-1.8","X-Spam_bar":"-","X-Spam_report":"(-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Yucai Liu <1486344514@qq.com>\n\nInstantiate LCDIF as a child object of the i.MX6UL SoC in init and\nrealize it in the SoC realize path before MMIO/IRQ hookup.\n\nAlso make FSL_IMX6UL select CONFIG_IMX6UL_LCDIF and map the LCDIF\nregion with a 16 KiB size to match the SoC memory map.\n\nSigned-off-by: Yucai Liu <1486344514@qq.com>\n---\n hw/arm/Kconfig              |  1 +\n hw/arm/fsl-imx6ul.c         | 12 ++++++++++--\n include/hw/arm/fsl-imx6ul.h |  4 +++-\n 3 files changed, 14 insertions(+), 3 deletions(-)","diff":"diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig\nindex c66c452737..6655f6c34e 100644\n--- a/hw/arm/Kconfig\n+++ b/hw/arm/Kconfig\n@@ -641,6 +641,7 @@ config FSL_IMX6UL\n     imply I2C_DEVICES\n     select A15MPCORE\n     select IMX\n+    select IMX6UL_LCDIF\n     select IMX_FEC\n     select IMX_I2C\n     select IMX_USBPHY\ndiff --git a/hw/arm/fsl-imx6ul.c b/hw/arm/fsl-imx6ul.c\nindex 225e179126..1863558a0d 100644\n--- a/hw/arm/fsl-imx6ul.c\n+++ b/hw/arm/fsl-imx6ul.c\n@@ -19,6 +19,7 @@\n #include \"qemu/osdep.h\"\n #include \"qapi/error.h\"\n #include \"hw/arm/fsl-imx6ul.h\"\n+#include \"hw/display/imx6ul_lcdif.h\"\n #include \"hw/misc/unimp.h\"\n #include \"hw/usb/imx-usb-phy.h\"\n #include \"hw/core/boards.h\"\n@@ -136,6 +137,11 @@ static void fsl_imx6ul_init(Object *obj)\n         object_initialize_child(obj, name, &s->usb[i], TYPE_CHIPIDEA);\n     }\n \n+    /*\n+     * LCDIF\n+     */\n+    object_initialize_child(obj, \"lcdif\", &s->lcdif, TYPE_IMX6UL_LCDIF);\n+\n     /*\n      * SDHCIs\n      */\n@@ -656,8 +662,10 @@ static void fsl_imx6ul_realize(DeviceState *dev, Error **errp)\n     /*\n      * LCD\n      */\n-    create_unimplemented_device(\"lcdif\", FSL_IMX6UL_LCDIF_ADDR,\n-                                FSL_IMX6UL_LCDIF_SIZE);\n+    sysbus_realize(SYS_BUS_DEVICE(&s->lcdif), &error_abort);\n+    sysbus_mmio_map(SYS_BUS_DEVICE(&s->lcdif), 0, FSL_IMX6UL_LCDIF_ADDR);\n+    sysbus_connect_irq(SYS_BUS_DEVICE(&s->lcdif), 0,\n+                       qdev_get_gpio_in(gic, FSL_IMX6UL_LCDIF_IRQ));\n \n     /*\n      * CSU\ndiff --git a/include/hw/arm/fsl-imx6ul.h b/include/hw/arm/fsl-imx6ul.h\nindex 4e3209b25b..733553883f 100644\n--- a/include/hw/arm/fsl-imx6ul.h\n+++ b/include/hw/arm/fsl-imx6ul.h\n@@ -33,6 +33,7 @@\n #include \"hw/net/imx_fec.h\"\n #include \"hw/usb/chipidea.h\"\n #include \"hw/usb/imx-usb-phy.h\"\n+#include \"hw/display/imx6ul_lcdif.h\"\n #include \"system/memory.h\"\n #include \"cpu.h\"\n #include \"qom/object.h\"\n@@ -84,6 +85,7 @@ struct FslIMX6ULState {\n     IMX2WdtState       wdt[FSL_IMX6UL_NUM_WDTS];\n     IMXUSBPHYState     usbphy[FSL_IMX6UL_NUM_USB_PHYS];\n     ChipideaState      usb[FSL_IMX6UL_NUM_USBS];\n+    IMX6ULLCDIFState   lcdif;\n     MemoryRegion       rom;\n     MemoryRegion       caam;\n     MemoryRegion       ocram;\n@@ -143,7 +145,7 @@ enum FslIMX6ULMemoryMap {\n     FSL_IMX6UL_PXP_SIZE             = (16 * KiB),\n \n     FSL_IMX6UL_LCDIF_ADDR           = 0x021C8000,\n-    FSL_IMX6UL_LCDIF_SIZE           = 0x100,\n+    FSL_IMX6UL_LCDIF_SIZE           = (16 * KiB),\n \n     FSL_IMX6UL_CSI_ADDR             = 0x021C4000,\n     FSL_IMX6UL_CSI_SIZE             = 0x100,\n","prefixes":["v3","2/2"]}