{"id":2222411,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222411/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260411131806.94653-1-mohamed@unpredictable.fr/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260411131806.94653-1-mohamed@unpredictable.fr>","date":"2026-04-11T13:18:06","name":"hw/intc: apic: stop register accesses for invalid situations","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"6585ef04a1f1285be77ac67d756710ee109417b2","submitter":{"id":91318,"url":"http://patchwork.ozlabs.org/api/1.1/people/91318/?format=json","name":"Mohamed Mediouni","email":"mohamed@unpredictable.fr"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260411131806.94653-1-mohamed@unpredictable.fr/mbox/","series":[{"id":499556,"url":"http://patchwork.ozlabs.org/api/1.1/series/499556/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499556","date":"2026-04-11T13:18:06","name":"hw/intc: apic: stop register accesses for invalid situations","version":1,"mbox":"http://patchwork.ozlabs.org/series/499556/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222411/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222411/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=unpredictable.fr header.i=@unpredictable.fr\n header.a=rsa-sha256 header.s=sig1 header.b=bvf2a8I4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftDld4Btcz1yCx\n\tfor ; Sat, 11 Apr 2026 23:19:08 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBYEG-0007V1-N0; Sat, 11 Apr 2026 09:18:28 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBYE9-0007Sh-29\n for qemu-devel@nongnu.org; Sat, 11 Apr 2026 09:18:22 -0400","from p-west3-cluster3-host9-snip4-8.eps.apple.com ([57.103.72.239]\n helo=outbound.ms.icloud.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBYE6-0005qU-2G\n for qemu-devel@nongnu.org; Sat, 11 Apr 2026 09:18:20 -0400","from outbound.ms.icloud.com (unknown [127.0.0.2])\n by p00-icloudmta-asmtp-us-west-3a-100-percent-8 (Postfix) with ESMTPS id\n A93DE18002A3; Sat, 11 Apr 2026 13:18:11 +0000 (UTC)","from localhost.localdomain (unknown [17.57.154.37])\n by p00-icloudmta-asmtp-us-west-3a-100-percent-8 (Postfix) with ESMTPSA id\n C991F18000D0; Sat, 11 Apr 2026 13:18:09 +0000 (UTC)"],"Dkim-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr;\n s=sig1; t=1775913493; x=1778505493;\n bh=lF0jdyfsX2D7PN9TMkL5HOWX7JJ7u8+26yUNFPoFu10=;\n h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme;\n b=bvf2a8I4RiHONEStDVJCoqvu+3ACapA8894YJW/R74tMZHFpA/UZ9Xj77lFPgpGZfqxSlQOvCRSNPsomN5/+aJZymtfAv+Hx6iv2QrnOJ3UXDKzqcJwRmqJ5+B3WQVygpfRRlzPuQJQx2flusRSTwZDSzVsDNxNCaEj13vGIwfGkv5rQ8bkbtAy4pT5SovKBa5Uz+RBGwr0DqbSENvefYFhZ7QWGpWumULIBvJ4rwDKwzRr5uOTO518Np/RItkeNdrcB0DRSZepwG+Ah1fL5gPXOigYJ3oetAOYM2pM0ekwfLNqjON4uJZ6OfJPe8/ijBLVNse5mixydfZeRNEoRgg==","mail-alias-created-date":"1752046281608","From":"Mohamed Mediouni ","To":"qemu-devel@nongnu.org","Cc":"Paolo Bonzini ,\n \"Michael S. Tsirkin\" ,\n Mohamed Mediouni ","Subject":"[PATCH] hw/intc: apic: stop register accesses for invalid situations","Date":"Sat, 11 Apr 2026 15:18:06 +0200","Message-ID":"<20260411131806.94653-1-mohamed@unpredictable.fr>","X-Mailer":"git-send-email 2.50.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDExMDExMyBTYWx0ZWRfX6KuJnfN+jstx\n 6j+i1jvrST3m/ebDjNlLd3H5cNhqGcT4WVN8/SPkO4uwquQi6zi4ALnQZckV2g6p7WDvWn3/GBj\n 3y4aGuxYsMsQ5k/6BmhNocJkianZiGqqZa1m0zhMkq/fXi/f5YW4LmMJ1MTCP00rjNL4T4IZkOu\n OuScpcYR17UvWoQsGPvzE/oV4ejyfrmwz6UnMj6wDoJqBMU+OM28uPxtdv9eIvwViWeTdn+ukN0\n BVXj9/cE8E9jDrTiotau+zGrpMr54csY2DL/2OiCJLOZo+aV3lkmUFFivYfuYRzIPRpyLBHrL4Y\n qCfKX4KheKLgym4XAIsip9bgUSFmHTomMjECbWMbFwkl9Dvhuu8oO16EXqrw4o=","X-Proofpoint-GUID":"gokvfFS0J8BPtV1u1cNTx0UxKfmIr46a","X-Proofpoint-ORIG-GUID":"gokvfFS0J8BPtV1u1cNTx0UxKfmIr46a","X-Authority-Info-Out":"v=2.4 cv=F9lat6hN c=1 sm=1 tr=0 ts=69da4a14\n cx=c_apl:c_pps:t_out a=qkKslKyYc0ctBTeLUVfTFg==:117 a=A5OVakUREuEA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=zBtDF0ibdIbUSHW8crcA:9","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-11_03,2026-04-09_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=notspam policy=default score=0 spamscore=0\n phishscore=0 mlxscore=0 clxscore=1030 suspectscore=0 lowpriorityscore=0\n malwarescore=0 bulkscore=0 mlxlogscore=821 adultscore=0 classifier=spam\n authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2604110113","Received-SPF":"pass client-ip=57.103.72.239;\n envelope-from=mohamed@unpredictable.fr; helo=outbound.ms.icloud.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"kvm-unit-tests's apic.c tests for:\n\n!APICBASE_ENABLE + attempting to read xAPIC registers is not an allowed\n combination.\n\nAnd neither is x2APIC enabled + attempting to read xAPIC registers\n\nThis was tested on WHPX with kernel-irqchip=off with x2APIC emulation\nenabled (in a posted series) and TCG.\n\nSigned-off-by: Mohamed Mediouni \n---\n hw/intc/apic.c | 9 +++++++++\n 1 file changed, 9 insertions(+)","diff":"diff --git a/hw/intc/apic.c b/hw/intc/apic.c\nindex 8766ed00b9..c09dddef39 100644\n--- a/hw/intc/apic.c\n+++ b/hw/intc/apic.c\n@@ -875,6 +875,15 @@ static uint64_t apic_mem_read(void *opaque, hwaddr addr, unsigned size)\n return -1;\n }\n \n+ /* if the xAPIC is disabled, return early. */\n+ if (!(s->apicbase & MSR_IA32_APICBASE_ENABLE)) {\n+ return 0xffffffff;\n+ }\n+\n+ if (s->apicbase & MSR_IA32_APICBASE_EXTD) {\n+ return 0xffffffff;\n+ }\n+\n index = (addr >> 4) & 0xff;\n apic_register_read(s, index, &val);\n \n","prefixes":[]}