{"id":2222385,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222385/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260411115908.1554282-1-fw@strlen.de/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/1.1/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260411115908.1554282-1-fw@strlen.de>","date":"2026-04-11T11:59:02","name":"[nf] netfilter: nft_set_rbtree: fix memory leak during insertion","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"f2e83e6383afc9bd407f0a2efdbea46c32e58d5f","submitter":{"id":1025,"url":"http://patchwork.ozlabs.org/api/1.1/people/1025/?format=json","name":"Florian Westphal","email":"fw@strlen.de"},"delegate":{"id":11902,"url":"http://patchwork.ozlabs.org/api/1.1/users/11902/?format=json","username":"strlen","first_name":"Florian","last_name":"Westphal","email":"fw@strlen.de"},"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260411115908.1554282-1-fw@strlen.de/mbox/","series":[{"id":499551,"url":"http://patchwork.ozlabs.org/api/1.1/series/499551/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=499551","date":"2026-04-11T11:59:02","name":"[nf] netfilter: nft_set_rbtree: fix memory leak during insertion","version":1,"mbox":"http://patchwork.ozlabs.org/series/499551/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222385/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222385/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11820-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=91.216.245.30","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=strlen.de","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=Chamillionaire.breakpoint.cc"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftBzl13dfz1y2d\n\tfor ; Sat, 11 Apr 2026 21:59:31 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id ED14230254FE\n\tfor ; Sat, 11 Apr 2026 11:59:27 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 047D23469F6;\n\tSat, 11 Apr 2026 11:59:27 +0000 (UTC)","from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc\n [91.216.245.30])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id EE4501FC8\n\tfor ; Sat, 11 Apr 2026 11:59:24 +0000 (UTC)","by Chamillionaire.breakpoint.cc (Postfix, from userid 1003)\n\tid 2D28B60491; Sat, 11 Apr 2026 13:59:17 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775908766; cv=none;\n b=qMIRK/wj++MFzfEDZHj0D/7GR5yvmhjI5ABu9qeVLn3mrQkln4ln4B+3Qv+DzOMseNKn47OuFXAt0e9JBfp4lsOZ/T00HHgc8YE1+pVDFhr4ksZPNN7T+XOyhdL52ch1XFbgaG3IdrwuCElArVjrFZrrVFnWusTvGHnvaDED/lA=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775908766; c=relaxed/simple;\n\tbh=Nc8a8KMu6UoVIaFgj/MdWkd+2jVQcXiKYnQvHoMNxI0=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=g/8IgFKvw241JjRlpiQoUhEff8hKunn00AWBZa4ujnaDC2nGve4RTDakVZFtb+y3pEESl4Cp0SKreqc2CpFkM+WE/g0+GzaOY5GvkcOgHERy/x9BeFBve8JSyYHZBXPVBZLgrsDF0h5FN4NSnY2UKRxzlW1TT5Ft3pv4uZ8Jvqk=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=strlen.de;\n spf=pass smtp.mailfrom=Chamillionaire.breakpoint.cc;\n arc=none smtp.client-ip=91.216.245.30","From":"Florian Westphal ","To":"","Cc":"Florian Westphal ,\n\tDan Carpenter ","Subject":"[PATCH nf] netfilter: nft_set_rbtree: fix memory leak during\n insertion","Date":"Sat, 11 Apr 2026 13:59:02 +0200","Message-ID":"<20260411115908.1554282-1-fw@strlen.de>","X-Mailer":"git-send-email 2.53.0","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"net/netfilter/nft_set_rbtree.c:399 __nft_rbtree_insert()\n warn: 'removed_end' is not an error pointer\n\nDelete this incorrect test, we only want to know if the current element\nwas reaped.\n\nThis causes early \"return-0\", signalling a successful insertion of the\nelement, but no insertion was done.\n\nFixes: 087388278e0f (\"netfilter: nf_tables: nft_set_rbtree: fix spurious\n\t\tinsertion failure\")\nReported-by: Dan Carpenter \nCloses: https://lore.kernel.org/netfilter-devel/adjSaolTji0mPgqx@stanley.mountain/\nSigned-off-by: Florian Westphal \n---\n net/netfilter/nft_set_rbtree.c | 3 ---\n 1 file changed, 3 deletions(-)","diff":"diff --git a/net/netfilter/nft_set_rbtree.c b/net/netfilter/nft_set_rbtree.c\nindex 737c339decd0..3407109d6a5c 100644\n--- a/net/netfilter/nft_set_rbtree.c\n+++ b/net/netfilter/nft_set_rbtree.c\n@@ -396,9 +396,6 @@ static int __nft_rbtree_insert(const struct net *net, const struct nft_set *set,\n \t\t\tconst struct nft_rbtree_elem *removed_end;\n \n \t\t\tremoved_end = nft_rbtree_gc_elem(set, priv, rbe);\n-\t\t\tif (IS_ERR(removed_end))\n-\t\t\t\treturn PTR_ERR(removed_end);\n-\n \t\t\tif (removed_end == rbe_le || removed_end == rbe_ge)\n \t\t\t\treturn -EAGAIN;\n \n","prefixes":["nf"]}