{"id":2222372,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222372/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260411085643.3221565-4-dhowells@redhat.com/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.1/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260411085643.3221565-4-dhowells@redhat.com>","date":"2026-04-11T08:56:41","name":"[3/4] cachefiles: fix incorrect dentry refcount in cachefiles_cull()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a9feb1cfa33f8b1ce9365beb33fbdf36e8b0bb03","submitter":{"id":59,"url":"http://patchwork.ozlabs.org/api/1.1/people/59/?format=json","name":"David Howells","email":"dhowells@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260411085643.3221565-4-dhowells@redhat.com/mbox/","series":[{"id":499541,"url":"http://patchwork.ozlabs.org/api/1.1/series/499541/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=499541","date":"2026-04-11T08:56:38","name":"netfs: Miscellaneous fixes","version":1,"mbox":"http://patchwork.ozlabs.org/series/499541/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222372/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222372/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=ZsfbugLy;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10762-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=\"ZsfbugLy\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=170.10.129.124","smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=redhat.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ft70M4w87z1y2d\n\tfor ; Sat, 11 Apr 2026 18:59:47 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id E1842306F5C2\n\tfor ; Sat, 11 Apr 2026 08:57:17 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 7FA83336885;\n\tSat, 11 Apr 2026 08:57:17 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 181762C15A5\n\tfor ; Sat, 11 Apr 2026 08:57:15 +0000 (UTC)","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-465-lpn6ZtJpNsCHJ9bBcnhvXg-1; Sat,\n 11 Apr 2026 04:57:10 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id B0C901956061;\n\tSat, 11 Apr 2026 08:57:08 +0000 (UTC)","from warthog.procyon.org.com (unknown [10.44.48.47])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 8B19219560AB;\n\tSat, 11 Apr 2026 08:57:04 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775897837; cv=none;\n b=rbjP90rX4KpDjrKWSEp1O0M3VwsRI9i2/WX7WLaFVEE0JMMIfsUQGXhj97KhpxhRe1KdpSNkLNgE8S5JzChLYe2Vdr7yPo8DJeorDUOaqo1wOWKLw7LMs0IcN7ySY8+xZTGxyVxHJbxZXVYDh0n0OFYaGYFl8WkXmUAcSEB3rz0=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775897837; c=relaxed/simple;\n\tbh=Va5ic3j+XPVGHImNKjNKAB4SnRGmH/mONtJLhCgEHPk=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=nN7XfnJagYWDdbfFINWknK2z/vUuJ5h9yGL8GO843zh2Q9Wb7TYla6MZA0BP0SUNgcCcfAooC3+abmkr5UKOJ1bCBKWYCNwR2bnBd873khkIj93Yt3ErBh1hNkjP79yPrUx/u+zU9RlSixbHRVoODWrypxS7GisrwqskQIuJvBs=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com;\n spf=pass smtp.mailfrom=redhat.com;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=ZsfbugLy; arc=none smtp.client-ip=170.10.129.124","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1775897835;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=wyv45w2ugH74c2VSCb7J4MMwtcNcSvmG464mF8qh4Dc=;\n\tb=ZsfbugLy1cSn10dwtp48S1Z9ZoLLJcfY9gEQSWqEql+fPURf6cwU8B+mQMi2blt1lmLVXW\n\tYoH/a/p0b4PP0J9Ko5UdIFCyNZFRN7TZRrlsBB0eDTV1pBMaXJum/G680OtBO5fiSfDqe6\n\t2lbhMzWdIDIU6gkO618nTAE2yaHkc5A=","X-MC-Unique":"lpn6ZtJpNsCHJ9bBcnhvXg-1","X-Mimecast-MFC-AGG-ID":"lpn6ZtJpNsCHJ9bBcnhvXg_1775897829","From":"David Howells ","To":"Christian Brauner ","Cc":"David Howells ,\n\tPaulo Alcantara ,\n\tnetfs@lists.linux.dev,\n\tlinux-afs@lists.infradead.org,\n\tlinux-cifs@vger.kernel.org,\n\tceph-devel@vger.kernel.org,\n\tlinux-fsdevel@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tNeilBrown ,\n\tMarc Dionne ,\n\tNeilBrown ,\n\t\"Paulo Alcantara (Red Hat)\" ","Subject":"[PATCH 3/4] cachefiles: fix incorrect dentry refcount in\n cachefiles_cull()","Date":"Sat, 11 Apr 2026 09:56:41 +0100","Message-ID":"<20260411085643.3221565-4-dhowells@redhat.com>","In-Reply-To":"<20260411085643.3221565-1-dhowells@redhat.com>","References":"<20260411085643.3221565-1-dhowells@redhat.com>","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12"},"content":"From: NeilBrown \n\nThe patch mentioned below changed cachefiles_bury_object() to expect 2\nreferences to the 'rep' dentry. Three of the callers were changed to\nuse start_removing_dentry() which takes an extra reference so in those\ncases the call gets the expected references.\n\nHowever there is another call to cachefiles_bury_object() in\ncachefiles_cull() which did not need to be changed to use\nstart_removing_dentry() and so was not properly considered.\nIt still passed the dentry with just one reference so the net result is\nthat a reference is lost.\n\nTo meet the expectations of cachefiles_bury_object(), cachefiles_cull()\nmust take an extra reference before the call. It will be dropped by\ncachefiles_bury_object().\n\nReported-by: Marc Dionne \nFixes: 7bb1eb45e43c (\"VFS: introduce start_removing_dentry()\")\nSigned-off-by: NeilBrown \nSigned-off-by: David Howells \nAcked-by: Paulo Alcantara (Red Hat) \ncc: netfs@lists.linux.dev\ncc: linux-afs@lists.infradead.org\ncc: linux-fsdevel@vger.kernel.org\n---\n fs/cachefiles/namei.c | 5 +++++\n 1 file changed, 5 insertions(+)","diff":"diff --git a/fs/cachefiles/namei.c b/fs/cachefiles/namei.c\nindex e5ec90dccc27..eb9eb7683e3c 100644\n--- a/fs/cachefiles/namei.c\n+++ b/fs/cachefiles/namei.c\n@@ -810,6 +810,11 @@ int cachefiles_cull(struct cachefiles_cache *cache, struct dentry *dir,\n \tif (ret < 0)\n \t\tgoto error_unlock;\n \n+\t/*\n+\t * cachefiles_bury_object() expects 2 references to 'victim',\n+\t * and drops one.\n+\t */\n+\tdget(victim);\n \tret = cachefiles_bury_object(cache, NULL, dir, victim,\n \t\t\t\t FSCACHE_OBJECT_WAS_CULLED);\n \tdput(victim);\n","prefixes":["3/4"]}