{"id":2222338,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222338/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260411080148.471335-15-kwilczynski@kernel.org/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.1/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260411080148.471335-15-kwilczynski@kernel.org>","date":"2026-04-11T08:01:38","name":"[v4,14/24] alpha/PCI: Clean up pci_mmap_resource()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"8c31c8c78b5aaa69a5fc75c3f95539ee9af43598","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/1.1/people/86709/?format=json","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260411080148.471335-15-kwilczynski@kernel.org/mbox/","series":[{"id":499539,"url":"http://patchwork.ozlabs.org/api/1.1/series/499539/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=499539","date":"2026-04-11T08:01:24","name":"PCI: Convert all dynamic sysfs attributes to static","version":4,"mbox":"http://patchwork.ozlabs.org/series/499539/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222338/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222338/checks/","tags":{},"headers":{"Return-Path":"\n <linux-pci+bounces-52382-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=ZQCKsrLR;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-pci+bounces-52382-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"ZQCKsrLR\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ft5kc124Mz1yCx\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 11 Apr 2026 18:02:48 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id B913C3019386\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 11 Apr 2026 08:02:45 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id A8C9A13D8B1;\n\tSat, 11 Apr 2026 08:02:42 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 865DE1C5D7D;\n\tSat, 11 Apr 2026 08:02:42 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 2A5FAC19425;\n\tSat, 11 Apr 2026 08:02:39 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775894562; cv=none;\n b=S8o3CRDUeoACm1Aqh7n+FvyeYe/FXzFz/VagSWTpmIe3co1IMzx9O49ADAijpNfqhoCdLPCiX3LsElKYNT9Iqzex6HqnEWhWqqTWYa8jQu2y5F171VVzc4I3UcpycAGSmclpk0tGAj70uip8vBhDVTRQO61SSpOxlF2m+xsTfIM=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775894562; c=relaxed/simple;\n\tbh=kjKATkMwwBWbUVCzi5pJZe7y0tUywHculflz6sXXOSE=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=fjhCkG8beP73NKT21wPRxuPmXavp38CEnjvZfCtkBTR2ovsBFQGfNMMqMhk8WNrAaW3xFaznjIluidx+VHNlUHG+iwvR6fke/QwCDw00IkHE4cvqdqrEtKoSz/y4LX96DBaukDk2VMauQZYHh57TgvuVm0FgWlXg0dB15bEyFO8=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=ZQCKsrLR; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775894562;\n\tbh=kjKATkMwwBWbUVCzi5pJZe7y0tUywHculflz6sXXOSE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ZQCKsrLRkN12ZbR9aGp2kKcZGxvt4/l5tWCBRwAh2B1eRIMB7FVeK0bf6EmGuhXX0\n\t mmik6M6SR717IuW0RdFd2VBrCNbz8+YrSXrJDTSp47zSsONrNPCW7fBUbHhtpigIyI\n\t v9zgzAAZYXB6hCeDZ9f9sf75a6khYrB3SD+nW7Oj2XWtZ2kBUj5ZKxhS2y+P4kUkm7\n\t p917fcsouobfBSBjIqF/zM0ZXfr/j0rtnXR2KAduqvdnO9E7E2BILFU2kQuL0utfnN\n\t vaY2fsDC6QMUctK+k/4PNkXc3ewmn/z1zg7dCYXF/uo4xlv6TdImKVObZGSyJDJzTI\n\t rhwsblmw2MaCg==","From":"=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= <kwilczynski@kernel.org>","To":"Bjorn Helgaas <bhelgaas@google.com>","Cc":"Bjorn Helgaas <helgaas@kernel.org>,\n Manivannan Sadhasivam <mani@kernel.org>,\n Lorenzo Pieralisi <lpieralisi@kernel.org>,\n Magnus Lindholm <linmag7@gmail.com>, Matt Turner <mattst88@gmail.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n Christophe Leroy <chleroy@kernel.org>,\n Madhavan Srinivasan <maddy@linux.ibm.com>,\n Michael Ellerman <mpe@ellerman.id.au>, Nicholas Piggin <npiggin@gmail.com>,\n Dexuan Cui <decui@microsoft.com>,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= <khalasa@piap.pl>,\n Lukas Wunner <lukas@wunner.de>, \"Oliver O'Halloran\" <oohall@gmail.com>,\n Saurabh Singh Sengar <ssengar@microsoft.com>,\n Shuan He <heshuan@bytedance.com>, Srivatsa Bhat <srivatsabhat@microsoft.com>,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"[PATCH v4 14/24] alpha/PCI: Clean up pci_mmap_resource()","Date":"Sat, 11 Apr 2026 08:01:38 +0000","Message-ID":"<20260411080148.471335-15-kwilczynski@kernel.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260411080148.471335-1-kwilczynski@kernel.org>","References":"<20260411080148.471335-1-kwilczynski@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"<linux-pci.vger.kernel.org>","List-Subscribe":"<mailto:linux-pci+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-pci+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit"},"content":"Replace open-coded res->flags type checks with new pci_resource_is_mem()\nand pci_resource_start() helpers.  Move the pci_resource_n() call into\npcibios_resource_to_bus() and drop the local struct resource pointer.\n\nSigned-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>\n---\n arch/alpha/kernel/pci-sysfs.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/arch/alpha/kernel/pci-sysfs.c b/arch/alpha/kernel/pci-sysfs.c\nindex 7aac5e76dcd6..6c011dab326d 100644\n--- a/arch/alpha/kernel/pci-sysfs.c\n+++ b/arch/alpha/kernel/pci-sysfs.c\n@@ -70,7 +70,6 @@ static int pci_mmap_resource(struct kobject *kobj,\n {\n \tstruct pci_dev *pdev = to_pci_dev(kobj_to_dev(kobj));\n \tint barno = (unsigned long)attr->private;\n-\tstruct resource *res = pci_resource_n(pdev, barno);\n \tenum pci_mmap_state mmap_type;\n \tstruct pci_bus_region bar;\n \tint ret;\n@@ -79,15 +78,16 @@ static int pci_mmap_resource(struct kobject *kobj,\n \tif (ret)\n \t\treturn ret;\n \n-\tif ((res->flags & IORESOURCE_MEM) && iomem_is_exclusive(res->start))\n+\tif (pci_resource_is_mem(pdev, barno) &&\n+\t    iomem_is_exclusive(pci_resource_start(pdev, barno)))\n \t\treturn -EINVAL;\n \n \tif (!__pci_mmap_fits(pdev, barno, vma, sparse))\n \t\treturn -EINVAL;\n \n-\tpcibios_resource_to_bus(pdev->bus, &bar, res);\n+\tpcibios_resource_to_bus(pdev->bus, &bar, pci_resource_n(pdev, barno));\n \tvma->vm_pgoff += bar.start >> (PAGE_SHIFT - (sparse ? 5 : 0));\n-\tmmap_type = res->flags & IORESOURCE_MEM ? pci_mmap_mem : pci_mmap_io;\n+\tmmap_type = pci_resource_is_mem(pdev, barno) ? pci_mmap_mem : pci_mmap_io;\n \n \treturn hose_mmap_page_range(pdev->sysdata, vma, mmap_type, sparse);\n }\n","prefixes":["v4","14/24"]}