{"id":2222332,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222332/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260411080148.471335-10-kwilczynski@kernel.org/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.1/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260411080148.471335-10-kwilczynski@kernel.org>","date":"2026-04-11T08:01:33","name":"[v4,09/24] PCI/sysfs: Add stubs for pci_{create,remove}_sysfs_dev_files()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ecd807f5d0b463004540edcad5d31171345378e5","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/1.1/people/86709/?format=json","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260411080148.471335-10-kwilczynski@kernel.org/mbox/","series":[{"id":499539,"url":"http://patchwork.ozlabs.org/api/1.1/series/499539/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=499539","date":"2026-04-11T08:01:24","name":"PCI: Convert all dynamic sysfs attributes to static","version":4,"mbox":"http://patchwork.ozlabs.org/series/499539/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222332/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222332/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=qPbVv9Wh;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-pci+bounces-52377-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"qPbVv9Wh\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ft5kM2Kmfz1yCx\n\tfor ; Sat, 11 Apr 2026 18:02:35 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 852E5301373B\n\tfor ; Sat, 11 Apr 2026 08:02:26 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 87EFD29DB8F;\n\tSat, 11 Apr 2026 08:02:25 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 64AB41C5D7D;\n\tSat, 11 Apr 2026 08:02:25 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id EA349C2BCAF;\n\tSat, 11 Apr 2026 08:02:21 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775894545; cv=none;\n b=U7rLKZNMLuAUswe3lO8jbrBVWhlqCwsm2FZ9Ri5Lfsft5eJ9azxil93vo+wQv0cLXbBVTluRUI850F4ZIpB3tcyRCIVc3xfZzRcdJEZd18iTO/Hv673Gsy1puxbKk4YMRV0WgT3dCyZclUkG8ImgMJ2mJgdLvRl+GZuZKYwAMAw=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775894545; c=relaxed/simple;\n\tbh=9a670pxaN5vTIVp/eoWyGpfgnbFQKJPHCQ1Ff885QlM=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=K7fNgLpzJDHyXzle+BRGBPRG1RJSaXKxuKtnpN1MkfZlq0HVdkoJkV8uzGFB0t8hGYJ0TVyCyCZn5klH3oTZnkuJJwudvyhqA0fZ9B2Iyom0PiI8lh//a/I10ROYf04Sg8OVD5Cj8iabB86H0iJpzs/Jbwzjo5mzNEAmZ68qoj4=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=qPbVv9Wh; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775894545;\n\tbh=9a670pxaN5vTIVp/eoWyGpfgnbFQKJPHCQ1Ff885QlM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=qPbVv9WhBWox7dr5g2vDAopTc0X5xiboVRjNJI7LgeLqKNeHmTJIaxt46Qsegle1V\n\t TQYTe3PylOWfk0W+/ZIL1esZUo0g/+vGfjSrMGBjXxj1hQRNS3VL/J2YcKwtsQkOHw\n\t 6vHy/QDfdxvmyftuVA+RE2NJwzQbtAjaos6yMMPZS4F++g4IM+8xDq44cB6otAgApJ\n\t kA8uGay4UDihkvQBTrGTdN/4iJE3G9c0zaKNZAlfSgLyZnLHaHj46BnNoOkaHMnsY+\n\t NtqORr+Q4O5W2Ta9XdvrW36MFjJ2OLUVeGQK5YRJ0ADsH6deWQBQb/PLj2tpDZQWkD\n\t yIyt8Fanmua3g==","From":"=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= ","To":"Bjorn Helgaas ","Cc":"Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= ,\n Lukas Wunner , \"Oliver O'Halloran\" ,\n Saurabh Singh Sengar ,\n Shuan He , Srivatsa Bhat ,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= ,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"[PATCH v4 09/24] PCI/sysfs: Add stubs for\n pci_{create,remove}_sysfs_dev_files()","Date":"Sat, 11 Apr 2026 08:01:33 +0000","Message-ID":"<20260411080148.471335-10-kwilczynski@kernel.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260411080148.471335-1-kwilczynski@kernel.org>","References":"<20260411080148.471335-1-kwilczynski@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit"},"content":"On platforms with HAVE_PCI_MMAP or ARCH_GENERIC_PCI_MMAP_RESOURCE,\nresource files are now handled by static attribute groups registered\nvia pci_dev_groups[].\n\nThus, the pci_create_sysfs_dev_files() and pci_remove_sysfs_dev_files()\ncan now be stubbed out, as the dynamic resource file creation is no\nlonger needed.\n\nAlso, simplify pci_sysfs_init() on these platforms to only iterate\nbuses for legacy attributes creation, skipping the per-device loop.\n\nMove the __weak stubs for pci_create_resource_files() and\npci_remove_resource_files() into the #else branch since only platforms\nwithout HAVE_PCI_MMAP (such as Alpha architecture) still need them.\nGuard the res_attr[] and res_attr_wc[] fields in struct pci_dev the\nsame way.\n\nSigned-off-by: Krzysztof Wilczyński \n---\n drivers/pci/pci-sysfs.c | 15 ++++++++++++---\n include/linux/pci.h | 4 ++++\n 2 files changed, 16 insertions(+), 3 deletions(-)","diff":"diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c\nindex c0925bdc9ecd..517efb6d71cc 100644\n--- a/drivers/pci/pci-sysfs.c\n+++ b/drivers/pci/pci-sysfs.c\n@@ -1394,10 +1394,9 @@ static const struct attribute_group *pci_dev_resource_attr_groups[] = {\n };\n #else\n #define pci_dev_resource_attr_groups NULL\n-#endif\n-\n int __weak pci_create_resource_files(struct pci_dev *dev) { return 0; }\n void __weak pci_remove_resource_files(struct pci_dev *dev) { }\n+#endif\n \n /**\n * pci_write_rom - used to enable access to the PCI ROM display\n@@ -1766,6 +1765,10 @@ static const struct attribute_group pci_dev_resource_resize_attr_group = {\n \t.is_visible = resource_resize_attr_is_visible,\n };\n \n+#if defined(HAVE_PCI_MMAP) || defined(ARCH_GENERIC_PCI_MMAP_RESOURCE)\n+int pci_create_sysfs_dev_files(struct pci_dev *pdev) { return 0; }\n+void pci_remove_sysfs_dev_files(struct pci_dev *pdev) { }\n+#else\n int __must_check pci_create_sysfs_dev_files(struct pci_dev *pdev)\n {\n \tif (!sysfs_initialized)\n@@ -1787,9 +1790,15 @@ void pci_remove_sysfs_dev_files(struct pci_dev *pdev)\n \n \tpci_remove_resource_files(pdev);\n }\n+#endif\n \n static int __init pci_sysfs_init(void)\n {\n+#if defined(HAVE_PCI_MMAP) || defined(ARCH_GENERIC_PCI_MMAP_RESOURCE)\n+\tstruct pci_bus *pbus = NULL;\n+\n+\tsysfs_initialized = 1;\n+#else\n \tstruct pci_dev *pdev = NULL;\n \tstruct pci_bus *pbus = NULL;\n \tint retval;\n@@ -1802,7 +1811,7 @@ static int __init pci_sysfs_init(void)\n \t\t\treturn retval;\n \t\t}\n \t}\n-\n+#endif\n \twhile ((pbus = pci_find_next_bus(pbus)))\n \t\tpci_create_legacy_files(pbus);\n \ndiff --git a/include/linux/pci.h b/include/linux/pci.h\nindex 9c0782899ef9..30aeb8e02b7b 100644\n--- a/include/linux/pci.h\n+++ b/include/linux/pci.h\n@@ -507,8 +507,10 @@ struct pci_dev {\n \tspinlock_t\tpcie_cap_lock;\t\t/* Protects RMW ops in capability accessors */\n \tu32\t\tsaved_config_space[16]; /* Config space saved at suspend time */\n \tstruct hlist_head saved_cap_space;\n+#if !defined(HAVE_PCI_MMAP) && !defined(ARCH_GENERIC_PCI_MMAP_RESOURCE)\n \tstruct bin_attribute *res_attr[DEVICE_COUNT_RESOURCE]; /* sysfs file for resources */\n \tstruct bin_attribute *res_attr_wc[DEVICE_COUNT_RESOURCE]; /* sysfs file for WC mapping of resources */\n+#endif\n \n #ifdef CONFIG_HOTPLUG_PCI_PCIE\n \tunsigned int\tbroken_cmd_compl:1;\t/* No compl for some cmds */\n@@ -2526,8 +2528,10 @@ int pcibios_alloc_irq(struct pci_dev *dev);\n void pcibios_free_irq(struct pci_dev *dev);\n resource_size_t pcibios_default_alignment(void);\n \n+#if !defined(HAVE_PCI_MMAP) && !defined(ARCH_GENERIC_PCI_MMAP_RESOURCE)\n extern int pci_create_resource_files(struct pci_dev *dev);\n extern void pci_remove_resource_files(struct pci_dev *dev);\n+#endif\n \n #if defined(CONFIG_PCI_MMCONFIG) || defined(CONFIG_ACPI_MCFG)\n void __init pci_mmcfg_early_init(void);\n","prefixes":["v4","09/24"]}