{"id":2222258,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222258/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260411022618.2136588-10-kshk@linux.ibm.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260411022618.2136588-10-kshk@linux.ibm.com>","date":"2026-04-11T02:26:12","name":"[v2,09/15] s390x/pci: Move g_iota from S390PCIIOMMU to S390PCIBusDevice","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5f84e666801266de6739e218cf161383137cbb3c","submitter":{"id":90249,"url":"http://patchwork.ozlabs.org/api/1.1/people/90249/?format=json","name":"Konstantin Shkolnyy","email":"kshk@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260411022618.2136588-10-kshk@linux.ibm.com/mbox/","series":[{"id":499525,"url":"http://patchwork.ozlabs.org/api/1.1/series/499525/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499525","date":"2026-04-11T02:26:13","name":"s390x/pci: Implement migration for emulated devices","version":2,"mbox":"http://patchwork.ozlabs.org/series/499525/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222258/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222258/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=GwLqCX+C;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsyKB5pZ4z1yCv\n\tfor ; Sat, 11 Apr 2026 12:28:46 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBO3u-00026r-VZ; Fri, 10 Apr 2026 22:27:06 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBO3t-00025p-Se; Fri, 10 Apr 2026 22:27:05 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBO3r-0000Ml-G1; Fri, 10 Apr 2026 22:27:05 -0400","from pps.filterd (m0356517.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63B1tB9C2420823; Sat, 11 Apr 2026 02:26:59 GMT","from ppma13.dal12v.mail.ibm.com\n (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dcn2fw3vu-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Sat, 11 Apr 2026 02:26:59 +0000 (GMT)","from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1])\n by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 63B0U1ZT019113;\n Sat, 11 Apr 2026 02:26:58 GMT","from smtprelay05.dal12v.mail.ibm.com ([172.16.1.7])\n by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4dcme9u238-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Sat, 11 Apr 2026 02:26:58 +0000","from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com\n [10.39.53.230])\n by smtprelay05.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63B2QvIm23790322\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Sat, 11 Apr 2026 02:26:57 GMT","from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 606A95805A;\n Sat, 11 Apr 2026 02:26:57 +0000 (GMT)","from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id C86A058054;\n Sat, 11 Apr 2026 02:26:56 +0000 (GMT)","from WIN-DU0DFC9G5VV.ibm.com (unknown [9.61.252.248])\n by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n Sat, 11 Apr 2026 02:26:56 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=9O2dwSdCOQfpP/HIU\n 7CH820qFNISS0WlI/zjHFURx38=; b=GwLqCX+CIEsFtm3vOYOmBU1AjPOHs4tfL\n Lj9/2tS+0ZVVNz/LCqeY/TQA0AZYiUReVg14nh8wIeknqP8/YS9+JGmPHAd7ekiy\n 4VBKakoN2dcdJSNolX2lzMseDDx+6Hm6VbX7hdhK6+fSGJcXy1+EhGKH7VErDXRw\n VSp6+y5o2EWdfQRVTLm/uW3NR8UEcDp/R9ZgrcapA7334j3UA9eYmiRP9vcHt+Xv\n z+vdZN/304weFRrCV/PWKpyZSTQBLGF8XIKJidgx0LaT+7SAQAANO3np8ClO2WmP\n 1rdS1kgwXSNCPwX5RgF7B+cTMUUXswb1TWRlPMZBBoXcpVGsKfO1A==","From":"Konstantin Shkolnyy ","To":"mjrosato@linux.ibm.com","Cc":"alifm@linux.ibm.com, richard.henderson@linaro.org, iii@linux.ibm.com,\n david@kernel.org, cohuck@redhat.com, pasic@linux.ibm.com,\n borntraeger@linux.ibm.com, qemu-s390x@nongnu.org,\n qemu-devel@nongnu.org, Konstantin Shkolnyy ","Subject":"[PATCH v2 09/15] s390x/pci: Move g_iota from S390PCIIOMMU to\n S390PCIBusDevice","Date":"Fri, 10 Apr 2026 21:26:12 -0500","Message-Id":"<20260411022618.2136588-10-kshk@linux.ibm.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260411022618.2136588-1-kshk@linux.ibm.com>","References":"<20260411022618.2136588-1-kshk@linux.ibm.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDExMDAxNiBTYWx0ZWRfX5ffiB7SeTVgR\n YoHzbt8L5k+Lg2f0TLX7Rk1i7sQVhc2/zmdxN6ptDHcupUVCfS/Nob+LHBjLaK54Qod4Gb3i2Yb\n Yeip9YwsB4AJq1wE4cNihfblrr8fgNXAjeRmdldrxRuBoYrJ9XKyeKZwA6X8pDn+ke3Mo+QvAl3\n JhcuEKXoFi+DR87E//UmFgfSV5zpjDOThWpwqUZBoSkFzZapxpveD75e5Znd7ZMnkPDOiUtwqJV\n CXJ/mwyXIyRpX0u2hBhgSS3camF0hiaD3PuR3F01QFLJOLBrJdETRc7GMZ4FieaLZuoYPLzElqI\n z4tXv9OmkAb9fGdygdPNj8kb2wesjXLXh3lRDkh1FsMCOBWDIKpTyKyNl+3VnYkX4nTcL0I79t4\n JAqFLN3rOjsFIHR3B894Dw7S9QwGLy4QBBxmpqH8CTQkU8qR45zvwchtTmIWXRIqRo4K3nnqmcI\n S7VQ+p2Ttgq8eYi8Hkw==","X-Authority-Analysis":"v=2.4 cv=FsY1OWrq c=1 sm=1 tr=0 ts=69d9b173 cx=c_pps\n a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17\n a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=U7nrCbtTmkRpXpFmAIza:22 a=VnNF1IyMAAAA:8 a=FDQAEqGjsTQLeQouP1gA:9","X-Proofpoint-ORIG-GUID":"slfD9TamJ9GcA38qrhqgQFGcVym_0P-F","X-Proofpoint-GUID":"slfD9TamJ9GcA38qrhqgQFGcVym_0P-F","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-10_07,2026-04-09_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n bulkscore=0 priorityscore=1501 impostorscore=0 spamscore=0 phishscore=0\n lowpriorityscore=0 clxscore=1015 adultscore=0 malwarescore=0 suspectscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604110016","Received-SPF":"pass client-ip=148.163.156.1; envelope-from=kshk@linux.ibm.com;\n helo=mx0a-001b2d01.pphosted.com","X-Spam_score_int":"-26","X-Spam_score":"-2.7","X-Spam_bar":"--","X-Spam_report":"(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"This field is only used when S390PCIBusDevice exists, so it can be moved\nthere to simplify S390PCIIOMMU which purpose is just to store the \"root\"\nAddressSpace.\n\nThis also allows to save/restore this field during migration.\n\nSigned-off-by: Konstantin Shkolnyy \n---\n hw/s390x/s390-pci-bus.c | 2 +-\n hw/s390x/s390-pci-inst.c | 10 +++++-----\n include/hw/s390x/s390-pci-bus.h | 2 +-\n 3 files changed, 7 insertions(+), 7 deletions(-)","diff":"diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c\nindex 4a0b31b98b..b784196c9e 100644\n--- a/hw/s390x/s390-pci-bus.c\n+++ b/hw/s390x/s390-pci-bus.c\n@@ -616,7 +616,7 @@ static void s390_pci_ioat_replay(S390PCIBusDevice *pbdev)\n }\n \n while (curr < end) {\n- error = s390_guest_io_table_walk(iommu->g_iota, curr, &entry);\n+ error = s390_guest_io_table_walk(pbdev->g_iota, curr, &entry);\n if (error) {\n error_report(\"Failure to walk table during iommu remap\");\n return;\ndiff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c\nindex ac4e7f412d..f4ec299614 100644\n--- a/hw/s390x/s390-pci-inst.c\n+++ b/hw/s390x/s390-pci-inst.c\n@@ -748,7 +748,7 @@ int rpcit_service_call(S390CPU *cpu, uint8_t r1, uint8_t r2, uintptr_t ra)\n } else {\n dma_avail = 1;\n }\n- if (!iommu->g_iota) {\n+ if (!pbdev->g_iota) {\n error = ERR_EVENT_INVALAS;\n goto err;\n }\n@@ -762,7 +762,7 @@ int rpcit_service_call(S390CPU *cpu, uint8_t r1, uint8_t r2, uintptr_t ra)\n start = sstart;\n again = false;\n while (start < end) {\n- error = s390_guest_io_table_walk(iommu->g_iota, start, &entry);\n+ error = s390_guest_io_table_walk(pbdev->g_iota, start, &entry);\n if (error) {\n break;\n }\n@@ -1028,7 +1028,7 @@ static int reg_ioat(CPUS390XState *env, S390PCIBusDevice *pbdev, ZpciFib fib,\n \n iommu->pba = pba;\n iommu->pal = pal;\n- iommu->g_iota = g_iota;\n+ pbdev->g_iota = g_iota;\n \n if (t) {\n s390_pci_iommu_enable(pbdev);\n@@ -1045,7 +1045,7 @@ void pci_dereg_ioat(S390PCIBusDevice *pbdev)\n s390_pci_iommu_disable(pbdev);\n iommu->pba = 0;\n iommu->pal = 0;\n- iommu->g_iota = 0;\n+ pbdev->g_iota = 0;\n }\n \n void fmb_timer_free(S390PCIBusDevice *pbdev)\n@@ -1418,7 +1418,7 @@ int stpcifc_service_call(S390CPU *cpu, uint8_t r1, uint64_t fiba, uint8_t ar,\n \n stq_be_p(&fib.pba, pbdev->iommu->pba);\n stq_be_p(&fib.pal, pbdev->iommu->pal);\n- stq_be_p(&fib.iota, pbdev->iommu->g_iota);\n+ stq_be_p(&fib.iota, pbdev->g_iota);\n stq_be_p(&fib.aibv, pbdev->routes.adapter.ind_addr);\n stq_be_p(&fib.aisb, pbdev->routes.adapter.summary_addr);\n stq_be_p(&fib.fmb_addr, pbdev->fmb_addr);\ndiff --git a/include/hw/s390x/s390-pci-bus.h b/include/hw/s390x/s390-pci-bus.h\nindex 126a50c98b..a7d1f1ade2 100644\n--- a/include/hw/s390x/s390-pci-bus.h\n+++ b/include/hw/s390x/s390-pci-bus.h\n@@ -275,7 +275,6 @@ struct S390PCIIOMMU {\n Object parent_obj;\n AddressSpace as;\n MemoryRegion mr;\n- uint64_t g_iota;\n uint64_t pba;\n uint64_t pal;\n uint64_t max_dma_limit;\n@@ -352,6 +351,7 @@ struct S390PCIBusDevice {\n IOMMUMemoryRegion iommu_mr;\n MemoryRegion *dm_mr;\n GHashTable *iotlb;\n+ uint64_t g_iota;\n S390PCIDMACount *dma_limit;\n MemoryRegion msix_notify_mr;\n IndAddr *summary_ind;\n","prefixes":["v2","09/15"]}