{"id":2222193,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222193/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410195323.17937-23-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410195323.17937-23-philmd@linaro.org>","date":"2026-04-10T19:53:16","name":"[v2,22/27] monitor: Do not check TARGET_I386 to build target/i386/ commands","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"dcc08de8fbc83f52f64067627dbb74192e6e4bc6","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.1/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410195323.17937-23-philmd@linaro.org/mbox/","series":[{"id":499498,"url":"http://patchwork.ozlabs.org/api/1.1/series/499498/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499498","date":"2026-04-10T19:52:54","name":"monitor: Remove need of per-target handlers","version":2,"mbox":"http://patchwork.ozlabs.org/series/499498/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222193/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222193/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=HR6rYuG7;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsng61hB2z1yCv\n\tfor ; Sat, 11 Apr 2026 05:58:42 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBHxd-0007aE-HB; Fri, 10 Apr 2026 15:56:13 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wBHxZ-0007Et-HU\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:56:09 -0400","from mail-wm1-x331.google.com ([2a00:1450:4864:20::331])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wBHxV-0003pJ-Fv\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:56:08 -0400","by mail-wm1-x331.google.com with SMTP id\n 5b1f17b1804b1-488b8efed61so22042275e9.1\n for ; Fri, 10 Apr 2026 12:56:05 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488d525c931sm98635955e9.0.2026.04.10.12.56.02\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 10 Apr 2026 12:56:03 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775850964; x=1776455764; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=k99xMD4s012E4So2wpbCNS02HNMrfRabi5ydC/W3ahM=;\n b=HR6rYuG7MCfqMjkRpYpiB9r9Pt99jtuZP6ntxr9DHjMPTiFKjZ24GVbQyzxAk5Cyl4\n Fl1LGtMb4fqlP9Yg805AYPplTqd08RwO6ZMUeOu8IpMADS2CYu3S2kzkjuDXtPKDkCut\n hOo6etvObrAk2qGeokHR62N9hu4zYW3dYgx1nbqXTg4wsghc6IhA1YHOMWX7lq7whnzx\n 45/IEFQjvyEZ/4dMeWBzFNHz0VCAhV5M8LaGXfc0VeIWoinPuj/mzIMksCRcZNbGi3Gg\n poQI+Lt7CccRV6k+BDg2s4N888Djc+xc5gTl9oPaToDkgIdtnBVIH5TcWcjA+2aoziMt\n vXsw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775850964; x=1776455764;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=k99xMD4s012E4So2wpbCNS02HNMrfRabi5ydC/W3ahM=;\n b=Uwn6lBmSZLpdO1lmnxqIUMIw0OBLiIPlPiN/A/RsyKtaq99Zo1Fz+nJU1doiXj/igy\n 6YQXXXbVtYqGBfz3jpUIWWebN9xEXMxXTx3qkZ+CJjdQBBqyGVa2TkKZJNR7aLMhG6ba\n upyNtcyKPmGF4IGVivPQDJ7Wmx5+I7jsw3j4Wr9Hz1sD5c3aFGNx+NrdBbpeFLJxz/m9\n 8kMLyBjF6mGVLDtobs95zB1aoAjSFpUNEkZeRIgbZT/l7eHJ67tqZfhulRR9+KeQF3zk\n 2V1J4ZnXu3bdoOjDOuvL8tKpiSMvPSC15FMmN8vhHeQqAvVZVHWGkUvjsDBWOsEM0DZI\n wVew==","X-Gm-Message-State":"AOJu0Yz+mgvO/+/fV6hDresBmgLh3XTvxHD6a/Rqm9nZMNOSmGN8nQxE\n 0ttOXAE7Hl1CS6V/XgfrdjkGG771f9+xq72X7Y7IH1GH5Ga5ro25BMusQIxH/3jyUqR63j4Qn7Z\n +9zinmUg=","X-Gm-Gg":"AeBDievuZShiH0INikSY2gQVwRWjg+fFI2l8ybMvD2GYPwlefXGB6W6SXPOEtPUsGG6\n aEyXrNwytIq/BGFnL+zqLl1WgRWqRyRrgLb+oKUdn03TpXzPlJpeC4b+iGzheP6H/kQM2G3sFro\n yDQJYl2XImA+ZZ5vFYGOT9741CT5wZsZlUJaP8JgEhgMUP9UvxMFZnm30KuBEf5L/Miy1uyCkxw\n +x4HrdWJitCqdEZURoeiRiZ0nMNy7HJswXj4NlrmnfJ0ZOMWk+50nou3/ADVPuxQC+F4LogG7Q6\n JGntaE1nCj0nDapN6r4zTALHYEp1x+xlD4ImWAimjhsyg5WrmQBL7XsUsci+/BSe2LYAR1jOyt3\n 4lljShKPu2CPgcOhe58OZN26U4+ZuMtoorYsuY/+KgSvTql58aI8y54BMDkyQ8zw5ZsOid/+IpC\n 5orZmIA6OEzG9HIGQ4MxSVoL73PgRsbJbmmfzEdlNaAqLKhAPJRT+K1OGIVNyAT6AeOriCJUco","X-Received":"by 2002:a05:600c:609a:b0:485:3e00:944a with SMTP id\n 5b1f17b1804b1-488d68ae78amr59095475e9.9.1775850963612;\n Fri, 10 Apr 2026 12:56:03 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Richard Henderson ,\n \"Dr. David Alan Gilbert\" ,\n Pierrick Bouvier , qemu-riscv@nongnu.org,\n Markus Armbruster , qemu-s390x@nongnu.org,\n kvm@vger.kernel.org, qemu-ppc@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= , Paolo Bonzini ,\n Zhao Liu ","Subject":"[PATCH v2 22/27] monitor: Do not check TARGET_I386 to build\n target/i386/ commands","Date":"Fri, 10 Apr 2026 21:53:16 +0200","Message-ID":"<20260410195323.17937-23-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260410195323.17937-1-philmd@linaro.org>","References":"<20260410195323.17937-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::331;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"These commands are filtered at build-time for i386/x86_64 binaries.\nBy using the recently introduced HMPCommand::arch_bitmask flag\nwe can filter them at runtime, making it possible to compile\nhmp-commands[-info].hx files once.\n\nSince these methods are used inconditionally within target/i386/,\ndefine them in the same stub file.\n\nSigned-off-by: Philippe Mathieu-Daudé \n---\n MAINTAINERS | 1 +\n stubs/hmp-cmds-target-i386.c | 13 +++++++++++++\n hmp-commands-info.hx | 4 +---\n hmp-commands.hx | 5 +----\n stubs/meson.build | 1 +\n 5 files changed, 17 insertions(+), 7 deletions(-)\n create mode 100644 stubs/hmp-cmds-target-i386.c","diff":"diff --git a/MAINTAINERS b/MAINTAINERS\nindex e53158143a8..458951bc051 100644\n--- a/MAINTAINERS\n+++ b/MAINTAINERS\n@@ -148,6 +148,7 @@ F: configs/targets/i386-softmmu.mak\n F: configs/targets/x86_64-softmmu.mak\n F: docs/system/i386/\n F: docs/system/target-i386*\n+F: stubs/hmp-cmds-target-i386.c\n F: target/i386/*.[ch]\n F: target/i386/Kconfig\n F: target/i386/meson.build\ndiff --git a/stubs/hmp-cmds-target-i386.c b/stubs/hmp-cmds-target-i386.c\nnew file mode 100644\nindex 00000000000..43a167056d5\n--- /dev/null\n+++ b/stubs/hmp-cmds-target-i386.c\n@@ -0,0 +1,13 @@\n+/*\n+ * Human Monitor x86 stubs\n+ *\n+ * Copyright (c) Linaro\n+ *\n+ * SPDX-License-Identifier: GPL-2.0-or-later\n+ */\n+\n+#include \"qemu/osdep.h\"\n+#include \"monitor/hmp.h\"\n+\n+HMP_STUB(info_local_apic)\n+HMP_STUB(mce)\ndiff --git a/hmp-commands-info.hx b/hmp-commands-info.hx\nindex 28dec25642d..b575e4ac993 100644\n--- a/hmp-commands-info.hx\n+++ b/hmp-commands-info.hx\n@@ -113,16 +113,14 @@ SRST\n Show the cpu registers.\n ERST\n \n-#if defined(TARGET_I386)\n {\n .name = \"lapic\",\n .args_type = \"apic-id:i?\",\n .params = \"[apic-id]\",\n .help = \"show local apic state (apic-id: local apic to read, default is which of current CPU)\",\n-\n .cmd = hmp_info_local_apic,\n+ .arch_bitmask = QEMU_ARCH_I386,\n },\n-#endif\n \n SRST\n ``info lapic``\ndiff --git a/hmp-commands.hx b/hmp-commands.hx\nindex ff65b39b454..cfd53bdc744 100644\n--- a/hmp-commands.hx\n+++ b/hmp-commands.hx\n@@ -1488,18 +1488,15 @@ SRST\n Stop the QEMU embedded NBD server.\n ERST\n \n-\n-#if defined(TARGET_I386)\n-\n {\n .name = \"mce\",\n .args_type = \"broadcast:-b,cpu_index:i,bank:i,status:l,mcg_status:l,addr:l,misc:l\",\n .params = \"[-b] cpu bank status mcgstatus addr misc\",\n .help = \"inject a MCE on the given CPU [and broadcast to other CPUs with -b option]\",\n .cmd = hmp_mce,\n+ .arch_bitmask = QEMU_ARCH_I386,\n },\n \n-#endif\n SRST\n ``mce`` *cpu* *bank* *status* *mcgstatus* *addr* *misc*\n Inject an MCE on the given CPU (x86 only).\ndiff --git a/stubs/meson.build b/stubs/meson.build\nindex d4a6bc0dde4..dc289e3a482 100644\n--- a/stubs/meson.build\n+++ b/stubs/meson.build\n@@ -85,6 +85,7 @@ if have_system\n stub_ss.add(files('qmp-cpu-s390x.c'))\n stub_ss.add(files('qmp-cpu-s390x-kvm.c'))\n stub_ss.add(files('hmp-cmds-hw-s390x.c'))\n+ stub_ss.add(files('hmp-cmds-target-i386.c'))\n endif\n \n if have_system or have_user\n","prefixes":["v2","22/27"]}