{"id":2222189,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222189/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410195323.17937-14-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410195323.17937-14-philmd@linaro.org>","date":"2026-04-10T19:53:07","name":"[v2,13/27] monitor: Remove target_get_monitor_def()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f507ca758584d78f9abec186f4e6a948c4db8dda","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.1/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410195323.17937-14-philmd@linaro.org/mbox/","series":[{"id":499498,"url":"http://patchwork.ozlabs.org/api/1.1/series/499498/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499498","date":"2026-04-10T19:52:54","name":"monitor: Remove need of per-target handlers","version":2,"mbox":"http://patchwork.ozlabs.org/series/499498/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222189/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222189/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=hDwdKDl7;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsnfV5fPfz1yCv\n\tfor ; Sat, 11 Apr 2026 05:58:10 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBHwZ-0002HA-0c; Fri, 10 Apr 2026 15:55:07 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wBHwX-0002F6-7C\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:55:05 -0400","from mail-wm1-x332.google.com ([2a00:1450:4864:20::332])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wBHwU-0001is-47\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:55:04 -0400","by mail-wm1-x332.google.com with SMTP id\n 5b1f17b1804b1-488971db0fdso23955315e9.0\n for ; Fri, 10 Apr 2026 12:55:01 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488d592d606sm88600455e9.9.2026.04.10.12.54.58\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 10 Apr 2026 12:54:59 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775850900; x=1776455700; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=WQoGjEROfb1fZGcAyFP7wGDHaXz8m4JpMOdQttRvXaU=;\n b=hDwdKDl7XKAPOkK7kPQc5XoqlmAAHXUIARDvA/fb5kI2SKFNyGZRW7XLz3mYNBmk3x\n NBTkIhYVrqRdIBETJfqAvJhskn4LIUQF5I0rErM0yN67lSoMy4+xOogUrGmIP5wbfJD+\n 5O8W0CYd13ZyZ78rT5vL5PyPBQWWlvPEHNpkLnyCI2oN03hsbB7vK3eokDcL9maURGW6\n GXAq0d5vJXqgroNWz6GhdM/XMM83UM9y6UyHij8h8yUurd9u8u5fhnLCxkCIyJwHLeZ2\n 3UEKcOn3b6H1KGpcrJIjBv+hUDRLLZSFSzYnVFX2SyNAzIoILW6r+bMy92L2IM9mPcg1\n lCag==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775850900; x=1776455700;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=WQoGjEROfb1fZGcAyFP7wGDHaXz8m4JpMOdQttRvXaU=;\n b=LbpD3uzXFANOxVRl01R6OctMHL0nSjeW1JirvnI7S0TGATmYV0yQRognO+gIMj+FRz\n rK66jGMW2sADBMaxtofUalp5ZwKgi/Apz3mnP7a65Y6vvcddCwrqiqE4MyIsiLPaXfU/\n RLkkQuadq/PPDKXFDEXX0+mDqxn2Bf9Akx2UXadBE3rSJZug+TXyuNFO2BkNJTaaAOtV\n 6NCAYD0QUAdExJqnWGq9gevKgzBrLnN0Z6mo3+dh9AibjgcfohpUmVL+iYpw5NJpKBPx\n Pm+p1wh6X0Dz4MXsh5OaF9CpCSrTFGYtnPfrH8M3Syo3SlpWIJr6RkPpluqo9FNTTzW0\n w/Gw==","X-Gm-Message-State":"AOJu0Yx46aaHkBz2w8uF6rQuUju/6AdxMv0rzS6c4N4FSc4yDYnA5OuE\n gE9f8kQfdbRMVvYOLRb8kqYCc4dH1Z2goUOIFnFdDXwdregixWBSeSGbJbT50wD1I5obpg8L82C\n M3TCE1Cg=","X-Gm-Gg":"AeBDiev24ThVSPFuBZTTklrz/OOb4cYphMI/zYaGh6uVMFcyJ8npB9dVTojp/QXWJqs\n 9b5PYz6jOUbwgTjya0et2qnIU0/DiZhO+tMmjTFt9j3lMNSsWth7a5+xuuH4l195STaSV/LOjoO\n ZnhqWzq6k35UwiB6NYWnlMoU6ReF1YmmwCqcKKnn89JBbQWTgDuTjNicE60PSLzve/vys89P2jC\n 0C+KtxqpM/GLRldFURSrjNbmw2YCWsgq+OaWWZ4DixKEJbZoEmwc2PkQnyM/60m+3TnFuqEJbV6\n cRsXKfQWZOJPd0qvWefNrGgAjtRXoqxEA6kvY+EWvZZOKpr+ZKzt4zNkFnF0zuEPLJ3nrfW0HeV\n l+u48ZR8Ah8Vsglj/Y+kMZWfsAhyqUU5KJINAce7t2jVhjR+ZBhn1xDgncKnollQJVd/Y5IvSFI\n ZXwbDHDGQF2nMHPqFUZXyj7ixqX0eA6tELf4VDeGGfBaPmlYvv8O8j4yA1ka4DK5w/JCk375dF","X-Received":"by 2002:a05:600c:c0c8:b0:488:8bdd:cfb9 with SMTP id\n 5b1f17b1804b1-488d67bbbf8mr42408135e9.1.1775850899858;\n Fri, 10 Apr 2026 12:54:59 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Richard Henderson ,\n \"Dr. David Alan Gilbert\" ,\n Pierrick Bouvier , qemu-riscv@nongnu.org,\n Markus Armbruster , qemu-s390x@nongnu.org,\n kvm@vger.kernel.org, qemu-ppc@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= , Paolo Bonzini ","Subject":"[PATCH v2 13/27] monitor: Remove target_get_monitor_def()","Date":"Fri, 10 Apr 2026 21:53:07 +0200","Message-ID":"<20260410195323.17937-14-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260410195323.17937-1-philmd@linaro.org>","References":"<20260410195323.17937-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::332;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"target_get_monitor_def() is now only a dead stub. Remove as pointless.\n\nSigned-off-by: Philippe Mathieu-Daudé \n---\n include/monitor/hmp.h | 2 --\n monitor/hmp.c | 7 +++----\n stubs/target-get-monitor-def.c | 29 -----------------------------\n stubs/meson.build | 1 -\n 4 files changed, 3 insertions(+), 36 deletions(-)\n delete mode 100644 stubs/target-get-monitor-def.c","diff":"diff --git a/include/monitor/hmp.h b/include/monitor/hmp.h\nindex cabb2c55f8e..b444095f684 100644\n--- a/include/monitor/hmp.h\n+++ b/include/monitor/hmp.h\n@@ -23,8 +23,6 @@ struct MonitorDef {\n int64_t (*get_value)(Monitor *mon, const MonitorDef *md, int offset);\n };\n \n-int target_get_monitor_def(CPUState *cs, const char *name, uint64_t *pval);\n-\n CPUArchState *mon_get_cpu_env(Monitor *mon);\n CPUState *mon_get_cpu(Monitor *mon);\n \ndiff --git a/monitor/hmp.c b/monitor/hmp.c\nindex 799855f3f68..3b9e180c1ca 100644\n--- a/monitor/hmp.c\n+++ b/monitor/hmp.c\n@@ -1632,11 +1632,10 @@ static int get_monitor_def(Monitor *mon, int64_t *pval, const char *name)\n }\n }\n \n- if (cs->cc->sysemu_ops->monitor_get_register) {\n- ret = cs->cc->sysemu_ops->monitor_get_register(cs, name, &tmp);\n- } else {\n- ret = target_get_monitor_def(cs, name, &tmp);\n+ if (!cs->cc->sysemu_ops->monitor_get_register) {\n+ return -1;\n }\n+ ret = cs->cc->sysemu_ops->monitor_get_register(cs, name, &tmp);\n if (!ret) {\n *pval = target_long_bits() == 32 ? (int32_t)tmp : tmp;\n }\ndiff --git a/stubs/target-get-monitor-def.c b/stubs/target-get-monitor-def.c\ndeleted file mode 100644\nindex 394e0f9a7d2..00000000000\n--- a/stubs/target-get-monitor-def.c\n+++ /dev/null\n@@ -1,29 +0,0 @@\n-/*\n- * Stub for target_get_monitor_def.\n- *\n- * Copyright IBM Corp., 2015\n- *\n- * Author: Alexey Kardashevskiy \n- *\n- * This program is free software; you can redistribute it and/or modify\n- * it under the terms of the GNU General Public License as published by\n- * the Free Software Foundation; either version 2 of the License,\n- * or (at your option) any later version.\n- *\n- * This program is distributed in the hope that it will be useful,\n- * but WITHOUT ANY WARRANTY; without even the implied warranty of\n- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n- * GNU General Public License for more details.\n- *\n- * You should have received a copy of the GNU General Public License\n- * along with this program; if not, see .\n- */\n-\n-#include \"qemu/osdep.h\"\n-\n-int target_get_monitor_def(CPUState *cs, const char *name, uint64_t *pval);\n-\n-int target_get_monitor_def(CPUState *cs, const char *name, uint64_t *pval)\n-{\n- return -1;\n-}\ndiff --git a/stubs/meson.build b/stubs/meson.build\nindex 10eb68ab55e..85f9e3a4f23 100644\n--- a/stubs/meson.build\n+++ b/stubs/meson.build\n@@ -74,7 +74,6 @@ if have_system\n stub_ss.add(files('igvm.c'))\n endif\n stub_ss.add(files('kvm.c'))\n- stub_ss.add(files('target-get-monitor-def.c'))\n stub_ss.add(files('win32-kbd-hook.c'))\n stub_ss.add(files('xen-hw-stub.c'))\n stub_ss.add(files('monitor-arm-gic.c'))\n","prefixes":["v2","13/27"]}