{"id":2222178,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222178/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410195323.17937-9-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410195323.17937-9-philmd@linaro.org>","date":"2026-04-10T19:53:02","name":"[v2,08/27] target/m68k: Replace target_monitor_defs -> SysemuCPUOps::monitor_defs","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"66bb3c3f047b989c882ef94d7947382c15c5ec02","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.1/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410195323.17937-9-philmd@linaro.org/mbox/","series":[{"id":499498,"url":"http://patchwork.ozlabs.org/api/1.1/series/499498/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499498","date":"2026-04-10T19:52:54","name":"monitor: Remove need of per-target handlers","version":2,"mbox":"http://patchwork.ozlabs.org/series/499498/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222178/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222178/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=ojN2lMce;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsndr30Qsz1yGb\n\tfor ; Sat, 11 Apr 2026 05:57:36 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBHw0-0000ry-Hk; Fri, 10 Apr 2026 15:54:32 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wBHvy-0000pv-Se\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:54:30 -0400","from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wBHvv-0001US-I6\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:54:30 -0400","by mail-wm1-x32f.google.com with SMTP id\n 5b1f17b1804b1-488a9033b2cso28740705e9.2\n for ; Fri, 10 Apr 2026 12:54:25 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488d683e54fsm26145515e9.23.2026.04.10.12.54.22\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 10 Apr 2026 12:54:23 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775850864; x=1776455664; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=EuoKZZrJIA/hKCIvNS2NFNqHU7220n1eLUSWyy7IvJI=;\n b=ojN2lMcenJRrbVuHebxt77o/Zn5ZVKZBHEVBGJKGFrAsQ7YLks9c02YOEQuzU1hjFL\n G6CP6F11HbakOLwDwlCzDvzamzNVMEtXIDUFuVMpn/MUERdZ30x4OS2sZld7rry3JJRJ\n +84Nu2FFrgsDxc/tIRJ8l6uWL4z5WUzGIvMzs4yCzQbOf+v4k9telaJaI4EIC9C6fIxD\n sw9pTAA5Xcy81MAjChhSCfc90WLGrrc/yB38o0YN+EyokhGGh0VsUmS3r4cbkmsXFkpK\n k9OlrtrPTlRdZ+zcj4WyfBBQ99YtOlTZc2awY46YP3x1hkOISZ3xMVElyTuVq8foo3mA\n 396w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775850864; x=1776455664;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=EuoKZZrJIA/hKCIvNS2NFNqHU7220n1eLUSWyy7IvJI=;\n b=smFeGNIbMEcOJPE6PqTSG40GGJHyVoZJPPCjgr2TrDX4rZcWe8J12rjB4uC8FCMz73\n EZk/8Oc+O5KuLVij35NQp66ipAfMfJPzjqS44/g6asCB6LlGfkcXH7P+lq7FDha59u95\n bAoM0L6xgaN7HXtUQ/p0Vvpnjg7AKevwtUV+IFHJpGG2ocGS9ETM8AQrHYiTmdYRQBfD\n Ckm/YM0kv6/P9ztNhbYnXc49hVrPDu0e258TOC/ylbIPEw7p6FV+IEijNYhVxi9n7CHD\n CGE8NWNGFy0L9J5xo019pNV92WObTua76URY6CLJC/THgIfIdcwqzUak7ojO2SuhVAT3\n QHvw==","X-Gm-Message-State":"AOJu0YxYhUSWpxWXt29OCuRsKu25cFU6xJtITVkrDV7zuG4WPeUZ6sKt\n RKILGTDWmShV3DMz4PJ2TrA0zPulseUqzzsfULtwRC5qXUf+DLrtEuIhKFTY4opd5pTVDWqKarT\n SE41tLQI=","X-Gm-Gg":"AeBDieujGLiF0rCmJzxvearRwbO9/FK6b40r0LtcDjVMl1EuVQKnIoKh2T0jAGGWaWs\n a0ZGJIWgMx+OCxoRoHQ0y4Ib18YTsuHuBlyEovccmBDVSbAUrbu24WSuhmwqF8Fi9yiDU0xQ7TS\n 9K9uSvDdcLgK0V5N8JkPR4PnLk4Caf4I266iY0xqEfMZxPVEV5HN1eAr7GHdlJ9eKWfnDLoB+9v\n t0AGIl9omMMONQ63CEPZCpomNQJ4E8JXSVIP3aY8RofGqGkzmZBV9oa31Z2uF18KenZnkMqKuVV\n aHo0TJzTVulpFmjr35xm9/nUZsJkButxMmqOYHV0cWaPEXzAqTByO2B0ttD4Pmb0dhNTaBsegeQ\n +nQVMAVqXd13ouzCgthFh0mJKOXOeiKTmLsFhNmkPo8dMg4XvXVJnG5DCwmuxnT9smYmomqEpLw\n 2n3K/NczIgMwOotM6XyH7ikS/rcFVeEsWotD+NcgtfftqiSRlDzjtLI1ruHDjrA9BxJSrCGjQX","X-Received":"by 2002:a05:600c:a109:b0:488:a977:8de with SMTP id\n 5b1f17b1804b1-488d6839866mr43608325e9.16.1775850863956;\n Fri, 10 Apr 2026 12:54:23 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Richard Henderson ,\n \"Dr. David Alan Gilbert\" ,\n Pierrick Bouvier , qemu-riscv@nongnu.org,\n Markus Armbruster , qemu-s390x@nongnu.org,\n kvm@vger.kernel.org, qemu-ppc@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= , Laurent Vivier ","Subject":"[PATCH v2 08/27] target/m68k: Replace target_monitor_defs ->\n SysemuCPUOps::monitor_defs","Date":"Fri, 10 Apr 2026 21:53:02 +0200","Message-ID":"<20260410195323.17937-9-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260410195323.17937-1-philmd@linaro.org>","References":"<20260410195323.17937-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32f;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32f.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Restrict m68k_monitor_defs[] to cpu.c, register it as\nSysemuCPUOps::monitor_defs hook, allowing to remove\nthe target_monitor_defs() method.\n\nSigned-off-by: Philippe Mathieu-Daudé \n---\n target/m68k/cpu.c | 18 ++++++++++++++++++\n target/m68k/monitor.c | 21 ---------------------\n 2 files changed, 18 insertions(+), 21 deletions(-)","diff":"diff --git a/target/m68k/cpu.c b/target/m68k/cpu.c\nindex d849a4a90fc..f704a6af613 100644\n--- a/target/m68k/cpu.c\n+++ b/target/m68k/cpu.c\n@@ -25,6 +25,7 @@\n \n #ifndef CONFIG_USER_ONLY\n #include \"migration/vmstate.h\"\n+#include \"monitor/hmp.h\"\n #endif\n \n #include \"cpu.h\"\n@@ -602,11 +603,28 @@ static const VMStateDescription vmstate_m68k_cpu = {\n },\n };\n \n+static const MonitorDef m68k_monitor_defs[] = {\n+ { \"ssp\", offsetof(CPUM68KState, sp[0]) },\n+ { \"usp\", offsetof(CPUM68KState, sp[1]) },\n+ { \"isp\", offsetof(CPUM68KState, sp[2]) },\n+ { \"sfc\", offsetof(CPUM68KState, sfc) },\n+ { \"dfc\", offsetof(CPUM68KState, dfc) },\n+ { \"urp\", offsetof(CPUM68KState, mmu.urp) },\n+ { \"srp\", offsetof(CPUM68KState, mmu.srp) },\n+ { \"dttr0\", offsetof(CPUM68KState, mmu.ttr[M68K_DTTR0]) },\n+ { \"dttr1\", offsetof(CPUM68KState, mmu.ttr[M68K_DTTR1]) },\n+ { \"ittr0\", offsetof(CPUM68KState, mmu.ttr[M68K_ITTR0]) },\n+ { \"ittr1\", offsetof(CPUM68KState, mmu.ttr[M68K_ITTR1]) },\n+ { \"mmusr\", offsetof(CPUM68KState, mmu.mmusr) },\n+ { NULL },\n+};\n+\n #include \"hw/core/sysemu-cpu-ops.h\"\n \n static const struct SysemuCPUOps m68k_sysemu_ops = {\n .has_work = m68k_cpu_has_work,\n .get_phys_page_debug = m68k_cpu_get_phys_page_debug,\n+ .monitor_defs = m68k_monitor_defs,\n };\n #endif /* !CONFIG_USER_ONLY */\n \ndiff --git a/target/m68k/monitor.c b/target/m68k/monitor.c\nindex be7411edca6..3e0df40a6b8 100644\n--- a/target/m68k/monitor.c\n+++ b/target/m68k/monitor.c\n@@ -21,24 +21,3 @@ void hmp_info_tlb(Monitor *mon, const QDict *qdict)\n \n dump_mmu(env1);\n }\n-\n-static const MonitorDef monitor_defs[] = {\n- { \"ssp\", offsetof(CPUM68KState, sp[0]) },\n- { \"usp\", offsetof(CPUM68KState, sp[1]) },\n- { \"isp\", offsetof(CPUM68KState, sp[2]) },\n- { \"sfc\", offsetof(CPUM68KState, sfc) },\n- { \"dfc\", offsetof(CPUM68KState, dfc) },\n- { \"urp\", offsetof(CPUM68KState, mmu.urp) },\n- { \"srp\", offsetof(CPUM68KState, mmu.srp) },\n- { \"dttr0\", offsetof(CPUM68KState, mmu.ttr[M68K_DTTR0]) },\n- { \"dttr1\", offsetof(CPUM68KState, mmu.ttr[M68K_DTTR1]) },\n- { \"ittr0\", offsetof(CPUM68KState, mmu.ttr[M68K_ITTR0]) },\n- { \"ittr1\", offsetof(CPUM68KState, mmu.ttr[M68K_ITTR1]) },\n- { \"mmusr\", offsetof(CPUM68KState, mmu.mmusr) },\n- { NULL },\n-};\n-\n-const MonitorDef *target_monitor_defs(void)\n-{\n- return monitor_defs;\n-}\n","prefixes":["v2","08/27"]}