{"id":2222152,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222152/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410195323.17937-11-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410195323.17937-11-philmd@linaro.org>","date":"2026-04-10T19:53:04","name":"[v2,10/27] monitor: Remove target_monitor_defs()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"95bd4d85af2ccdbf9b963509dac5ffc5d5dea6f1","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.1/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410195323.17937-11-philmd@linaro.org/mbox/","series":[{"id":499498,"url":"http://patchwork.ozlabs.org/api/1.1/series/499498/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499498","date":"2026-04-10T19:52:54","name":"monitor: Remove need of per-target handlers","version":2,"mbox":"http://patchwork.ozlabs.org/series/499498/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222152/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222152/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=TxmTe6/U;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsnbW0Z5Vz1yCv\n\tfor ; Sat, 11 Apr 2026 05:55:35 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBHwK-0001J2-C8; Fri, 10 Apr 2026 15:54:52 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wBHwB-00016Z-V7\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:54:44 -0400","from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wBHwA-0001aZ-80\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:54:43 -0400","by mail-wr1-x42b.google.com with SMTP id\n ffacd0b85a97d-43d23305225so1667229f8f.2\n for ; Fri, 10 Apr 2026 12:54:40 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d63de2a48sm10271471f8f.7.2026.04.10.12.54.37\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 10 Apr 2026 12:54:37 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775850878; x=1776455678; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=NZ5l/yASQ24ZYUVrEW0W1fOfIxn1pYjbKa7VNjc5dpE=;\n b=TxmTe6/UYCq9VPOZRRjhbAtXi5iamWZtPB5x07RlqrB9UFtuAXwCupkL/MtmofcLSj\n L6Sct+Vi+1kYmkAaXX9CvvUalEGf0Z5wivBKl8IdWdDFT/sLIKNpvaSqOyOgOUqVuyP9\n CLHUgQL7lh03SEPqghcaqOuvzAnOoXq1lB4va9l1lgZZdm9/GYbQX6zDsBad1nwuGKi1\n c41GKBKCEQqvx0IQYb3uiA6bxw7/RQ2RNyASFtqOIaf+R7xyDnaV1MWGIWQJWeN0m574\n bo19GhCFkPLMOHUta+eIg+BkaOSybnhFfRvJwsqt30Y6L5yLfNdXByr12JWgBl8sNBp+\n /TgA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775850878; x=1776455678;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=NZ5l/yASQ24ZYUVrEW0W1fOfIxn1pYjbKa7VNjc5dpE=;\n b=EtC51/AolYsdCyX5aDBMVdMn36YkoCPCDAhMjyHgNiU3MNRJi3rTbTMElCIITy1u1Q\n g/fIBhTazEBoVYzwTRYNxpkKQ0s9L9EHCb3B6/vtm75wGArX5vRFsc7J4l4fMafmtYiM\n oJ7hOg7N3zb5SvjziY2MPL8vYcr9cU06GuGN8qFZNaEYZqRGIZy7GXI4mr2BZkv7LX2Z\n dDhbSBy7ZVf2YypACgWqNbC9ZWJ2BBQVpScmR8hvhbxQ29AxrRTYmImV77BKgELh8e24\n Wbfvv/5lQyzR9RGsrUyPgGpKBUnBRgflpeYc2OvkBdcGGjxuy5+Dio4EyIPDEchhoy4x\n MWSw==","X-Gm-Message-State":"AOJu0YxvwXMwih3wB2NOMTZ5RjgrProEshx1Od1EP52BdVRbKiMGjsAV\n rn1wPxxPv7s1s0X34tWRjrNUxprs5iFBl2msFMpGsaGgZ3pMPM+2laIsyrLg8NvlT2/JJjJd98O\n JwFZxEMA=","X-Gm-Gg":"AeBDieuZ1edtGySxIp1HIb4E1FS5rtoX2dUA3t8/pPk/pBo81TwMoI+p1eQQrmD3Ol5\n jOVEfjFxvDEjLtETjsQVHcTuRRrz9G4FfnvEqhLFURxFO+z4tyaznc0Z7HqgQGEDnsU3cCAZjrT\n RvXvn3BBy5BUyP7VKWmrjZZk1G5KuySGcU/75OPHM2Em6x2RJ+97rvrUKeG+m2KLxwIAWgXCdi4\n mYLiwY1mQ7R5K8Kv1H6tMdKG4w+aUAwZnl5kWpS35xcyaj0o6Cr4WRdmF3/9uSvXI4pKhA9eRfk\n lm2xHx5z7AdBWadXoENHenydnBtga7dhZ9xhUMutyVH+LX/LeRaK2NU3Qmd0ZT4xZoT+2LWFmG0\n 8ktGW6FyDQBe2c6qJP/zxgspmLyjw5AQAvRRJBU8kINWSUVXAdICq/IBFtrlkv3Z/uTnJA255Dx\n VA+O4OZ9wroUFFrEVf2sQ1iCQVGqHKrMIZoaBHIojdlN2pLYrc5Uf1yqer3sucyE2zcEl9BBLM","X-Received":"by 2002:a5d:64c7:0:b0:43d:500a:1e5b with SMTP id\n ffacd0b85a97d-43d642da9e2mr7199206f8f.27.1775850878373;\n Fri, 10 Apr 2026 12:54:38 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Richard Henderson ,\n \"Dr. David Alan Gilbert\" ,\n Pierrick Bouvier , qemu-riscv@nongnu.org,\n Markus Armbruster , qemu-s390x@nongnu.org,\n kvm@vger.kernel.org, qemu-ppc@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= , Paolo Bonzini ","Subject":"[PATCH v2 10/27] monitor: Remove target_monitor_defs()","Date":"Fri, 10 Apr 2026 21:53:04 +0200","Message-ID":"<20260410195323.17937-11-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260410195323.17937-1-philmd@linaro.org>","References":"<20260410195323.17937-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::42b;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x42b.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"target_monitor_defs() is now only a dead stub. Remove as pointless.\n\nSigned-off-by: Philippe Mathieu-Daudé \n---\n include/monitor/hmp.h | 1 -\n monitor/hmp.c | 2 +-\n stubs/target-monitor-defs.c | 7 -------\n stubs/meson.build | 1 -\n 4 files changed, 1 insertion(+), 10 deletions(-)\n delete mode 100644 stubs/target-monitor-defs.c","diff":"diff --git a/include/monitor/hmp.h b/include/monitor/hmp.h\nindex 516089eb5c6..cabb2c55f8e 100644\n--- a/include/monitor/hmp.h\n+++ b/include/monitor/hmp.h\n@@ -23,7 +23,6 @@ struct MonitorDef {\n int64_t (*get_value)(Monitor *mon, const MonitorDef *md, int offset);\n };\n \n-const MonitorDef *target_monitor_defs(void);\n int target_get_monitor_def(CPUState *cs, const char *name, uint64_t *pval);\n \n CPUArchState *mon_get_cpu_env(Monitor *mon);\ndiff --git a/monitor/hmp.c b/monitor/hmp.c\nindex 6cf2f3e65ff..3d812ea3068 100644\n--- a/monitor/hmp.c\n+++ b/monitor/hmp.c\n@@ -1613,7 +1613,7 @@ static int get_monitor_def(Monitor *mon, int64_t *pval, const char *name)\n if (cs == NULL) {\n return -1;\n }\n- md = cs->cc->sysemu_ops->monitor_defs ?: target_monitor_defs();\n+ md = cs->cc->sysemu_ops->monitor_defs;\n if (md == NULL) {\n return -1;\n }\ndiff --git a/stubs/target-monitor-defs.c b/stubs/target-monitor-defs.c\ndeleted file mode 100644\nindex 0dd4cdb34f6..00000000000\n--- a/stubs/target-monitor-defs.c\n+++ /dev/null\n@@ -1,7 +0,0 @@\n-#include \"qemu/osdep.h\"\n-#include \"monitor/hmp.h\"\n-\n-const MonitorDef *target_monitor_defs(void)\n-{\n- return NULL;\n-}\ndiff --git a/stubs/meson.build b/stubs/meson.build\nindex 7189ff63ed5..10eb68ab55e 100644\n--- a/stubs/meson.build\n+++ b/stubs/meson.build\n@@ -75,7 +75,6 @@ if have_system\n endif\n stub_ss.add(files('kvm.c'))\n stub_ss.add(files('target-get-monitor-def.c'))\n- stub_ss.add(files('target-monitor-defs.c'))\n stub_ss.add(files('win32-kbd-hook.c'))\n stub_ss.add(files('xen-hw-stub.c'))\n stub_ss.add(files('monitor-arm-gic.c'))\n","prefixes":["v2","10/27"]}