{"id":2222143,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222143/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410195323.17937-4-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410195323.17937-4-philmd@linaro.org>","date":"2026-04-10T19:52:57","name":"[v2,03/27] monitor: Reduce target-specific methods further","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"daf681281650996044e52891a9f0893cd489fa3a","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.1/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410195323.17937-4-philmd@linaro.org/mbox/","series":[{"id":499498,"url":"http://patchwork.ozlabs.org/api/1.1/series/499498/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499498","date":"2026-04-10T19:52:54","name":"monitor: Remove need of per-target handlers","version":2,"mbox":"http://patchwork.ozlabs.org/series/499498/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222143/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222143/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=GUMEgppa;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsnZm5BsNz20HT\n\tfor ; Sat, 11 Apr 2026 05:54:56 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBHvO-000089-HE; Fri, 10 Apr 2026 15:53:54 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wBHvM-00006X-K2\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:53:52 -0400","from mail-wm1-x331.google.com ([2a00:1450:4864:20::331])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wBHvJ-0000l0-Dh\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:53:52 -0400","by mail-wm1-x331.google.com with SMTP id\n 5b1f17b1804b1-488d2079582so21379415e9.2\n for ; Fri, 10 Apr 2026 12:53:49 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488d681ea59sm28031745e9.14.2026.04.10.12.53.46\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 10 Apr 2026 12:53:46 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775850828; x=1776455628; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=laXD0bHOFLR+f7DqrbhiNwPQxGkoCRCAaO6RrZRP8L8=;\n b=GUMEgppa47NcUYh8fYDR+6RaXR238rb5oZB6jvJP+/1v0jP9xHu+OWIfyBdRHJ6KPJ\n Nb14n72Wjqhc00P1w23KgGAHtBC8NCRyczBfrnKIMonrJbW/+gwlpnQIXfAASAoWa74p\n i7IRhTICx/UMPFIdaA21DPA2aMtjn3XVpgQb8GY5O36uEXhJCEjoiiaq6XuQ2XcjleKl\n Et9Uu8luGD1rGWSTsJJKPvzzOWefkk+26RCKRGLDHroHhGK8lpWw/+PguBW5RNukpn+M\n 25ovuQZ5m2ulGnXJCYMiIkaNwojtiiYoFAqI95VC3DAnN5mGLjzcghRXVk+VXUCZT5Mm\n ajsQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775850828; x=1776455628;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=laXD0bHOFLR+f7DqrbhiNwPQxGkoCRCAaO6RrZRP8L8=;\n b=efRj5yX+0lBIAgC9FO/SOsfVACEDpughCi3M2lMA7d6cet/ATMoQ75ozH9y5Xh3kAa\n FqruDvbTIwcky++qII/91+xJnqzkWrrHz78U+fGQRLvULu3EPkrBHIh/KPOeRBKenOHU\n xo6CXDvSVtp8B2XFCRcMEJnazd2CY3VLS1ecasPNbq5KQUVMveR2xLb54CgxZcWofS5F\n btsi+J5OKEiJ/D/mZsV3MMVsLJHhWbvvwFWpWaaUhmD+8TOMV4VzvGXWMxGZibFhyPaQ\n rN+4wRakIh5w87kZgxBbVSZDpCrQqPSdjvhFvKj7gwOrCP8bUQAZTFjzMpoK0VPudd0U\n s2aA==","X-Gm-Message-State":"AOJu0YxaWvLTn/5oQ6WHWF5qvItqX4OyGTA4WOMC7P4q/WbjogwhL1Kq\n 0+yvU7qzqd5tuf15bY2isw13xmih+I49MRIPHPgayawFpFz4xNUKr+4pc6cGz2c5BRVm+NMUS3y\n iMFZGqzU=","X-Gm-Gg":"AeBDieuBv6yrBMvw/ULw08fjgoWBRGb41gbvImFkQoqJrArEo0lFg52rR913FmRVfG7\n anTXHum1LQkGhFTmFYWW9DG7ULk3SUVVFhVr5xRa3Z4LC9vM2wpLNo58wBJkh0HZKCuTICowDOR\n jQOA63JvmRPRky0D7rW6AlmxsphCB0uN3gF51wLLcuCvdOdgCOm8qfZ2G1P31yC8FUDbuUOvWrm\n r0o4/3tQw5NAaSBkDcb5laJbr0nkOHiu1mkPcf+NoDhXemKWhDXCef1O4rjZx9CgBN0co66tLqA\n 8dqIjxsvoCUW/uc37SKNnxkitEvMk3BGu+dlKzUelZLlKj5KBOHPaEgLgAJBGITAm8+3re5Knje\n aHgR4Asnsf+R52LqCQPNu99FOaqBzjtGzMaCTqTa0l/6pXmRjzv1Q9fFPJw23AcI5uJmQuGS2zD\n C1xUpMgEMVdc3sy91FaHVoTn8t1fM1MGc1XCNDKA+p1b6Cz6ZChSZ1nopz/8H+P1T7J33fYKTk","X-Received":"by 2002:a05:600c:a411:b0:488:af48:af11 with SMTP id\n 5b1f17b1804b1-488d67c749emr47503115e9.1.1775850827230;\n Fri, 10 Apr 2026 12:53:47 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Richard Henderson ,\n \"Dr. David Alan Gilbert\" ,\n Pierrick Bouvier , qemu-riscv@nongnu.org,\n Markus Armbruster , qemu-s390x@nongnu.org,\n kvm@vger.kernel.org, qemu-ppc@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= ","Subject":"[PATCH v2 03/27] monitor: Reduce target-specific methods further","Date":"Fri, 10 Apr 2026 21:52:57 +0200","Message-ID":"<20260410195323.17937-4-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260410195323.17937-1-philmd@linaro.org>","References":"<20260410195323.17937-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::331;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"get_monitor_def() doesn't use any target-specific declaration\nanymore, move it to hmp.c to compile it once.\n\nSigned-off-by: Philippe Mathieu-Daudé \nReviewed-by: Dr. David Alan Gilbert \n---\n monitor/monitor-internal.h | 1 -\n monitor/hmp-target.c | 39 -------------------------------------\n monitor/hmp.c | 40 ++++++++++++++++++++++++++++++++++++++\n 3 files changed, 40 insertions(+), 40 deletions(-)","diff":"diff --git a/monitor/monitor-internal.h b/monitor/monitor-internal.h\nindex feca111ae31..3ecd394ecf6 100644\n--- a/monitor/monitor-internal.h\n+++ b/monitor/monitor-internal.h\n@@ -181,7 +181,6 @@ void monitor_data_destroy_qmp(MonitorQMP *mon);\n void coroutine_fn monitor_qmp_dispatcher_co(void *data);\n void qmp_dispatcher_co_wake(void);\n \n-int get_monitor_def(Monitor *mon, int64_t *pval, const char *name);\n void handle_hmp_command(MonitorHMP *mon, const char *cmdline);\n int hmp_compare_cmd(const char *name, const char *list);\n \ndiff --git a/monitor/hmp-target.c b/monitor/hmp-target.c\nindex b9b79e8e927..c840ae5f0a2 100644\n--- a/monitor/hmp-target.c\n+++ b/monitor/hmp-target.c\n@@ -23,7 +23,6 @@\n */\n \n #include \"qemu/osdep.h\"\n-#include \"qemu/target-info.h\"\n #include \"monitor-internal.h\"\n #include \"monitor/qdev.h\"\n #include \"net/slirp.h\"\n@@ -61,44 +60,6 @@ HMPCommand *hmp_cmds_for_target(bool info_command)\n return info_command ? hmp_info_cmds : hmp_cmds;\n }\n \n-/*\n- * Set @pval to the value in the register identified by @name.\n- * return 0 if OK, -1 if not found\n- */\n-int get_monitor_def(Monitor *mon, int64_t *pval, const char *name)\n-{\n- const MonitorDef *md = target_monitor_defs();\n- CPUState *cs = mon_get_cpu(mon);\n- void *ptr;\n- uint64_t tmp = 0;\n- int ret;\n-\n- if (cs == NULL || md == NULL) {\n- return -1;\n- }\n-\n- for(; md->name != NULL; md++) {\n- if (hmp_compare_cmd(name, md->name)) {\n- if (md->get_value) {\n- int64_t val = md->get_value(mon, md, md->offset);\n- *pval = target_long_bits() == 32 ? (int32_t)val : val;\n- } else {\n- CPUArchState *env = mon_get_cpu_env(mon);\n- ptr = (uint8_t *)env + md->offset;\n- *pval = *(int32_t *)ptr;\n- }\n- return 0;\n- }\n- }\n-\n- ret = target_get_monitor_def(cs, name, &tmp);\n- if (!ret) {\n- *pval = target_long_bits() == 32 ? (int32_t)tmp : tmp;\n- }\n-\n- return ret;\n-}\n-\n static int\n compare_mon_cmd(const void *a, const void *b)\n {\ndiff --git a/monitor/hmp.c b/monitor/hmp.c\nindex 0e5913fabb1..20ba1e62988 100644\n--- a/monitor/hmp.c\n+++ b/monitor/hmp.c\n@@ -355,6 +355,8 @@ static bool gdb_get_register(Monitor *mon, int64_t *pval, const char *name)\n static const char *pch;\n static sigjmp_buf expr_env;\n \n+static int get_monitor_def(Monitor *mon, int64_t *pval, const char *name);\n+\n static G_NORETURN G_GNUC_PRINTF(2, 3)\n void expr_error(Monitor *mon, const char *fmt, ...)\n {\n@@ -1595,3 +1597,41 @@ void monitor_register_hmp_info_hrt(const char *name,\n }\n g_assert_not_reached();\n }\n+\n+/*\n+ * Set @pval to the value in the register identified by @name.\n+ * return 0 if OK, -1 if not found\n+ */\n+static int get_monitor_def(Monitor *mon, int64_t *pval, const char *name)\n+{\n+ const MonitorDef *md = target_monitor_defs();\n+ CPUState *cs = mon_get_cpu(mon);\n+ void *ptr;\n+ uint64_t tmp = 0;\n+ int ret;\n+\n+ if (cs == NULL || md == NULL) {\n+ return -1;\n+ }\n+\n+ for (; md->name != NULL; md++) {\n+ if (hmp_compare_cmd(name, md->name)) {\n+ if (md->get_value) {\n+ int64_t val = md->get_value(mon, md, md->offset);\n+ *pval = target_long_bits() == 32 ? (int32_t)val : val;\n+ } else {\n+ CPUArchState *env = mon_get_cpu_env(mon);\n+ ptr = (uint8_t *)env + md->offset;\n+ *pval = *(int32_t *)ptr;\n+ }\n+ return 0;\n+ }\n+ }\n+\n+ ret = target_get_monitor_def(cs, name, &tmp);\n+ if (!ret) {\n+ *pval = target_long_bits() == 32 ? (int32_t)tmp : tmp;\n+ }\n+\n+ return ret;\n+}\n","prefixes":["v2","03/27"]}