{"id":2222134,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222134/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-63-231416f76dc3@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410-qemu-vnc-v2-63-231416f76dc3@redhat.com>","date":"2026-04-10T19:19:25","name":"[v2,63/67] ui: extract common sources into a static library","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"eb10e37e9f62131f256e9d152dffa8ee58d44886","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-63-231416f76dc3@redhat.com/mbox/","series":[{"id":499494,"url":"http://patchwork.ozlabs.org/api/1.1/series/499494/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494","date":"2026-04-10T19:18:23","name":"ui: add standalone VNC server over D-Bus","version":2,"mbox":"http://patchwork.ozlabs.org/series/499494/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222134/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222134/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=FFZILIJ+;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsn0N30Hqz1yGb\n\tfor ; Sat, 11 Apr 2026 05:28:36 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBHTt-0007jr-B0; Fri, 10 Apr 2026 15:25:29 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHTk-0007VY-Ja\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:25:23 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHTh-000349-JY\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:25:19 -0400","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-168-pSlA6PRhNdi2f6zGO4edNQ-1; Fri,\n 10 Apr 2026 15:25:13 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 589491956094; Fri, 10 Apr 2026 19:25:12 +0000 (UTC)","from localhost (unknown [10.44.22.4])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id D68E61800357; Fri, 10 Apr 2026 19:25:10 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775849116;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Gi6lAlNnlbIZcDiuiqDaVlawki8cAOl1cfYmhR6nZ90=;\n b=FFZILIJ+QTYxjK0RjiyS3nh6FlJRcZmUi2FdTjeT9k7qMFQQG8Cu0AcotfyjzWeTwMgjZj\n mpJi72W+/R8X4xDHd9tJ1hMfM2FikCY4736ntD6tfLtGZagvOk+EE7C7jyKLxJXOszLzwY\n YF4hGnIjaS+A0l+m9ypSvwRSMknkXFQ=","X-MC-Unique":"pSlA6PRhNdi2f6zGO4edNQ-1","X-Mimecast-MFC-AGG-ID":"pSlA6PRhNdi2f6zGO4edNQ_1775849112","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Fri, 10 Apr 2026 23:19:25 +0400","Subject":"[PATCH v2 63/67] ui: extract common sources into a static library","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260410-qemu-vnc-v2-63-231416f76dc3@redhat.com>","References":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","In-Reply-To":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=4428;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=rWym6d5xAr+8hbLq1UtEkGuKDuN4vQzF9UwSMIl3IIU=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0XcTzAeaVVckiudqsLO94pYGgLHT7ElSkMU\n sGsRjZMKPmJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNFwAKCRDa6OEJdZac\n 5ffHD/wKpNb4WTsLXGqXHg/Uy67+7gXKbur/rAY9XANpG+JTW184qxeMT1zLOE4vknNU/NWQJIJ\n P05TMxtxbs32Y19rDdl1sEhSdheaTi8s83o36HpBaziuAYwHl1XPo/+vXcI+JeWShV/p6b3sunm\n gy6B1m8OHfkUi/9zUIDAhzzGNj9TlkWeJJL5/on78jCVzhGrcTiqA5yeGMp/5xZa9BemIcniKJ0\n QSb08lEVHfo5CDktIODASgC0dYNXJHqHHkELTPCGXWxKUvDppvBLoLXJHDDZro5B/+XZvFAthGZ\n eul5sDQXBUsbfQWRqjzN3aePMAcHWmbG3OEktuq8yg3jrpSWakC2sAu0mdLRDNQOmykj2XAPlLp\n svAk4iXDMeMzMeJJERfWdGfPwIvdZQ7gdootnVbVXv7QMppNwCeEL8xdhNVNUzOHVQGZ82J20Mb\n eu0hCAg9avOD1zE+JhJb1Yv9gmNTYXt8/2f+VTADn2CvHSRFOyPKHe3FYe/IV4aOYLbicIBTvmq\n kXshxO0DnPLUUeZg2CxPHvov1h48mrCLDH0pko6cDQSdb14UaaYg45BZQc9mFkTSHtj37mgAfcD\n wZe3ngBFlaB13sHshzqV+uWi4MpPuEQYtUnuHX2yjXpE6KCSAgWejRomDbeR8bax8OtDFUSjCu4\n vsqNS03yA3Gt97g==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"7","X-Spam_score":"0.7","X-Spam_bar":"/","X-Spam_report":"(0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Move clipboard, cursor, display-surface, input-keymap, kbd-state,\nkeymaps, vt100, and qemu-pixman into a separate static library 'qemuui'.\nThis allows these common UI sources to be linked by targets outside of\nthe system emulator build, such as standalone VNC or D-Bus display\nbinaries.\n\nkeymaps generation has to be moved earlier, so that header dependency\nare resolved first.\n\nThe library objects are re-exported via a dependency so existing\nsystem_ss consumers are unaffected.\n\nReviewed-by: Philippe Mathieu-Daudé \nSigned-off-by: Marc-André Lureau \n---\n ui/meson.build | 103 ++++++++++++++++++++++++++++++---------------------------\n 1 file changed, 55 insertions(+), 48 deletions(-)","diff":"diff --git a/ui/meson.build b/ui/meson.build\nindex f959f8972b5..c3f4d03eaf8 100644\n--- a/ui/meson.build\n+++ b/ui/meson.build\n@@ -1,25 +1,67 @@\n-system_ss.add(pixman)\n+keymaps = [\n+ ['atset1', 'qcode'],\n+ ['linux', 'qcode'],\n+ ['qcode', 'atset1'],\n+ ['qcode', 'atset2'],\n+ ['qcode', 'atset3'],\n+ ['qcode', 'linux'],\n+ ['qcode', 'qnum'],\n+ ['qcode', 'sun'],\n+ ['qnum', 'qcode'],\n+ ['usb', 'qcode'],\n+ ['win32', 'qcode'],\n+ ['x11', 'qcode'],\n+ ['xorgevdev', 'qcode'],\n+ ['xorgkbd', 'qcode'],\n+ ['xorgxquartz', 'qcode'],\n+ ['xorgxwin', 'qcode'],\n+ ['osx', 'qcode'],\n+]\n+\n+if have_system or xkbcommon.found()\n+ keycodemapdb_proj = subproject('keycodemapdb', required: true)\n+ foreach e : keymaps\n+ output = 'input-keymap-@0@-to-@1@.c.inc'.format(e[0], e[1])\n+ genh += custom_target(output,\n+ output: output,\n+ capture: true,\n+ input: keycodemapdb_proj.get_variable('keymaps_csv'),\n+ command: [python, keycodemapdb_proj.get_variable('keymap_gen').full_path(),\n+ 'code-map', '--lang', 'glib2',\n+ '--varname', 'qemu_input_map_@0@_to_@1@'.format(e[0], e[1]),\n+ '@INPUT0@', e[0], e[1]])\n+ endforeach\n+endif\n+\n+libui_sources = files(\n+ 'clipboard.c',\n+ 'console.c',\n+ 'cursor.c',\n+ 'dmabuf.c',\n+ 'display-surface.c',\n+ 'input-keymap.c',\n+ 'kbd-state.c',\n+ 'keymaps.c',\n+ 'qemu-pixman.c',\n+ 'vgafont.c',\n+ )\n+if pixman.found()\n+ libui_sources += files('cp437.c', 'vt100.c')\n+endif\n+libui = static_library('qemuui', libui_sources + genh,\n+ dependencies: [pixman],\n+ build_by_default: false)\n+ui = declare_dependency(objects: libui.extract_all_objects(recursive: false), dependencies: [pixman])\n system_ss.add(png)\n system_ss.add(files(\n- 'clipboard.c',\n- 'console.c',\n- 'cp437.c',\n- 'cursor.c',\n- 'display-surface.c',\n- 'dmabuf.c',\n- 'input-keymap.c',\n 'input-legacy.c',\n 'input-barrier.c',\n 'input.c',\n- 'kbd-state.c',\n- 'keymaps.c',\n- 'qemu-pixman.c',\n 'ui-hmp-cmds.c',\n 'ui-qmp-cmds.c',\n 'util.c',\n- 'vgafont.c',\n- 'vt100.c',\n ))\n+system_ss.add(ui)\n system_ss.add(when: pixman, if_true: files('console-vc.c'), if_false: files('console-vc-stubs.c'))\n if dbus_display\n system_ss.add(files('dbus-module.c'))\n@@ -151,41 +193,6 @@ if spice.found()\n endif\n endif\n \n-keymaps = [\n- ['atset1', 'qcode'],\n- ['linux', 'qcode'],\n- ['qcode', 'atset1'],\n- ['qcode', 'atset2'],\n- ['qcode', 'atset3'],\n- ['qcode', 'linux'],\n- ['qcode', 'qnum'],\n- ['qcode', 'sun'],\n- ['qnum', 'qcode'],\n- ['usb', 'qcode'],\n- ['win32', 'qcode'],\n- ['x11', 'qcode'],\n- ['xorgevdev', 'qcode'],\n- ['xorgkbd', 'qcode'],\n- ['xorgxquartz', 'qcode'],\n- ['xorgxwin', 'qcode'],\n- ['osx', 'qcode'],\n-]\n-\n-if have_system or xkbcommon.found()\n- keycodemapdb_proj = subproject('keycodemapdb', required: true)\n- foreach e : keymaps\n- output = 'input-keymap-@0@-to-@1@.c.inc'.format(e[0], e[1])\n- genh += custom_target(output,\n- output: output,\n- capture: true,\n- input: keycodemapdb_proj.get_variable('keymaps_csv'),\n- command: [python, keycodemapdb_proj.get_variable('keymap_gen').full_path(),\n- 'code-map', '--lang', 'glib2',\n- '--varname', 'qemu_input_map_@0@_to_@1@'.format(e[0], e[1]),\n- '@INPUT0@', e[0], e[1]])\n- endforeach\n-endif\n-\n subdir('shader')\n \n if have_system\n","prefixes":["v2","63/67"]}