{"id":2222132,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222132/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-43-231416f76dc3@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410-qemu-vnc-v2-43-231416f76dc3@redhat.com>","date":"2026-04-10T19:19:05","name":"[v2,43/67] ui/keymaps: introduce kbd_layout_free()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f02a9b3b60c341895005c51fdd2e52d0257587c6","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-43-231416f76dc3@redhat.com/mbox/","series":[{"id":499494,"url":"http://patchwork.ozlabs.org/api/1.1/series/499494/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494","date":"2026-04-10T19:18:23","name":"ui: add standalone VNC server over D-Bus","version":2,"mbox":"http://patchwork.ozlabs.org/series/499494/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222132/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222132/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=LtPwRa2i;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsn0J4d7mz1yGb\n\tfor ; Sat, 11 Apr 2026 05:28:32 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBHRn-0005lE-5m; Fri, 10 Apr 2026 15:23:19 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHRl-0005kl-H9\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:23:17 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHRk-00023Z-5M\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:23:17 -0400","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-240-Nq7hokqPO8yqsCO9t17kdQ-1; Fri,\n 10 Apr 2026 15:23:14 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id A104718002E7\n for ; Fri, 10 Apr 2026 19:23:13 +0000 (UTC)","from localhost (unknown [10.44.22.4])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 8F02B3000C16; Fri, 10 Apr 2026 19:23:11 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775848995;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=thtgrXJ52vS/oWAHRG9bnZ6YV3gy9fKuuRW+1nnw0yw=;\n b=LtPwRa2iQorafqWnZlHtHCxRohFJfIvTAmYaWCTF/0Icm2yxtz+v8GOHHkCX+madsHN4jL\n wrFbaMcvJyRzJvqEuUOpveC4GBU7ca55ENb6LRcBlVZ8TB8ufu8y4fsYOIQBBNUw83HARv\n jXJ8JNxaFq3slFYI6teJoN3O9ZFcV8o=","X-MC-Unique":"Nq7hokqPO8yqsCO9t17kdQ-1","X-Mimecast-MFC-AGG-ID":"Nq7hokqPO8yqsCO9t17kdQ_1775848993","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Fri, 10 Apr 2026 23:19:05 +0400","Subject":"[PATCH v2 43/67] ui/keymaps: introduce kbd_layout_free()","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260410-qemu-vnc-v2-43-231416f76dc3@redhat.com>","References":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","In-Reply-To":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1687;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=iQh+Fm1P/evY7D8sUcJsQUp91gqqVpdcJuZbaqvuho8=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0WM1eIXQjibSxb5CStcoqC4XscLDaHWGLOX\n Vwrb8PwLi6JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNFgAKCRDa6OEJdZac\n 5a3mD/9J/chsJjbNnz6qHmGS7Clf6oiRmlome4WLpxIFMWTdgrCCa/hxgsdg6PTqqNl7TKYispO\n heSzVzM1OK0883VBSAymnB7sR6LbDMN69y7EDopzVYniXEUvLfG7l6K3+3Ino7eVz2ldKwg3Gmy\n +QL8dVFKKj5xHfz7HIGik98Wav/vKs5FKIof1HfjkJ2HgBjiCbsd8TPikbMeHSWTQ2jIxWbPGbg\n Q2VA3kood64IlhndzUqsvh8nNiV/Z7wOWsod55KNp6fwEmQvaecglLDz/+5TqFk2fDRiAdbMJsO\n t+CnFGrTeR2Ah1Wk2sRZUZPIXXTmJDHn2YcITDqwsH0SdzafnsBMrvfwMqcg0F852OXGoZlsBBt\n SGVbdXdmxGfJQcn3B3hPLQBM1hN9WYWiUmpehadweObSAafiKmKee8Wjus0K4K8O3jEuzGcVtvQ\n +6LYqkWm68N90nsKmxG2Vp9803tA0/KfyLQi/ceTiSKw2tZ+8L5jBXR4RK8R+xaHQoars1lVB7C\n c1t9XnT5MfuhVrmHYD0icCqaT9QLfYgyh5bWQGKpI77Bi6Gl6EhA40Q85aXK2DRb+YSoEuy9FjT\n Qld2GyNNPbfI0lJvMExDriN3wviO1sAsqLg5/vS9nkZIOmpVk7Z147zFUN4+tPgjdDiJXSQ0PQ4\n huxHG7OwUhNw8Sw==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Enable callers to properly tear down keyboard layouts.\n\nReviewed-by: Marc-André Lureau \n---\n ui/keymaps.h | 1 +\n ui/keymaps.c | 13 ++++++++++---\n 2 files changed, 11 insertions(+), 3 deletions(-)","diff":"diff --git a/ui/keymaps.h b/ui/keymaps.h\nindex 3d52c0882a1..e8917e56404 100644\n--- a/ui/keymaps.h\n+++ b/ui/keymaps.h\n@@ -54,6 +54,7 @@ typedef struct kbd_layout_t kbd_layout_t;\n \n kbd_layout_t *init_keyboard_layout(const name2keysym_t *table,\n const char *language, Error **errp);\n+void kbd_layout_free(kbd_layout_t *k);\n int keysym2scancode(kbd_layout_t *k, int keysym,\n QKbdState *kbd, bool down);\n int keycode_is_keypad(kbd_layout_t *k, int keycode);\ndiff --git a/ui/keymaps.c b/ui/keymaps.c\nindex 2359dbfe7e6..d1b3f43dc8a 100644\n--- a/ui/keymaps.c\n+++ b/ui/keymaps.c\n@@ -178,6 +178,14 @@ out:\n return ret;\n }\n \n+void kbd_layout_free(kbd_layout_t *k)\n+{\n+ if (!k) {\n+ return;\n+ }\n+ g_hash_table_unref(k->hash);\n+ g_free(k);\n+}\n \n kbd_layout_t *init_keyboard_layout(const name2keysym_t *table,\n const char *language, Error **errp)\n@@ -185,10 +193,9 @@ kbd_layout_t *init_keyboard_layout(const name2keysym_t *table,\n kbd_layout_t *k;\n \n k = g_new0(kbd_layout_t, 1);\n- k->hash = g_hash_table_new(NULL, NULL);\n+ k->hash = g_hash_table_new_full(NULL, NULL, NULL, g_free);\n if (parse_keyboard_layout(k, table, language, errp) < 0) {\n- g_hash_table_unref(k->hash);\n- g_free(k);\n+ kbd_layout_free(k);\n return NULL;\n }\n return k;\n","prefixes":["v2","43/67"]}