{"id":2222131,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222131/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-38-231416f76dc3@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410-qemu-vnc-v2-38-231416f76dc3@redhat.com>","date":"2026-04-10T19:19:00","name":"[v2,38/67] ui: minor code simplification","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"4f95edd7ddba4816b20454343c0fded009d8d01f","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-38-231416f76dc3@redhat.com/mbox/","series":[{"id":499494,"url":"http://patchwork.ozlabs.org/api/1.1/series/499494/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494","date":"2026-04-10T19:18:23","name":"ui: add standalone VNC server over D-Bus","version":2,"mbox":"http://patchwork.ozlabs.org/series/499494/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222131/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222131/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=MMGEdqjE;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsn0C4yfSz1yGb\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 11 Apr 2026 05:28:25 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wBHRL-0005Cx-O9; Fri, 10 Apr 2026 15:22:51 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wBHRJ-0005CU-1C\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:22:49 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wBHRH-00020W-Nw\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:22:48 -0400","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-562-rd7g0PCLNM2XPBRpf2ACVg-1; Fri,\n 10 Apr 2026 15:22:45 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id B82FD1956095; Fri, 10 Apr 2026 19:22:44 +0000 (UTC)","from localhost (unknown [10.44.22.4])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 684E6180057F; Fri, 10 Apr 2026 19:22:42 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775848967;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Y6txHtHza4oPO6jN+3NWocTvhcHQbFK0yWPa0mHLVQk=;\n b=MMGEdqjEP+MT/li2ajN+Cz/pJZi1xaATBy6lk8cCHdF1CVHXqb4u/WkN9vkxNd9ebj8Wae\n plZz64lTlj7bu0RKZFqmg5boX+3hHGAx5xJ1bunarR5jqomRygPmZS+Fv8aeuAlMkTTLvk\n vOU7LJ0I/As8tkvhZuXoWBrr2SCX1r8=","X-MC-Unique":"rd7g0PCLNM2XPBRpf2ACVg-1","X-Mimecast-MFC-AGG-ID":"rd7g0PCLNM2XPBRpf2ACVg_1775848964","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>","Date":"Fri, 10 Apr 2026 23:19:00 +0400","Subject":"[PATCH v2 38/67] ui: minor code simplification","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260410-qemu-vnc-v2-38-231416f76dc3@redhat.com>","References":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","In-Reply-To":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1849;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=woJUhrs5y76Ek6vAQ8nlLqeubW55veqdmpH8rHOvF60=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0Vf0b6sNiBc2Vp3A5w+FOBQY8dKF3l1XwXr\n OuCCCMf3siJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNFQAKCRDa6OEJdZac\n 5QhgD/9unmznd4NhfKdIDr2UrlyA3qhKfdkRU0fmU6ptVDUGGt5c865knSApLXR5mQgQVkqoTsf\n YHkScTCzc07M+GrGoGuu6H8gc2g7fbOYZDRQNYIm6m1MHhK70iDl+XU3PVBIQts/Oc4FueELTcH\n C3GN2WMHMI+I4Aw8niBLnCrwtIvbfUEpyfCxpOf97THuLb2c1Js+NSsRp19gNzZZCLxhY1icH6g\n C67deXjVjMtJGXZNfRGiJMoJKXdGuSpxnp3NyZlV83HB3DBlVeAjVdeSDGVQHsvmeApyGfgRlFf\n eWSyJbJbum/quXj86kab3gRWLTETV8Iboz1aoHLaqsXdqtf24z8N4XGSL1uJp8Ax8oiUtF0nki/\n HFEZFtK4LAO0rYLrqsRPLjRxkjfR08/5TGzlwPI59uxk32LXbsEv5F2JxItr+qsCaJINzYYjWEC\n QbKW636SaN6Kb0mGWY7fCtiSk6YzWWkpWiS/vCQ7UbYJXBWXpNPR5nePWM2SnC8qaWXtXjeWzj/\n jkrRkwUExb4xw/f8z0l8PF7iryk+BsBEcuLJEC6qd9Zsx7Rw3lgKLkGQHrs9LNl3JWkcddsNNTB\n 3lh8NvOxekGqPR6rWtfcIntd8SlgEsKIWwN6259HJmk1FF8yABaEV19xMmNEchQwlyCzBRKw7tD\n +CuXp30IL95HVGg==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"7","X-Spam_score":"0.7","X-Spam_bar":"/","X-Spam_report":"(0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Drop memset() usage.\n\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n ui/sdl2.c | 8 ++++----\n ui/vnc.c  | 6 ++----\n 2 files changed, 6 insertions(+), 8 deletions(-)","diff":"diff --git a/ui/sdl2.c b/ui/sdl2.c\nindex aaaede56e0e..30e0042fe29 100644\n--- a/ui/sdl2.c\n+++ b/ui/sdl2.c\n@@ -600,10 +600,10 @@ static void handle_windowevent(SDL_Event *ev)\n     switch (ev->window.event) {\n     case SDL_WINDOWEVENT_RESIZED:\n         {\n-            QemuUIInfo info;\n-            memset(&info, 0, sizeof(info));\n-            info.width = ev->window.data1;\n-            info.height = ev->window.data2;\n+            QemuUIInfo info = {\n+                .width = ev->window.data1,\n+                .height = ev->window.data2,\n+            };\n             dpy_set_ui_info(scon->dcl.con, &info, true);\n         }\n         sdl2_redraw(scon);\ndiff --git a/ui/vnc.c b/ui/vnc.c\nindex 4aa446a48d7..9c8fe280bc9 100644\n--- a/ui/vnc.c\n+++ b/ui/vnc.c\n@@ -43,6 +43,7 @@\n #include \"qapi/qapi-events-ui.h\"\n #include \"qapi/error.h\"\n #include \"qapi/qapi-commands-ui.h\"\n+#include \"ui/console.h\"\n #include \"ui/input.h\"\n #include \"crypto/hash.h\"\n #include \"crypto/tlscreds.h\"\n@@ -2638,10 +2639,7 @@ static int protocol_client_msg(VncState *vs, uint8_t *data, size_t len)\n \n         trace_vnc_msg_client_set_desktop_size(vs, vs->ioc, w, h, screens);\n         if (dpy_ui_info_supported(vs->vd->dcl.con)) {\n-            QemuUIInfo info;\n-            memset(&info, 0, sizeof(info));\n-            info.width = w;\n-            info.height = h;\n+            QemuUIInfo info = { .width = w, .height = h };\n             dpy_set_ui_info(vs->vd->dcl.con, &info, false);\n             vnc_desktop_resize_ext(vs, 4 /* Request forwarded */);\n         } else {\n","prefixes":["v2","38/67"]}