{"id":2222127,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222127/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-47-231416f76dc3@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410-qemu-vnc-v2-47-231416f76dc3@redhat.com>","date":"2026-04-10T19:19:09","name":"[v2,47/67] ui/vnc: vnc_display_init() and vnc_display_open() return bool","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"fa6e2ac3f4d4bd368c25058c011583df2319fe97","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-47-231416f76dc3@redhat.com/mbox/","series":[{"id":499494,"url":"http://patchwork.ozlabs.org/api/1.1/series/499494/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494","date":"2026-04-10T19:18:23","name":"ui: add standalone VNC server over D-Bus","version":2,"mbox":"http://patchwork.ozlabs.org/series/499494/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222127/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222127/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=KW/SNFyo;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsmzN6T5cz1yGb\n\tfor ; Sat, 11 Apr 2026 05:27:44 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBHSA-0006Jr-4e; Fri, 10 Apr 2026 15:23:42 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHS8-0006DW-VJ\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:23:40 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHS7-00028E-Ct\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:23:40 -0400","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-626-xH-Xz9-2P1-k8t1AG7xHZg-1; Fri,\n 10 Apr 2026 15:23:37 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id C086F195608F\n for ; Fri, 10 Apr 2026 19:23:36 +0000 (UTC)","from localhost (unknown [10.44.22.4])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id A4C7D19560AB; Fri, 10 Apr 2026 19:23:35 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775849018;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=AaYgLyQHGS1El8i7WXeapVRA3A7DlDOzohvzbOUY51A=;\n b=KW/SNFyo+e7Lbtn0DQvL1YRow9cvYDQ+lK4OEYJBfTLn54k1QE1cTdhFyp+Xe6VsCZygyJ\n uZxR9ZOomEipraVzg6mOkG7xz+zG0hFovVkrEn77UoPZExO2vQ1iFwqMXZbxEpzCzXldUJ\n LDFLuFPBD3T4VQsIUK+E0/KkqbVYiMU=","X-MC-Unique":"xH-Xz9-2P1-k8t1AG7xHZg-1","X-Mimecast-MFC-AGG-ID":"xH-Xz9-2P1-k8t1AG7xHZg_1775849016","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Fri, 10 Apr 2026 23:19:09 +0400","Subject":"[PATCH v2 47/67] ui/vnc: vnc_display_init() and vnc_display_open()\n return bool","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260410-qemu-vnc-v2-47-231416f76dc3@redhat.com>","References":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","In-Reply-To":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=3270;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=hnN7DWHiJasepbkzKlsPFEQRnAxLd59i6FLsvNgF744=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0W7noNxUG+0zIoAuAo5Ca5DgUU87qDif7UG\n ku+GZ4sRH2JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNFgAKCRDa6OEJdZac\n 5XUwD/oCVQ0iGXLZecRKNKPkxwCrNPiUSDJEdHw6FybDX0rO/M20AaAtlFQ230o+bmRJRTYNQRY\n 8rC2gtNVwsbwLgWJqQQOEKiVAfH1zcPt5Et6fIQ23WU0Ns6yJ26EomwTJa5RfpGkLt1GCYICTmG\n AeBj3FbHTtRhlChdTrUwYHoAqiSh0qV2SDhGB+GZDRSGr1kGIFr/+CtwEsIy6hKze1bxUbxvmyi\n thqmg4D6a9GXQvgFUB7xe+UiE/0/7CjXnvR4VKy+dSlSVs4DdEmIHdQ+AC8+U8wzA8zLrj5jSHy\n ySEq8FXUsrHf5TXVI5A3g8ZmsjSr6QX8uOhWnzKApzXKsBZ5PTSc21pyZeh1iUDRvAeP9unKNaV\n bKrAkrVqiOtbWz9HatihMloX/V3CW7IKfn3RTn/+ebCmepKDhQS1SyYUpvEjWkNrKokyoexANVa\n alEzA2DIMnAL2HQYqWmBqYnq9IbR0rsqrPIogrNCx2AywSE2F/xXg7tBnn2v9dRdXtEqVS2L3dP\n drQcSojjBCYTThrPM89NZrOArdfV55azqUIPnVD2n8ISvK7gultL4HXnKpQkSMddElQY+skoQ6w\n sbyIviMNLt54kgaueobb3lre06f2DROG/c3rJsIutC03IyMMWNa69n4Or4l7lLo4QKOd5ytUqyZ\n K0BWT/cv0fEWLvA==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"7","X-Spam_score":"0.7","X-Spam_bar":"/","X-Spam_report":"(0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Use the QEMU-style error pattern returning \"true\" on success.\n\nSigned-off-by: Marc-André Lureau \n---\n include/ui/console.h | 4 ++--\n ui/vnc.c | 20 ++++++++++----------\n 2 files changed, 12 insertions(+), 12 deletions(-)","diff":"diff --git a/include/ui/console.h b/include/ui/console.h\nindex 75cd48ed7ad..f9b4665cb90 100644\n--- a/include/ui/console.h\n+++ b/include/ui/console.h\n@@ -448,8 +448,8 @@ const char *qemu_display_get_vc(DisplayOptions *opts);\n void qemu_display_help(void);\n \n /* vnc.c */\n-void vnc_display_init(const char *id, Error **errp);\n-void vnc_display_open(const char *id, Error **errp);\n+bool vnc_display_init(const char *id, Error **errp);\n+bool vnc_display_open(const char *id, Error **errp);\n void vnc_display_add_client(const char *id, int csock, bool skipauth);\n int vnc_display_password(const char *id, const char *password, Error **errp);\n int vnc_display_pw_expire(const char *id, time_t expires);\ndiff --git a/ui/vnc.c b/ui/vnc.c\nindex 4e5a9ee0341..0775417c418 100644\n--- a/ui/vnc.c\n+++ b/ui/vnc.c\n@@ -3425,12 +3425,12 @@ static void vmstate_change_handler(void *opaque, bool running, RunState state)\n \n static void vnc_display_free(VncDisplay *vd);\n \n-void vnc_display_init(const char *id, Error **errp)\n+bool vnc_display_init(const char *id, Error **errp)\n {\n VncDisplay *vd;\n \n if (vnc_display_find(id) != NULL) {\n- return;\n+ return true;\n }\n vd = g_malloc0(sizeof(*vd));\n \n@@ -3451,7 +3451,7 @@ void vnc_display_init(const char *id, Error **errp)\n \n if (!vd->kbd_layout) {\n vnc_display_free(vd);\n- return;\n+ return false;\n }\n \n vd->share_policy = VNC_SHARE_POLICY_ALLOW_EXCLUSIVE;\n@@ -3465,6 +3465,7 @@ void vnc_display_init(const char *id, Error **errp)\n &vmstate_change_handler, vd);\n \n QTAILQ_INSERT_TAIL(&vnc_displays, vd, next);\n+ return true;\n }\n \n static void vnc_display_close(VncDisplay *vd)\n@@ -4074,7 +4075,7 @@ bool vnc_display_update(DisplayUpdateOptionsVNC *arg, Error **errp)\n return true;\n }\n \n-void vnc_display_open(const char *id, Error **errp)\n+bool vnc_display_open(const char *id, Error **errp)\n {\n VncDisplay *vd = vnc_display_find(id);\n QemuOpts *opts = qemu_opts_find(&qemu_vnc_opts, id);\n@@ -4277,7 +4278,7 @@ void vnc_display_open(const char *id, Error **errp)\n qkbd_state_set_delay(vd->kbd, key_delay_ms);\n \n if (saddr_list == NULL) {\n- return;\n+ return true;\n }\n \n if (reverse) {\n@@ -4295,10 +4296,11 @@ void vnc_display_open(const char *id, Error **errp)\n }\n \n /* Success */\n- return;\n+ return true;\n \n fail:\n vnc_display_close(vd);\n+ return false;\n }\n \n void vnc_display_add_client(const char *id, int csock, bool skipauth)\n@@ -4354,12 +4356,10 @@ int vnc_init_func(void *opaque, QemuOpts *opts, Error **errp)\n id = vnc_auto_assign_id(opts);\n }\n \n- vnc_display_init(id, errp);\n- if (*errp) {\n+ if (!vnc_display_init(id, errp)) {\n return -1;\n }\n- vnc_display_open(id, errp);\n- if (*errp) {\n+ if (!vnc_display_open(id, errp)) {\n return -1;\n }\n return 0;\n","prefixes":["v2","47/67"]}