{"id":2222124,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222124/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-32-231416f76dc3@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410-qemu-vnc-v2-32-231416f76dc3@redhat.com>","date":"2026-04-10T19:18:54","name":"[v2,32/67] ui: move FONT_WIDTH/HEIGHT to vgafont.h","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"14b89b5bd544d5e73d5a3b620a62bc918a8133d2","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-32-231416f76dc3@redhat.com/mbox/","series":[{"id":499494,"url":"http://patchwork.ozlabs.org/api/1.1/series/499494/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494","date":"2026-04-10T19:18:23","name":"ui: add standalone VNC server over D-Bus","version":2,"mbox":"http://patchwork.ozlabs.org/series/499494/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222124/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222124/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=fwtbLeYk;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsmzL6VB5z20HT\n\tfor ; Sat, 11 Apr 2026 05:27:42 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBHQm-0003q4-KD; Fri, 10 Apr 2026 15:22:16 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHQl-0003je-8O\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:22:15 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHQj-0001tK-PN\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:22:14 -0400","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-692-ypADfWsgOuiGXlPFHrS0tQ-1; Fri,\n 10 Apr 2026 15:22:10 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 2219F19560B2; Fri, 10 Apr 2026 19:22:09 +0000 (UTC)","from localhost (unknown [10.44.22.4])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id DDDA21801ACA; Fri, 10 Apr 2026 19:22:07 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775848933;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=j3St06greiPm0gRjhv05vve6ioGFoJrPO6xToZlL5pk=;\n b=fwtbLeYkhXs9Vt7TeB2ZVIyHuBF8p7copaIh7PN5eFtwfEaXwDYuKwRBczbEIjXtz08wo1\n 10+1lrAhP2Hvtcvs2Eb6RWLBjKY09M+UydzIRtFgfIF38NTUmADl3CLga6zfj+wpsvWHlV\n wJIErqUBJPad0oEXyIorRLPg/FTMkbI=","X-MC-Unique":"ypADfWsgOuiGXlPFHrS0tQ-1","X-Mimecast-MFC-AGG-ID":"ypADfWsgOuiGXlPFHrS0tQ_1775848929","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Fri, 10 Apr 2026 23:18:54 +0400","Subject":"[PATCH v2 32/67] ui: move FONT_WIDTH/HEIGHT to vgafont.h","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260410-qemu-vnc-v2-32-231416f76dc3@redhat.com>","References":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","In-Reply-To":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1762;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=bzagRfynX+IeSymorU/TnEpMIirjW/YFelY6j4BXYvo=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0VHnt50kmy5xeEfHAKZmT6j4riJFT2+BYFQ\n fGa7WGh5xyJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNFQAKCRDa6OEJdZac\n 5U7CD/0f389iLnU6SZBvcz/VDFZzO9wIkSzyQwcUXFw/WF139c0XFZ3YukWrCj4ss0DZX0Y1o75\n z9MFZrUFjNtAWIP3vtiOsB53jv/j5oVTc1x/87iEnTGImjG569tt68iTZQxYc2ahe7H+5cC3xbn\n oOuv5TG9qFy+gZc9lCZzjcbNByYGXCDt7A3u56LBbU2uNfly5Nf8zuIWbBSuLmFeUbqKKX3bck1\n +URu+2OWep8VD+GkK2Vc42e/9aqOBS6J6IFqy6u+xlHF/t+2BT4eUpLENrDSB4npt8En3IKlms7\n gVHVIAWYWKYK3Axd7vHk8c5rn0PZxtoCXC+p/6zqswn2eHK9WZzom8x3rAz1m5oPDGZaWxF0Pt/\n AP3PPjvNDzuQGb5SD5VRu5YJSdSnnksTJZjExb9pyGGFy39qQdxeFYiGr6d0xdBfdS98LRMBZPi\n EwILWHW6XQXuk8i1vP1NaIJBaOwoN/BNCl1uS4Lt3NBLoNr+Z5lXMLhlzAQ8o8ASbRYQ8XKOO3n\n RRLj04qDTsGO+vZI5/DpiCrUaIwp/+3emOAqcskxm6v8450z+qfhbPoR1tpseZiQFJNEmvhliv7\n 6zyfElvhOc+jWbwGgf1/a1qNVrlJ8Gx9V9YRamv1JBGYyceZnetKhd4SLWWoiFqT3m44P3CLYRX\n GCjqopHtFBZP9KQ==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"7","X-Spam_score":"0.7","X-Spam_bar":"/","X-Spam_report":"(0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Since those values are related to the VGA font, it make sense to move\nthem here.\n\nReviewed-by: Daniel P. Berrangé \nReviewed-by: Philippe Mathieu-Daudé \nSigned-off-by: Marc-André Lureau \n---\n ui/console-priv.h | 5 -----\n ui/vgafont.h | 6 +++++-\n ui/console-vc.c | 1 +\n ui/console.c | 1 +\n 4 files changed, 7 insertions(+), 6 deletions(-)","diff":"diff --git a/ui/console-priv.h b/ui/console-priv.h\nindex 8bcdb79d914..39798c3e9d7 100644\n--- a/ui/console-priv.h\n+++ b/ui/console-priv.h\n@@ -9,11 +9,6 @@\n #include \"qemu/coroutine.h\"\n #include \"qemu/timer.h\"\n \n-#include \"vgafont.h\"\n-\n-#define FONT_HEIGHT 16\n-#define FONT_WIDTH 8\n-\n struct QemuConsole {\n Object parent;\n \ndiff --git a/ui/vgafont.h b/ui/vgafont.h\nindex 54aeeb7d192..d24b5d47a95 100644\n--- a/ui/vgafont.h\n+++ b/ui/vgafont.h\n@@ -6,6 +6,10 @@\n \n #include \n \n-extern const uint8_t vgafont16[256 * 16];\n+/* supports only vga 8x16 */\n+#define FONT_WIDTH 8\n+#define FONT_HEIGHT 16\n+\n+extern const uint8_t vgafont16[256 * FONT_HEIGHT];\n \n #endif\ndiff --git a/ui/console-vc.c b/ui/console-vc.c\nindex d58917c1850..0d7b943fdc7 100644\n--- a/ui/console-vc.c\n+++ b/ui/console-vc.c\n@@ -11,6 +11,7 @@\n #include \"qemu/queue.h\"\n #include \"ui/console.h\"\n #include \"ui/cp437.h\"\n+#include \"ui/vgafont.h\"\n \n #include \"pixman.h\"\n #include \"trace.h\"\ndiff --git a/ui/console.c b/ui/console.c\nindex b2b879e8533..c997e8df572 100644\n--- a/ui/console.c\n+++ b/ui/console.c\n@@ -24,6 +24,7 @@\n \n #include \"qemu/osdep.h\"\n #include \"ui/console.h\"\n+#include \"ui/vgafont.h\"\n #include \"hw/core/qdev.h\"\n #include \"qapi/error.h\"\n #include \"qapi/qapi-commands-ui.h\"\n","prefixes":["v2","32/67"]}