{"id":2222123,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222123/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-65-231416f76dc3@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410-qemu-vnc-v2-65-231416f76dc3@redhat.com>","date":"2026-04-10T19:19:27","name":"[v2,65/67] tests/qtest: fix dbus-vmstate-test compilation","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"24ab75d02e291ddb3b91dfc5819816e49b7951d5","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-65-231416f76dc3@redhat.com/mbox/","series":[{"id":499494,"url":"http://patchwork.ozlabs.org/api/1.1/series/499494/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494","date":"2026-04-10T19:18:23","name":"ui: add standalone VNC server over D-Bus","version":2,"mbox":"http://patchwork.ozlabs.org/series/499494/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222123/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222123/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=OCJYgabY;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsmz005tmz1yGb\n\tfor ; Sat, 11 Apr 2026 05:27:24 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBHTx-0007vw-6E; Fri, 10 Apr 2026 15:25:33 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHTv-0007pT-75\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:25:31 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHTr-00038I-Kc\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:25:30 -0400","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-180-CB5_MAHfPsWKajYmJxYsEg-1; Fri,\n 10 Apr 2026 15:25:24 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 17D8F180057A\n for ; Fri, 10 Apr 2026 19:25:24 +0000 (UTC)","from localhost (unknown [10.44.22.4])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id AD0471801ACB; Fri, 10 Apr 2026 19:25:22 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775849126;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=sgwc+N0yjaNA5essMR4duloCYDqsIlwU6/zTCk4Cxuk=;\n b=OCJYgabYGIXQAXWU4uOOTtSU9Lxfs1U8VG4oRRv5yeWGvmcyggnq8PHi9y1RwKdaaierip\n y35xYUJGuRiIkfvNr0Nugff8P21RjBXtByE5UmBJknIuoIQ3Gklil3hrtHL4bLvDPQdBaX\n BrapeSR/VDYqtfq1d8umBkTlTDnFN5Q=","X-MC-Unique":"CB5_MAHfPsWKajYmJxYsEg-1","X-Mimecast-MFC-AGG-ID":"CB5_MAHfPsWKajYmJxYsEg_1775849124","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Fri, 10 Apr 2026 23:19:27 +0400","Subject":"[PATCH v2 65/67] tests/qtest: fix dbus-vmstate-test compilation","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260410-qemu-vnc-v2-65-231416f76dc3@redhat.com>","References":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","In-Reply-To":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=2534;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=AOLvl3KfosfDJbEbxdB9wrP2jcATXQDS62ur3cuRiFY=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0XOSWttPnZQT2G7JRBB9lZ0dMbBcwCka+fo\n AqEINRhr+eJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNFwAKCRDa6OEJdZac\n 5TUtD/0R4M3EpT/7pPTt7mfMtQEn9SEVFjJOpU3PV012RyX2F/lZ2dwnH/vtVuoXCJAWqw5Qj1g\n /eXoH9qMcfoThWtN+opV/1wrfV9jSiq16U06rRa3lWHannLXOeWdNQ4Ut/QkFSEH9tBsGyMmkTp\n r2dp66OFO6X+RIpfMiQQOnzNk/lDe+L/m5WhDT8Ix1z9bESTGU3MAn1/gWk+y8a+7pzc+UelQHi\n 49QoW+NyWQhYYJxwvgooSlsulx9xOjaaefBlcZvm+9iEdOlejrPotoQ/YVBYHQ5WImXnFvLCd9G\n j8VZhRDngkUvdwNpDA20FBSSDdlKd7fONedr5EuHtFFe9NjAZIDsgO8klPQr6tO2UKCHccVHAL3\n IDH3POuarpwiYcvP/svRfaIpbDcaqt4fE2zCRDWt2Il5QTt/GRiqTjbPJ2zWFSTfFa2hC01E/cJ\n rZT4UghZbgIO4pRbFx9dkJH4XaAJhpCkR1xVcQyOkRkaTdwuUVFvKs57/PpBg/X5tPDzlIen/s7\n 3WRprfQ/JH8RuyYQ7s7O6rE6Dxsr2rcuJJ+9Y+/Sn/BSoUeRkEyNBPTNV5YoipvvhX1jxfk7HSd\n dJ3sihPbPN4Mv1M48y55CKnOAftq4Qc4u/1gc38pQM9RAgXWkhlusQOiyObU+2Uc6j9K7zdKRVi\n NWZNkF3l4DbTeLg==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The test is still disabled, and trying to compile it will fail now.\n\nFix it, and remove the G_TEST_DBUS_DAEMON setting, since it is passed by\nmeson test. Fwiw, the test passes here.\n\nSigned-off-by: Marc-André Lureau \n---\n tests/qtest/dbus-vmstate-test.c | 11 ++---------\n tests/qtest/meson.build | 3 ++-\n 2 files changed, 4 insertions(+), 10 deletions(-)","diff":"diff --git a/tests/qtest/dbus-vmstate-test.c b/tests/qtest/dbus-vmstate-test.c\nindex 0a82cc9f935..5c80bb303b6 100644\n--- a/tests/qtest/dbus-vmstate-test.c\n+++ b/tests/qtest/dbus-vmstate-test.c\n@@ -3,7 +3,7 @@\n #include \n #include \"libqtest.h\"\n #include \"dbus-vmstate1.h\"\n-#include \"migration-helpers.h\"\n+#include \"migration/migration-qmp.h\"\n \n static char *workdir;\n \n@@ -230,7 +230,7 @@ test_dbus_vmstate(Test *test)\n thread = g_thread_new(\"dbus-vmstate-thread\", dbus_vmstate_thread, loop);\n \n migrate_incoming_qmp(dst_qemu, uri, NULL, \"{}\");\n- migrate_qmp(src_qemu, uri, \"{}\");\n+ migrate_qmp(src_qemu, dst_qemu, uri, NULL, \"{}\");\n test->src_qemu = src_qemu;\n if (test->migrate_fail) {\n wait_for_migration_fail(src_qemu, true);\n@@ -343,15 +343,8 @@ int\n main(int argc, char **argv)\n {\n GError *err = NULL;\n- g_autofree char *dbus_daemon = NULL;\n int ret;\n \n- dbus_daemon = g_build_filename(G_STRINGIFY(SRCDIR),\n- \"tests\",\n- \"dbus-vmstate-daemon.sh\",\n- NULL);\n- g_setenv(\"G_TEST_DBUS_DAEMON\", dbus_daemon, true);\n-\n g_test_init(&argc, &argv, NULL);\n \n workdir = g_dir_make_tmp(\"dbus-vmstate-test-XXXXXX\", &err);\ndiff --git a/tests/qtest/meson.build b/tests/qtest/meson.build\nindex b735f55fc40..5f8cff172c8 100644\n--- a/tests/qtest/meson.build\n+++ b/tests/qtest/meson.build\n@@ -130,7 +130,8 @@ if dbus_daemon.found() and gdbus_codegen.found()\n input: meson.project_source_root() / 'backends/dbus-vmstate1.xml',\n command: [gdbus_codegen, '@INPUT@',\n '--interface-prefix', 'org.qemu',\n- '--generate-c-code', '@BASENAME@']).to_list()\n+ '--generate-c-code', '@BASENAME@',\n+ '--output-directory', meson.current_build_dir()]).to_list()\n else\n dbus_vmstate1 = []\n endif\n","prefixes":["v2","65/67"]}