{"id":2222118,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222118/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-34-231416f76dc3@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410-qemu-vnc-v2-34-231416f76dc3@redhat.com>","date":"2026-04-10T19:18:56","name":"[v2,34/67] util: move datadir.c from system/","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ae5bfcc3fe7dc60dc4f2a8af9a3e8be4a9372531","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-34-231416f76dc3@redhat.com/mbox/","series":[{"id":499494,"url":"http://patchwork.ozlabs.org/api/1.1/series/499494/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494","date":"2026-04-10T19:18:23","name":"ui: add standalone VNC server over D-Bus","version":2,"mbox":"http://patchwork.ozlabs.org/series/499494/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222118/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222118/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=RpmXcH99;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsmyT4SgXz1yGb\n\tfor ; Sat, 11 Apr 2026 05:26:57 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBHQz-0004CB-Oi; Fri, 10 Apr 2026 15:22:29 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHQw-00041O-J4\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:22:26 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHQu-0001vC-W8\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:22:26 -0400","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-173-doYNB4NBM-Og8ax6zSP9bw-1; Fri,\n 10 Apr 2026 15:22:23 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 2BE80180062A; Fri, 10 Apr 2026 19:22:22 +0000 (UTC)","from localhost (unknown [10.44.22.4])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 06DB019560AB; Fri, 10 Apr 2026 19:22:20 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775848944;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=EC2mtSmBN/QpQXCOVvzyWCJ+zIxqCQ8Cl/n8dli4yDk=;\n b=RpmXcH99SruIKP4lPRaRTbwjSTJd2EkunkX5JcSHfb2YnJIKvA2jnRfc0BM5GRQm8tq3Ox\n NNsSKVD6MZsEA2uwe/2kmlwFX9sVFCu7lAZIkuOUl9LzziSUl7tuoyyBmIi58h220Cb65S\n h44l/vQilTvzAUeOIThf+Io3zwEVas4=","X-MC-Unique":"doYNB4NBM-Og8ax6zSP9bw-1","X-Mimecast-MFC-AGG-ID":"doYNB4NBM-Og8ax6zSP9bw_1775848942","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Fri, 10 Apr 2026 23:18:56 +0400","Subject":"[PATCH v2 34/67] util: move datadir.c from system/","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260410-qemu-vnc-v2-34-231416f76dc3@redhat.com>","References":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","In-Reply-To":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=2578;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=GnyGZFXxnwQTX053ioyr310RQ/Jwl1OJBR8gcP9DCrY=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0Vkbw3IhZw7lFLSU8wW1asF2gmYIZeDBVCH\n RjQJEZ/FEeJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNFQAKCRDa6OEJdZac\n 5afuEACqUuHlq/rqHDVVNtjMO4j5+dRv5GU4IM3URxuuLwHDxYinDNa95I3n73SPW0gIDiIZ1/X\n YT+/h5r7DEoqWz5gwShQAYGkpIyb0f0LW8At0yRgvfbQEMxi1MV2wwAEXHM8+MoH7P+pWkFQDsg\n MMv0UcI/YEX95oJbWrpRnlToKovU/+NBKnbTWlmxeoxpvB6R4Jqcl8R9xDXVky7OrmLKaHMO5/E\n OY5E8WDpm/bmD66gLmAsw3ylKJP+ZPDUj2KU6ceC4x1tNkduxGEz1Ru+gJIldnNacR73tyeI2p3\n RzxftO9X6mArnXOhPliP7b5ISpLnYHXhDTC4vntx8c0m4ZVypoDnFY3CtacrG3E+KF3IvM8bPme\n l5FK7IRkQAtqaiooUtFVT2v9aj9QG6vHr4lTIoWKMr9/LO+cQTvVotUibzgFpSgYrDVFwuTD/J8\n Sp2cJFmAQkqH0X1MhrHzDYAStJtkHg+9Hi9ut57xUllxkK8Q+0LIAk6ckhSyoDD5eOMYSTEDS5f\n sjWhxct/+BMMQPtki3tymufHLcZsdDcPCVipqTnnByveRXRGw0MhFv/JP+1rU7fs/6fP0NjWn4D\n Q6aBwoR674Q61SIF5asG/EVYreoMkhxSt3rJ7In9zXS4s7chVWC3O+GEyqKFQPgCjk/Rkk1FiyS\n hscadYdQYN2FGLA==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The datadir module provides general-purpose data file lookup\nutilities that are not specific to system emulation. Move it\nto util/ so it can be reused more broadly.\n\nReviewed-by: Daniel P. Berrangé \nReviewed-by: Philippe Mathieu-Daudé \nSigned-off-by: Marc-André Lureau \n---\n {system => util}/datadir.c | 0\n system/meson.build | 1 -\n system/trace-events | 1 -\n util/meson.build | 1 +\n util/trace-events | 3 +++\n 5 files changed, 4 insertions(+), 2 deletions(-)","diff":"diff --git a/system/datadir.c b/util/datadir.c\nsimilarity index 100%\nrename from system/datadir.c\nrename to util/datadir.c\ndiff --git a/system/meson.build b/system/meson.build\nindex 579e8353d53..9cdfe1b3e75 100644\n--- a/system/meson.build\n+++ b/system/meson.build\n@@ -8,7 +8,6 @@ system_ss.add(files(\n 'bootdevice.c',\n 'cpus.c',\n 'cpu-timers.c',\n- 'datadir.c',\n 'dirtylimit.c',\n 'dma-helpers.c',\n 'exit-with-parent.c',\ndiff --git a/system/trace-events b/system/trace-events\nindex 6d29a823f04..e6e1b612798 100644\n--- a/system/trace-events\n+++ b/system/trace-events\n@@ -46,7 +46,6 @@ vm_stop_flush_all(int ret) \"ret %d\"\n \n # vl.c\n vm_state_notify(int running, int reason, const char *reason_str) \"running %d reason %d (%s)\"\n-load_file(const char *name, const char *path) \"name %s location %s\"\n runstate_set(int current_state, const char *current_state_str, int new_state, const char *new_state_str) \"current_run_state %d (%s) new_state %d (%s)\"\n system_wakeup_request(int reason) \"reason=%d\"\n qemu_system_shutdown_request(int reason) \"reason=%d\"\ndiff --git a/util/meson.build b/util/meson.build\nindex 5d3fff0eea4..8bed0267c07 100644\n--- a/util/meson.build\n+++ b/util/meson.build\n@@ -30,6 +30,7 @@ util_ss.add(when: linux_io_uring, if_true: files('fdmon-io_uring.c'))\n if glib_has_gslice\n util_ss.add(files('qtree.c'))\n endif\n+util_ss.add(files('datadir.c'))\n util_ss.add(files('defer-call.c'))\n util_ss.add(files('envlist.c', 'path.c', 'module.c'))\n util_ss.add(files('event.c'))\ndiff --git a/util/trace-events b/util/trace-events\nindex 540d6625073..df549646d12 100644\n--- a/util/trace-events\n+++ b/util/trace-events\n@@ -114,3 +114,6 @@ uffd_unregister_memory_failed(void *addr, uint64_t length, int err) \"addr: %p le\n # module.c\n module_load_module(const char *name) \"file %s\"\n module_lookup_object_type(const char *name) \"name %s\"\n+\n+# datadir.c\n+load_file(const char *name, const char *path) \"name %s location %s\"\n","prefixes":["v2","34/67"]}