{"id":2222110,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222110/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-36-231416f76dc3@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410-qemu-vnc-v2-36-231416f76dc3@redhat.com>","date":"2026-04-10T19:18:58","name":"[v2,36/67] ui: make qemu_default_pixelformat() static inline","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"8471d7c6f558449458e31e8cba8b039c9be85313","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-36-231416f76dc3@redhat.com/mbox/","series":[{"id":499494,"url":"http://patchwork.ozlabs.org/api/1.1/series/499494/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494","date":"2026-04-10T19:18:23","name":"ui: add standalone VNC server over D-Bus","version":2,"mbox":"http://patchwork.ozlabs.org/series/499494/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222110/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222110/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=L3gIto1y;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsmxs2v0Yz20HT\n\tfor ; Sat, 11 Apr 2026 05:26:25 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBHR9-0004tk-Bm; Fri, 10 Apr 2026 15:22:39 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHR7-0004rK-MK\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:22:37 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHR6-0001xT-92\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:22:37 -0400","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-126-Qtbiv3tpN82m0euDqHH_Pg-1; Fri,\n 10 Apr 2026 15:22:34 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 9F3831955DAE\n for ; Fri, 10 Apr 2026 19:22:33 +0000 (UTC)","from localhost (unknown [10.44.22.4])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 6CA2F1955E84; Fri, 10 Apr 2026 19:22:31 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775848955;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=jg06xNsDHiAjS1cpxEPhGzH0lDWKplTKePp+SKWf2pw=;\n b=L3gIto1y+V+6zxX6WVpIMDWUr7VjeGSENIOWErgUzfNG+M4EUq9qNHXT7zuWJVBVdcjRzH\n V14Q0n0igULqHmDuFmIeSwG/qy5v+RVyU54PvbOp9LxEwtudpy+VoQptLm8V0uYFhDMfll\n dL/1ZaMKP5OGS06Bxv9woquYWJy02q4=","X-MC-Unique":"Qtbiv3tpN82m0euDqHH_Pg-1","X-Mimecast-MFC-AGG-ID":"Qtbiv3tpN82m0euDqHH_Pg_1775848953","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Fri, 10 Apr 2026 23:18:58 +0400","Subject":"[PATCH v2 36/67] ui: make qemu_default_pixelformat() static inline","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260410-qemu-vnc-v2-36-231416f76dc3@redhat.com>","References":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","In-Reply-To":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=2417;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=J76FKl9tH/d0oVk3sn0TrxBVo9ODvG49qjWGz2g7+78=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0VfTC5N7taSyNlI89/Sk+QwR7eAG/Tf1qkA\n vIYYWiWUTWJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNFQAKCRDa6OEJdZac\n 5cjBD/wMYMeeHtOhi3CyRSANX9bi8iS8ZvSuUWK/eCHsIzud3RMzfJDaJUwF/5EnqvMFgs358pS\n MDJGSok9bpi53p2/ePptl0qUGzdFDLRe2ygEp+5rBjmA2XJSpOn5AWa683DF9qvSIo4x7FJaJvf\n 74qM955QfPHQdTzQPqGz2J3H3VZiCZkoBTCZFnGLSIcMQZVD+eC71SSYG6aMwFaOIo6LX/LLjHv\n OdO/MZAi1nZrz0xDc3faSpwlukeeoPHzm9V526SkOvkKxWnJFrERRsMGkliKwfOJYkFhVBEf+Jf\n eAh+mLqnktkb/cQr3IL6oeCL7PSjOd7Q8MB2Vz/0oa2oiE8Mxc2zCBK0SNpm6qFf82JYhspG7w7\n Ybdeio8k5/uylVKyKrUyy/zREmG4CjuoCK37HH4NR7x0Gomy+zicRYze9h9TRYRkl9Iw30ts+nC\n tBqJx3+TqiaLHgPJmQA3QiagTe8LqCfozzmST0R0UwkGgK/m0vp5veSLRIqhbFxg5I0K0LTKFbb\n r6vqz0BzNrIBvSXouD8n/ogx7Qt60IvKAipaXfnXVyXO0Hdf7WGtpXnnApOCYuYe1AWiuAzRACQ\n NryS5xNThCuNtaRLuW2N1Qw3fYx8sKl+4PKkzPX0BVrP4r8Z9PW/e1qeBCROu1BDnwff9Aas/63\n eDZmKIMRS/Ohaxw==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"7","X-Spam_score":"0.7","X-Spam_bar":"/","X-Spam_report":"(0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The function is a trivial wrapper around qemu_default_pixman_format()\nand qemu_pixelformat_from_pixman(), so make it static inline in\nqemu-pixman.h instead of a standalone function in console.c, allowing to\nbe easily reused.\n\nReviewed-by: Daniel P. Berrangé \nSigned-off-by: Marc-André Lureau \n---\n include/ui/qemu-pixman.h | 8 ++++++++\n include/ui/surface.h | 2 --\n ui/console.c | 7 -------\n 3 files changed, 8 insertions(+), 9 deletions(-)","diff":"diff --git a/include/ui/qemu-pixman.h b/include/ui/qemu-pixman.h\nindex 2ca0ed7029c..4bc7a59698e 100644\n--- a/include/ui/qemu-pixman.h\n+++ b/include/ui/qemu-pixman.h\n@@ -73,6 +73,14 @@ typedef struct PixelFormat {\n \n PixelFormat qemu_pixelformat_from_pixman(pixman_format_code_t format);\n pixman_format_code_t qemu_default_pixman_format(int bpp, bool native_endian);\n+\n+static inline PixelFormat qemu_default_pixelformat(int bpp)\n+{\n+ pixman_format_code_t fmt = qemu_default_pixman_format(bpp, true);\n+ PixelFormat pf = qemu_pixelformat_from_pixman(fmt);\n+ return pf;\n+}\n+\n pixman_format_code_t qemu_drm_format_to_pixman(uint32_t drm_format);\n uint32_t qemu_pixman_to_drm_format(pixman_format_code_t pixman);\n int qemu_pixman_get_type(int rshift, int gshift, int bshift, int endian);\ndiff --git a/include/ui/surface.h b/include/ui/surface.h\nindex d2542d3ace5..8e5f3e35e8c 100644\n--- a/include/ui/surface.h\n+++ b/include/ui/surface.h\n@@ -24,8 +24,6 @@ typedef struct DisplaySurface {\n uint32_t share_handle_offset;\n } DisplaySurface;\n \n-PixelFormat qemu_default_pixelformat(int bpp);\n-\n DisplaySurface *qemu_create_displaysurface_from(int width, int height,\n pixman_format_code_t format,\n int linesize, uint8_t *data);\ndiff --git a/ui/console.c b/ui/console.c\nindex 24794e5a9dc..78b0ac27827 100644\n--- a/ui/console.c\n+++ b/ui/console.c\n@@ -1392,13 +1392,6 @@ DisplaySurface *qemu_console_surface(QemuConsole *console)\n }\n }\n \n-PixelFormat qemu_default_pixelformat(int bpp)\n-{\n- pixman_format_code_t fmt = qemu_default_pixman_format(bpp, true);\n- PixelFormat pf = qemu_pixelformat_from_pixman(fmt);\n- return pf;\n-}\n-\n static QemuDisplay *dpys[DISPLAY_TYPE__MAX];\n \n void qemu_display_register(QemuDisplay *ui)\n","prefixes":["v2","36/67"]}