{"id":2222106,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222106/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-55-231416f76dc3@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410-qemu-vnc-v2-55-231416f76dc3@redhat.com>","date":"2026-04-10T19:19:17","name":"[v2,55/67] ui/vnc: add vnc-system unit, to allow different implementations","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"145597d88bd0e9463656974af09d705223e03c35","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-55-231416f76dc3@redhat.com/mbox/","series":[{"id":499494,"url":"http://patchwork.ozlabs.org/api/1.1/series/499494/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494","date":"2026-04-10T19:18:23","name":"ui: add standalone VNC server over D-Bus","version":2,"mbox":"http://patchwork.ozlabs.org/series/499494/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222106/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222106/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=RDKgXH8Z;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsmxg4Mcbz1yGb\n\tfor ; Sat, 11 Apr 2026 05:26:15 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBHT5-0006sc-Cu; Fri, 10 Apr 2026 15:24:39 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHT1-0006sT-71\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:24:35 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHSs-0002TJ-4S\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:24:31 -0400","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-346-7wgy3TLkO4-KnhbUPmoWcg-1; Fri,\n 10 Apr 2026 15:24:24 -0400","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 80D681956054\n for ; Fri, 10 Apr 2026 19:24:23 +0000 (UTC)","from localhost (unknown [10.44.22.4])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 4FE7C195608E; Fri, 10 Apr 2026 19:24:21 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775849065;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=DbWS1U6sGNFtZ0AKwcuYyB+KC1yy2Hf37j/hRn33Qzw=;\n b=RDKgXH8Zx5ncQSXKLu9OTPTNlK2oANy7cdijQZaHamL5XKcgMPCKszHtdlKE1JMzWez+UM\n fcG2GkZ+jU036Hhe7L1C6zq0P+XfuNbZfg6+Cc0oAAic9ZZsC5u7kY56T1sNkA640gfSqA\n boW+tr+69wcXhR+PNHOip04+ncb1I1M=","X-MC-Unique":"7wgy3TLkO4-KnhbUPmoWcg-1","X-Mimecast-MFC-AGG-ID":"7wgy3TLkO4-KnhbUPmoWcg_1775849063","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Fri, 10 Apr 2026 23:19:17 +0400","Subject":"[PATCH v2 55/67] ui/vnc: add vnc-system unit, to allow different\n implementations","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260410-qemu-vnc-v2-55-231416f76dc3@redhat.com>","References":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","In-Reply-To":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=2652;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=lv2qIJXAuZ9UVUHeJZVKwIcM+k9S1qb2iody8sOCzmk=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0WLIXZcC6sj0ZWvuB1ugWOMFJnhVEJU0lUE\n +MOjyM4BS2JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNFgAKCRDa6OEJdZac\n 5S6IEACOMjCLdYq3xK7edzhJeK6RR7MrATZC2d8gcKk/nVJRot4AEegVjV37wom2VlI7A0M6L7g\n oFYOhl9MoC58GMslrRJdDBMgBu2T9IiYD1x5rHTmHEVGM/9Pe/CI6Cp62Jj++nIJvzYCS1cUnGo\n 1a+WnNCOKfzgAPnNfPZhiuOIQOVG9HKpwfSR5dkaGvI4jRa8ADWenWbu4o9uBaLwQPg1QSihih4\n XJyqAAAdHl2Uc2rtddUACzLIeXIfUkNUz4xOInPWHD60jE6BVAWRZm80F/Qn4lXFSB81oQB4RpQ\n 8L61vQm6Ezi1FIluqZWoc42wSF+ZGznrEaaQEkXxHgXM4Xu/bOEcxiKC6GFhUIjqW2+yUe9kANb\n 1UybYeT2b0KZaQXSyKuzdDU4XWGZUA8r5eU3trWkAJzhcC4hnJUZLruZ0Mb+lbwv09fvVs5E2X7\n 2SgH85pY3///SPxhNfcmQffHUzwQ4WKWneqlze+kjMIleHAl8IMBbWH4/UKZi/GK52aWrF/VCJi\n VCQG7reehPZBc8Lt/X8AtPSFsN5xEgu80xHMb4xaoQAv05URYxEBQeNm2NFtIk7rk1HkhKDZnxX\n 9C5WSjzf2PFqaAmNZCRC4s29vGH5zUv5nWI1LuTwrKgmnt4DlcYcKPag54h4OPda97LFFYKS+kT\n exbslvLGaedmrww==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"7","X-Spam_score":"0.7","X-Spam_bar":"/","X-Spam_report":"(0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The qemu-vnc server will want to signal the XVP requests, let it\nhave its own implementation.\n\nSigned-off-by: Marc-André Lureau \n---\n ui/vnc.h | 4 ++++\n ui/vnc-system.c | 19 +++++++++++++++++++\n ui/vnc.c | 4 ++--\n ui/meson.build | 2 +-\n 4 files changed, 26 insertions(+), 3 deletions(-)","diff":"diff --git a/ui/vnc.h b/ui/vnc.h\nindex 993ec022e52..7341fb0f25c 100644\n--- a/ui/vnc.h\n+++ b/ui/vnc.h\n@@ -649,4 +649,8 @@ void vnc_server_cut_text_caps(VncState *vs);\n void vnc_client_cut_text(VncState *vs, size_t len, uint8_t *text);\n void vnc_client_cut_text_ext(VncState *vs, int32_t len, uint32_t flags, uint8_t *data);\n \n+/* XVP events */\n+void vnc_action_shutdown(VncState *vs);\n+void vnc_action_reset(VncState *vs);\n+\n #endif /* QEMU_VNC_H */\ndiff --git a/ui/vnc-system.c b/ui/vnc-system.c\nnew file mode 100644\nindex 00000000000..0632885f655\n--- /dev/null\n+++ b/ui/vnc-system.c\n@@ -0,0 +1,19 @@\n+/*\n+ * QEMU VNC display driver\n+ *\n+ * SPDX-License-Identifier: GPL-2.0-or-later\n+ */\n+#include \"qemu/osdep.h\"\n+\n+#include \"ui/vnc.h\"\n+#include \"system/runstate.h\"\n+\n+void vnc_action_shutdown(VncState *vs)\n+{\n+ qemu_system_powerdown_request();\n+}\n+\n+void vnc_action_reset(VncState *vs)\n+{\n+ qemu_system_reset_request(SHUTDOWN_CAUSE_HOST_QMP_SYSTEM_RESET);\n+}\ndiff --git a/ui/vnc.c b/ui/vnc.c\nindex e7ec1fb7f68..5dd1eb399cc 100644\n--- a/ui/vnc.c\n+++ b/ui/vnc.c\n@@ -2521,13 +2521,13 @@ static int protocol_client_msg(VncState *vs, uint8_t *data, size_t len)\n \n switch (action) {\n case VNC_XVP_ACTION_SHUTDOWN:\n- qemu_system_powerdown_request();\n+ vnc_action_shutdown(vs);\n break;\n case VNC_XVP_ACTION_REBOOT:\n send_xvp_message(vs, VNC_XVP_CODE_FAIL);\n break;\n case VNC_XVP_ACTION_RESET:\n- qemu_system_reset_request(SHUTDOWN_CAUSE_HOST_QMP_SYSTEM_RESET);\n+ vnc_action_reset(vs);\n break;\n default:\n send_xvp_message(vs, VNC_XVP_CODE_FAIL);\ndiff --git a/ui/meson.build b/ui/meson.build\nindex b31ddf96282..f959f8972b5 100644\n--- a/ui/meson.build\n+++ b/ui/meson.build\n@@ -48,7 +48,7 @@ vnc_ss.add(files(\n vnc_ss.add(zlib, jpeg, png)\n vnc_ss.add(when: sasl, if_true: files('vnc-auth-sasl.c'))\n system_ss.add_all(when: [vnc, pixman], if_true: vnc_ss)\n-system_ss.add(when: vnc, if_false: files('vnc-stubs.c'))\n+system_ss.add(when: vnc, if_true: files('vnc-system.c'), if_false: files('vnc-stubs.c'))\n \n ui_modules = {}\n \n","prefixes":["v2","55/67"]}