{"id":2222102,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222102/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-53-231416f76dc3@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410-qemu-vnc-v2-53-231416f76dc3@redhat.com>","date":"2026-04-10T19:19:15","name":"[v2,53/67] ui/vnc: remove left-over dead code","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c7dda98a899e0c5cf1f73519ca3de4939fb13114","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-53-231416f76dc3@redhat.com/mbox/","series":[{"id":499494,"url":"http://patchwork.ozlabs.org/api/1.1/series/499494/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494","date":"2026-04-10T19:18:23","name":"ui: add standalone VNC server over D-Bus","version":2,"mbox":"http://patchwork.ozlabs.org/series/499494/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222102/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222102/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=i2wy4NBF;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsmwZ5SWDz1yGb\n\tfor ; Sat, 11 Apr 2026 05:25:18 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBHSk-0006oa-PI; Fri, 10 Apr 2026 15:24:19 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHSi-0006o5-PM\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:24:16 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHSg-0002LX-7k\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:24:16 -0400","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-197-4DV-SAq9OfmPcUsYZt-iFw-1; Fri,\n 10 Apr 2026 15:24:12 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 740FD19560AA\n for ; Fri, 10 Apr 2026 19:24:10 +0000 (UTC)","from localhost (unknown [10.44.22.4])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 56E121800357; Fri, 10 Apr 2026 19:24:08 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775849053;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=vpll6YX+O+2Ns3q47yqepmDMW6ivubkbADkky21Sx8Y=;\n b=i2wy4NBFTtw3rOHBMHJSDnjKmhagAXWeBvQKGHzpt/esP2fxZrhqiqF7XtBylqQ0aCT1Pk\n BV6osB3Fcinfypx2ps1axuoZQtlnyLL/Htmv7f2BMJt1gW24xWJ4gAtXsKilHEqsRwTmqd\n E4+vrfkrTqJvoE65DRZPDVg1SuBu93k=","X-MC-Unique":"4DV-SAq9OfmPcUsYZt-iFw-1","X-Mimecast-MFC-AGG-ID":"4DV-SAq9OfmPcUsYZt-iFw_1775849050","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Fri, 10 Apr 2026 23:19:15 +0400","Subject":"[PATCH v2 53/67] ui/vnc: remove left-over dead code","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260410-qemu-vnc-v2-53-231416f76dc3@redhat.com>","References":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","In-Reply-To":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1077;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=CqHLiX8tGa6Hx6kmExwugSms02HGkuRScDrfwgow37M=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0WqDRv0gPu6MpPVpnIxCrJsCnGRhCgr5KZj\n WJDiWUefXKJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNFgAKCRDa6OEJdZac\n 5cj7D/0WEpZ7YbKdUdieoIzmiphxic55Bb4GtFZXjf35GLXdtjEGW/tkP/q8saTvdb3D6Nik+fi\n 1nhu5PjY/R2kgasGPTEWw8eOd2tnVr220th6acGdsYMk+O7DQXxiHScZVtyO6yHit805A1REWHt\n 5/U+E4/WIfDoYBjSQieRqV2aTXM1CUNeilASkySJkn/3j8V45BuldgTF1qQecUgfX5/iKOelTL3\n d9A8yNoXLdu5DI9f/I0bOnpwoJZDtz/MVgem0zb2yN/Zw+yrv7U8DNsPiWhjIW8/Wutwlf3LGvo\n LUxHGGPaF7HqlCVZOpWKm+i8SenXfyTD9KLuSpyGAW7UonlYV7QE5bbmF7fu7hDQt6lX+lfyoRK\n 6wRP71gh5B+K8rIKR9/2AmPrvscF3DST3u87ls7WOXiZttqyhBdSf42WWFI2m7yAn1pIYb8ZGMF\n rK9pZCHAlBJQKS9Xse3o3DuBUeeUIrydKdTh3iKQcldIswCjaE93lT1SndzV2jDivC9zmVwhzRV\n iXzyUmnfHAckbMZt52ORc/GBehJGeolfsUJoyt91h1Cyi9XTPn2UvSqnQAxdHBrGIMpTY7zMX1B\n dbB/+3ZLhzvly3d+U1fcTAea3w4c4UoP7PGjY+TsB95TphY0+5PebqWIH0vEAYNp6XJZLYtl26R\n AcgiXY+CLGcHUiQ==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"7","X-Spam_score":"0.7","X-Spam_bar":"/","X-Spam_report":"(0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Since commit 5994dcb8d85 (\"ui, monitor: remove deprecated VNC ACL option\nand HMP commands\"), this field is no longer used.\n\nSigned-off-by: Marc-André Lureau \n---\n ui/vnc.h | 1 -\n ui/vnc.c | 4 ----\n 2 files changed, 5 deletions(-)","diff":"diff --git a/ui/vnc.h b/ui/vnc.h\nindex 794341265b3..993ec022e52 100644\n--- a/ui/vnc.h\n+++ b/ui/vnc.h\n@@ -180,7 +180,6 @@ struct VncDisplay\n bool non_adaptive;\n bool power_control;\n QCryptoTLSCreds *tlscreds;\n- QAuthZ *tlsauthz;\n char *tlsauthzid;\n #ifdef CONFIG_VNC_SASL\n VncDisplaySASL sasl;\ndiff --git a/ui/vnc.c b/ui/vnc.c\nindex 6fef80e98c4..e7ec1fb7f68 100644\n--- a/ui/vnc.c\n+++ b/ui/vnc.c\n@@ -3493,10 +3493,6 @@ static void vnc_display_close(VncDisplay *vd)\n object_unref(OBJECT(vd->tlscreds));\n vd->tlscreds = NULL;\n }\n- if (vd->tlsauthz) {\n- object_unparent(OBJECT(vd->tlsauthz));\n- vd->tlsauthz = NULL;\n- }\n g_free(vd->tlsauthzid);\n vd->tlsauthzid = NULL;\n if (vd->lock_key_sync) {\n","prefixes":["v2","53/67"]}