{"id":2222101,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222101/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-42-231416f76dc3@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410-qemu-vnc-v2-42-231416f76dc3@redhat.com>","date":"2026-04-10T19:19:04","name":"[v2,42/67] ui/vnc: VncDisplay.id is not const","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3be6ad6ca7e4577bc38e698cc7914a10896d4784","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-42-231416f76dc3@redhat.com/mbox/","series":[{"id":499494,"url":"http://patchwork.ozlabs.org/api/1.1/series/499494/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494","date":"2026-04-10T19:18:23","name":"ui: add standalone VNC server over D-Bus","version":2,"mbox":"http://patchwork.ozlabs.org/series/499494/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222101/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222101/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=aMlitUIJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsmwQ2TL1z20HT\n\tfor ; Sat, 11 Apr 2026 05:25:10 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBHRh-0005hu-Ph; Fri, 10 Apr 2026 15:23:13 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHRg-0005hi-FO\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:23:12 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHRf-00022w-3I\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:23:12 -0400","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-158-3ul0VVN4MRmwyLf21reDkA-1; Fri,\n 10 Apr 2026 15:23:08 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 1C1551956067\n for ; Fri, 10 Apr 2026 19:23:08 +0000 (UTC)","from localhost (unknown [10.44.22.4])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id D980D1800B7F; Fri, 10 Apr 2026 19:23:06 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775848990;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=u8+aGOrlZvbLe8b3dP8NZl4yaXIo8XPnd+wSuT5ylyA=;\n b=aMlitUIJAhk6MbDrMBYFc3sQUHHXzM9qQL2o9immMGPPT9YBzKOb4KhoAkwsuV+Jsyg5p/\n HnT8FEYV+S/EaksTQvivid/At1P7BB4PlPON1GEkEiR5bQEWU5mUOZ7EMbaM6BgC1mqY1T\n jm8hmpaRLXE9DOAvnj7xbL64F3u964E=","X-MC-Unique":"3ul0VVN4MRmwyLf21reDkA-1","X-Mimecast-MFC-AGG-ID":"3ul0VVN4MRmwyLf21reDkA_1775848988","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Fri, 10 Apr 2026 23:19:04 +0400","Subject":"[PATCH v2 42/67] ui/vnc: VncDisplay.id is not const","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260410-qemu-vnc-v2-42-231416f76dc3@redhat.com>","References":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","In-Reply-To":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1171;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=mSk65SLNJlDbzx9MsgD8lSsR+rYOCydI8294L/iqyCg=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0VCXgLnjmpdsJW0W/ZyAOFeHmRTAzdcEM50\n w8fYAdlEnyJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNFQAKCRDa6OEJdZac\n 5agJD/9QzXNOtAUPm2MNYRiTQR9Knb6h3YLd3fqh0Q5Wc9Pvw3UtkYaIrmhqpAItckxG/6g0Xu1\n 9IOaPu0a/VNPr7rdYnnx6SMKkMa5WnTKU3YYUQ2HaztIHVci3X0pUiL2S5K3P2JXYwj4jIroWLF\n sC2nstF2v2ggjdLBmvRlklHWBtE96auSO2izrzX1S2xDRPE5Id7sVnrSrTsCbqPqBO+1Fee2cPa\n 5jq7STeRvHX0W28LVgwIpY7EgNbk789RXN+OF9UCb3Q+DJuQFUiKYcWRJP+ZGVmVpTjzAChtcQB\n WKapJi9k0gk42Psw/gDmMKTbbWd43iqBVBmMrOf/p47WhgKntyes71thREvm03glMNpIH7OsRpe\n +gpEMTPiko2XnoDMBVrHeTDmC4hhWAIMROE0We0PKjM8d/X8/zrpk57zXiOWUI/URf5/SROasUQ\n xMlWUCLRbmB3wz4Xr5JRmLp1epJmmwY4N8MEZ3ZNDLF5QuJh3SutrmYW4ufksHk6ww9Mi0B4KCB\n 8twzeFzKBck2XvcegS3kkZKNWK4cCtr6WrUvLeZyy011+vkk29pEHPQ9yk87aK2I8kJoZaD/85n\n 4zxTahwbH8QpSHdbaTbiJ65WYP0ZaaV20KO0IxlLi/Vof4e3uMTOjljnA0shmLUGh7Msy6C8zyO\n CWTNz+SSJIDTN4Q==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"7","X-Spam_score":"0.7","X-Spam_bar":"/","X-Spam_report":"(0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"s/strdup/g_strdup to highlight the issue and be consistent with other\nallocations.\n\nThe next patch is going to introduce vnc_display_free() to take care of\ndeallocating it.\n\nReviewed-by: Daniel P. Berrangé \nSigned-off-by: Marc-André Lureau \n---\n ui/vnc.h | 2 +-\n ui/vnc.c | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/ui/vnc.h b/ui/vnc.h\nindex ec8d0c91b57..c5d678ac31e 100644\n--- a/ui/vnc.h\n+++ b/ui/vnc.h\n@@ -166,7 +166,7 @@ struct VncDisplay\n pixman_image_t *server; /* vnc server surface */\n int true_width; /* server surface width before rounding up */\n \n- const char *id;\n+ char *id;\n QTAILQ_ENTRY(VncDisplay) next;\n char *password;\n time_t expires;\ndiff --git a/ui/vnc.c b/ui/vnc.c\nindex 2df91642570..522d4d8fb88 100644\n--- a/ui/vnc.c\n+++ b/ui/vnc.c\n@@ -3431,7 +3431,7 @@ void vnc_display_init(const char *id, Error **errp)\n }\n vd = g_malloc0(sizeof(*vd));\n \n- vd->id = strdup(id);\n+ vd->id = g_strdup(id);\n QTAILQ_INSERT_TAIL(&vnc_displays, vd, next);\n \n QTAILQ_INIT(&vd->clients);\n","prefixes":["v2","42/67"]}