{"id":2222096,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222096/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-26-231416f76dc3@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410-qemu-vnc-v2-26-231416f76dc3@redhat.com>","date":"2026-04-10T19:18:48","name":"[v2,26/67] ui/console-vc: extract vt100_input() from vc_chr_write()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"1ad5d3d12b7d5ffc9cae960626f73930eadcc82b","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-26-231416f76dc3@redhat.com/mbox/","series":[{"id":499494,"url":"http://patchwork.ozlabs.org/api/1.1/series/499494/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494","date":"2026-04-10T19:18:23","name":"ui: add standalone VNC server over D-Bus","version":2,"mbox":"http://patchwork.ozlabs.org/series/499494/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222096/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222096/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=SI2xdqCS;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsmsX3lKtz1y2d\n\tfor ; Sat, 11 Apr 2026 05:22:40 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBHQI-0000Xt-D3; Fri, 10 Apr 2026 15:21:46 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHQ9-0008Lq-IJ\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:21:39 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHQ7-0001dN-Tw\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:21:37 -0400","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-iGkVYhm7Mp27tI82cdbnXw-1; Fri,\n 10 Apr 2026 15:21:31 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 0573B195609D; Fri, 10 Apr 2026 19:21:31 +0000 (UTC)","from localhost (unknown [10.44.22.4])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id EB5E11800357; Fri, 10 Apr 2026 19:21:29 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775848895;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Nlf2o8mRqacvDJSwzpHGOMMjfkTarzsBxasECZnZ52w=;\n b=SI2xdqCST6qvYRJ06ADo3p61qOaJFnVsGFAuAL9OKj4Tmo3oETNupjlIkm1vkIv9NoYT+K\n at1tc0q4mmKeeahZI0Rdlmwu7MqZ/DQ5WWxlT2QWmMKjV8HEpL/0OA2eA7/YLhHh1Nbt2e\n PIAJDQbYca7vzPtvYYwaba9C0ZVwJ2k=","X-MC-Unique":"iGkVYhm7Mp27tI82cdbnXw-1","X-Mimecast-MFC-AGG-ID":"iGkVYhm7Mp27tI82cdbnXw_1775848891","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Fri, 10 Apr 2026 23:18:48 +0400","Subject":"[PATCH v2 26/67] ui/console-vc: extract vt100_input() from\n vc_chr_write()","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260410-qemu-vnc-v2-26-231416f76dc3@redhat.com>","References":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","In-Reply-To":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=2581;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=TYkIOGSAidOPC1GAUAmf1ai1B20Ef3cKVdaaYTLqsSc=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0UC+ZcTORFPunFNKAFArqyjf73drBZpEU6O\n PZgTCUA3QqJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNFAAKCRDa6OEJdZac\n 5d76EACknccvmeujT9lmEtJYNq5TH/2P28Av+Tfxl13hAFDh5fKsr1Zc8VthN9h4y/E7CqM92Hh\n PJYFcbtZrRYIhltxj/dKCstiB+kll0R40PG2jyNsTNDE886PXgX0LbC2dJZykKrYX++FVqW6RBX\n 6jPYMT5DLohLmRYSF+5SoyS6uVo+Uz98HvKFWNoYtiOtKpcS+5zFAGzCyKeFKbUXZIRN0sxCrMc\n MHqRy8MqaLSBtluQ+M1xwajPoimVHbEsRMqHTRImGDUTinEY0LA2VQg8dcaCcTDrrUqqowT3V/j\n +pKxCXCRmm311+O4jNIu5UwMAl7BTBmSctGO6MrvcvhiZnccsVDOGypIsfddB4NUOqRKQahM7F8\n WZ0Ze/xCV2ozfpur9cZ+2iXYAr1STvBaXDQ3F/kvBFqRpHzaxPVyAeqdMK0YetZqa9QtJbcBW0G\n 2Tpe8FOS7v9z423UCOnBDHNLkG66BdmlX7FZVlx06ilqiyLB9fYo1nV51e6hZiYQN7Ce9cItaoV\n I9naMIlfdsftN1gBt6z/JBhtRng270pBeMQZ4GgSwibU8l7Xms5nx+hkG4qaCnmhIsUSbLE6dRj\n a18bwhiD0PvkAGsVc2OaX0F15EK9XGD9fz81CorQX8FWWCWCPy/CVF6sZdTmRKIq6ZuSG/kdt1z\n uT10k5nel20LK6Q==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"7","X-Spam_score":"0.7","X-Spam_bar":"/","X-Spam_report":"(0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Move the VT100 input processing logic out of vc_chr_write() into a new\nvt100_input() function that operates on QemuVT100 directly, rather than\ngoing through the Chardev/VCChardev layers. This continues the effort\nto decouple the VT100 emulation from the chardev backend, making the\nVT100 layer self-contained and reusable.\n\nvc_chr_write() becomes a thin wrapper that extracts the QemuVT100 from\nthe chardev and delegates to vt100_input().\n\nReviewed-by: Philippe Mathieu-Daudé \nSigned-off-by: Marc-André Lureau \n---\n ui/console-vc.c | 34 ++++++++++++++++++++--------------\n 1 file changed, 20 insertions(+), 14 deletions(-)","diff":"diff --git a/ui/console-vc.c b/ui/console-vc.c\nindex 5cfb3dfcf72..15600128380 100644\n--- a/ui/console-vc.c\n+++ b/ui/console-vc.c\n@@ -1057,29 +1057,35 @@ static void vt100_putchar(QemuVT100 *vt, int ch)\n DECLARE_INSTANCE_CHECKER(VCChardev, VC_CHARDEV,\n TYPE_CHARDEV_VC)\n \n-static int vc_chr_write(Chardev *chr, const uint8_t *buf, int len)\n+static size_t vt100_input(QemuVT100 *vt, const uint8_t *buf, size_t len)\n {\n- VCChardev *drv = VC_CHARDEV(chr);\n- QemuTextConsole *s = drv->console;\n int i;\n \n- s->vt.update_x0 = s->vt.width * FONT_WIDTH;\n- s->vt.update_y0 = s->vt.height * FONT_HEIGHT;\n- s->vt.update_x1 = 0;\n- s->vt.update_y1 = 0;\n- vt100_show_cursor(&s->vt, 0);\n+ vt->update_x0 = vt->width * FONT_WIDTH;\n+ vt->update_y0 = vt->height * FONT_HEIGHT;\n+ vt->update_x1 = 0;\n+ vt->update_y1 = 0;\n+ vt100_show_cursor(vt, 0);\n for(i = 0; i < len; i++) {\n- vt100_putchar(&s->vt, buf[i]);\n+ vt100_putchar(vt, buf[i]);\n }\n- vt100_show_cursor(&s->vt, 1);\n- if (s->vt.update_x0 < s->vt.update_x1) {\n- vt100_image_update(&s->vt, s->vt.update_x0, s->vt.update_y0,\n- s->vt.update_x1 - s->vt.update_x0,\n- s->vt.update_y1 - s->vt.update_y0);\n+ vt100_show_cursor(vt, 1);\n+ if (vt->update_x0 < vt->update_x1) {\n+ vt100_image_update(vt, vt->update_x0, vt->update_y0,\n+ vt->update_x1 - vt->update_x0,\n+ vt->update_y1 - vt->update_y0);\n }\n return len;\n }\n \n+static int vc_chr_write(Chardev *chr, const uint8_t *buf, int len)\n+{\n+ VCChardev *drv = VC_CHARDEV(chr);\n+ QemuTextConsole *s = drv->console;\n+\n+ return vt100_input(&s->vt, buf, len);\n+}\n+\n void vt100_update_cursor(void)\n {\n QemuVT100 *vt;\n","prefixes":["v2","26/67"]}