{"id":2222094,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222094/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-27-231416f76dc3@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410-qemu-vnc-v2-27-231416f76dc3@redhat.com>","date":"2026-04-10T19:18:49","name":"[v2,27/67] ui/console-vc: extract vt100_keysym() from qemu_text_console_handle_keysym()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b6c5bb900324e6891eac19ba335151d977307fd0","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-27-231416f76dc3@redhat.com/mbox/","series":[{"id":499494,"url":"http://patchwork.ozlabs.org/api/1.1/series/499494/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494","date":"2026-04-10T19:18:23","name":"ui: add standalone VNC server over D-Bus","version":2,"mbox":"http://patchwork.ozlabs.org/series/499494/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222094/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222094/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=AHwq2CGu;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsms44NdQz1y2d\n\tfor ; Sat, 11 Apr 2026 05:22:16 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBHQK-0000nz-4d; Fri, 10 Apr 2026 15:21:48 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHQG-0000Ar-0K\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:21:44 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHQD-0001eO-GF\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:21:43 -0400","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-433-4spDCFraP0WJ1VHOYwUL1g-1; Fri,\n 10 Apr 2026 15:21:37 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 9EDC5180058D; Fri, 10 Apr 2026 19:21:36 +0000 (UTC)","from localhost (unknown [10.44.22.4])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 53CD0180049F; Fri, 10 Apr 2026 19:21:34 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775848900;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=mDLYNXZjlTlSxzcMb74MrLDpQtk/TMaFCRV7hGZTqqY=;\n b=AHwq2CGu2NP9kzBCf8jalcdv3vLpe/g26PFAdXbaEsfUoHYULUvckSJPEe6JXDjV7nWJXd\n YW5cD4323B1JO/TjBq74uUV6/c4xNlzeq0y+a4snfcni82sgTT7OiGeoLUih6nXvIi8u7G\n ZQolQB4zn6LJgQPLvM/6VYR/M1C3r9k=","X-MC-Unique":"4spDCFraP0WJ1VHOYwUL1g-1","X-Mimecast-MFC-AGG-ID":"4spDCFraP0WJ1VHOYwUL1g_1775848896","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Fri, 10 Apr 2026 23:18:49 +0400","Subject":"[PATCH v2 27/67] ui/console-vc: extract vt100_keysym() from\n qemu_text_console_handle_keysym()","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260410-qemu-vnc-v2-27-231416f76dc3@redhat.com>","References":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","In-Reply-To":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=2776;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=+oqf6AEhVnc97NT06e9h+2Bd4I1hHF+5HPYR62+f2m8=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0VPs59GxFP3E5IRXlZpPNm436UNDAUqvSYm\n W5mRcmifl2JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNFQAKCRDa6OEJdZac\n 5YmBEAC60zh88rRAHw0/RtJ+Ol8A5TrU0qPxzRl+l9mkNV0burQiw9ftROtdRiy4q2/+Wsqgpwf\n sT7ccQPYHyU2nWpHQOnMrdDFbklXq0ohk3RzezjecKP9qqN6wIcMIEZ1gCEUB4xB50p9Zk4hQ/v\n yk/H//av7lOlAgaTZ8qnUqwhQ2kAcI+W8zKy+r4xMWfC6hVMyFhz5qpeF564WdTJC46gVpG073R\n dTflZYGep1yh6X6aZ63f+iFFXNEYtBTs4KMCYGQdje3EDMfWwwdmG3LbeedW7oD9W2iZv5duLNN\n 7H/fMOnEu+YNHTMdgR+KGyR1SPg/4BDJYct6X16L7TKhp4/aOdGnPNpCLF9rm+RpAGNqxWVqPqx\n LfngY77vYTjIfAztoq9IQYyM1DLJZKvLpc/UsuUKpulgp+umXtXC+PjegUuezx8qJJhmdtAALf0\n wiTSauHzH0UbFGXDQpbb3G8t/CsJ8KVPSfZueSAlFsYrEbDHBpm5YOousGvAFK2LjCXX0osTuuH\n sOFUXXmeKHvUXAcB2wmKCCsQIFf6gww4ZOUZtxloHPcdhDuuFwqMN24oikMSa/WiLLyS6sedp4d\n koITS+OL09+mDlsRBckPi7nbJ1CfToOKtRm8ImpPpH0lZBKCSE9dkP+iyGk1ZaoCmaMEvEcR7YG\n N8ErT9xNAIXk2dw==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Move the keysym handling logic out of qemu_text_console_handle_keysym()\ninto a new vt100_keysym() helper that operates on QemuVT100 directly,\ncontinuing the effort to decouple the VT100 layer from the console layer.\n\nThe echo path is updated to call vt100_input() instead of\nqemu_chr_write(), since the function no longer has direct access\nto the chardev.\n\nReviewed-by: Philippe Mathieu-Daudé \nSigned-off-by: Marc-André Lureau \n---\n ui/console-vc.c | 29 ++++++++++++++++++-----------\n 1 file changed, 18 insertions(+), 11 deletions(-)","diff":"diff --git a/ui/console-vc.c b/ui/console-vc.c\nindex 15600128380..194233f41df 100644\n--- a/ui/console-vc.c\n+++ b/ui/console-vc.c\n@@ -326,24 +326,25 @@ static void vt100_write(QemuVT100 *vt, const void *buf, size_t len)\n vt->out_flush(vt);\n }\n \n-/* called when an ascii key is pressed */\n-void qemu_text_console_handle_keysym(QemuTextConsole *s, int keysym)\n+static int vt100_input(QemuVT100 *vt, const uint8_t *buf, int len);\n+\n+static void vt100_keysym(QemuVT100 *vt, int keysym)\n {\n uint8_t buf[16], *q;\n int c;\n \n switch(keysym) {\n case QEMU_KEY_CTRL_UP:\n- vt100_scroll(&s->vt, -1);\n+ vt100_scroll(vt, -1);\n break;\n case QEMU_KEY_CTRL_DOWN:\n- vt100_scroll(&s->vt, 1);\n+ vt100_scroll(vt, 1);\n break;\n case QEMU_KEY_CTRL_PAGEUP:\n- vt100_scroll(&s->vt, -10);\n+ vt100_scroll(vt, -10);\n break;\n case QEMU_KEY_CTRL_PAGEDOWN:\n- vt100_scroll(&s->vt, 10);\n+ vt100_scroll(vt, 10);\n break;\n default:\n /* convert the QEMU keysym to VT100 key string */\n@@ -360,18 +361,24 @@ void qemu_text_console_handle_keysym(QemuTextConsole *s, int keysym)\n *q++ = '\\033';\n *q++ = '[';\n *q++ = keysym & 0xff;\n- } else if (s->vt.echo && (keysym == '\\r' || keysym == '\\n')) {\n- qemu_chr_write(s->chr, (uint8_t *)\"\\r\", 1, true);\n+ } else if (vt->echo && (keysym == '\\r' || keysym == '\\n')) {\n+ vt100_input(vt, (uint8_t *)\"\\r\", 1);\n *q++ = '\\n';\n } else {\n *q++ = keysym;\n }\n- if (s->vt.echo) {\n- qemu_chr_write(s->chr, buf, q - buf, true);\n+ if (vt->echo) {\n+ vt100_input(vt, buf, q - buf);\n }\n- vt100_write(&s->vt, buf, q - buf);\n+ vt100_write(vt, buf, q - buf);\n break;\n }\n+\n+}\n+/* called when an ascii key is pressed */\n+void qemu_text_console_handle_keysym(QemuTextConsole *s, int keysym)\n+{\n+ vt100_keysym(&s->vt, keysym);\n }\n \n static void text_console_update(void *opaque, console_ch_t *chardata)\n","prefixes":["v2","27/67"]}