{"id":2222093,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222093/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-24-231416f76dc3@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410-qemu-vnc-v2-24-231416f76dc3@redhat.com>","date":"2026-04-10T19:18:46","name":"[v2,24/67] ui/console-vc: unify the write path","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9c31e3f9961940f002a111aa6cd3313bf9b0d716","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-24-231416f76dc3@redhat.com/mbox/","series":[{"id":499494,"url":"http://patchwork.ozlabs.org/api/1.1/series/499494/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494","date":"2026-04-10T19:18:23","name":"ui: add standalone VNC server over D-Bus","version":2,"mbox":"http://patchwork.ozlabs.org/series/499494/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222093/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222093/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=DLlyXWy/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsms22DTTz1y2d\n\tfor ; Sat, 11 Apr 2026 05:22:14 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBHQG-00006V-1u; Fri, 10 Apr 2026 15:21:44 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHPw-0007RM-Vw\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:21:25 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHPv-0001bs-H4\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:21:24 -0400","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-488-LoRkLvprNCKrTKnzoDH0cw-1; Fri,\n 10 Apr 2026 15:21:19 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id AE0A719541AE; Fri, 10 Apr 2026 19:21:18 +0000 (UTC)","from localhost (unknown [10.44.22.4])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 354963000C16; Fri, 10 Apr 2026 19:21:16 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775848882;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=NqgxaN0EQEIbeZuRUaIOBEyt8RA8ds5FauGylw3GKZI=;\n b=DLlyXWy/AseaiBsRY/9qA8vd2jE/Ljyan2+nClKvuOKxsxPf7+yz1FeTsGsvN/EOW51rhL\n z3GlXXZ+exDo7TmgVPfzVkDIzbCfvlzokxTia7bEQFW93eEnkYQCTGo/qSVCvnhGLvjYRf\n JiV50i3KVeZ9Q7rWpm0fIXiENlJO3Q8=","X-MC-Unique":"LoRkLvprNCKrTKnzoDH0cw-1","X-Mimecast-MFC-AGG-ID":"LoRkLvprNCKrTKnzoDH0cw_1775848878","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Fri, 10 Apr 2026 23:18:46 +0400","Subject":"[PATCH v2 24/67] ui/console-vc: unify the write path","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260410-qemu-vnc-v2-24-231416f76dc3@redhat.com>","References":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","In-Reply-To":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=3629;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=rgqd45Vmz4hS+I+bczTQrpcE/mb67kdr0yCJlR22ZB0=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0UPqYOF1m5ya5lKn8/auDoKhIR4oTiZOU5Z\n ZKPp/TtlpiJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNFAAKCRDa6OEJdZac\n 5fT8EACWINBORQ4Cenul7+RKJwjvxKGY8Lj/dKFDOjE20z7ETotmTAuY7BRoWF7HAcwQtP3opP2\n 07q1KC0mYlG/UZ3nuOAO+BUPUQn21V3RpOSECDHDKwnm12oviNhOAHRK3+qumV2dl51WdzdUjnB\n gCJBBA34f5//vEqAs+Rka0MUUBqN3JswcDTZUeu8yjaBw1m72nmv1sCrSVyeMoSClY4Ix8ikbdh\n vbJBbIwFI46HiwzTob44+MH7G3C/8kVgxlLJDCCd7hZRa9ZFmxFzXuU0Mi6hjsQWD3jreDmCLLg\n 51J7nGDyVw7KS4YF1abGFdwkos5QVdrV1zMv06uHHWj/IuEsEWOXNx2GNF845JCX28Dy3ebhsdH\n HVlpm8EtkiqFl0/Z56sPG0Ey99k1C/5r8cb8MaDan932VaSsMNLH6zAEgP+o5fGSnoAaOaOncI6\n FPWEJ0Y+vFxvkT1s4SSavyDypMHYwoxjeJgGE67mDMcmIzWFaU+obYd4Ja8Jngwrhhqp5Nk7tOQ\n Zq/VBPkHtIrgXq0A20sDt1bhs/wWVYvTGivNQS+oVn/tKUoxH5YOWcthy3h+kpTOQ7ToOL1hgf/\n tlYvF4KfEn5DC98bkNF1q3X2WSH7VYDNszGk9mjQ/xtiZgrmSSWDOqwtDdRvxLt3+Ii7nYWMOfs\n RoCnxac6ibCqukQ==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"7","X-Spam_score":"0.7","X-Spam_bar":"/","X-Spam_report":"(0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"VT100 escape responses (DSR) used qemu_chr_be_write() to write directly\nto the chardev backend, bypassing the output FIFO, while keyboard input\nwent through the FIFO and flush path. This inconsistency could lead to\nout-of-order delivery when both paths are active.\n\nIntroduce qemu_text_console_write() that pushes data into the output\nFIFO and flushes it, and use it for both keyboard input and VT100\nresponses. Remove the now-unnecessary vc_respond_str() helper. Rename\nkbd_send_chars() to qemu_text_console_flush() to better reflect its\npurpose.\n\nReviewed-by: Philippe Mathieu-Daudé \nSigned-off-by: Marc-André Lureau \n---\n ui/console-vc.c | 29 ++++++++++++++---------------\n 1 file changed, 14 insertions(+), 15 deletions(-)","diff":"diff --git a/ui/console-vc.c b/ui/console-vc.c\nindex a367622d819..bba1fe614ef 100644\n--- a/ui/console-vc.c\n+++ b/ui/console-vc.c\n@@ -299,7 +299,7 @@ static void vt100_scroll(QemuVT100 *vt, int ydelta)\n vt100_refresh(vt);\n }\n \n-static void kbd_send_chars(QemuTextConsole *s)\n+static void qemu_text_console_flush(QemuTextConsole *s)\n {\n uint32_t len, avail;\n \n@@ -316,13 +316,21 @@ static void kbd_send_chars(QemuTextConsole *s)\n }\n }\n \n+static void qemu_text_console_write(QemuTextConsole *s, const void *buf, size_t len)\n+{\n+ uint32_t num_free;\n+\n+ num_free = fifo8_num_free(&s->out_fifo);\n+ fifo8_push_all(&s->out_fifo, buf, MIN(num_free, len));\n+ qemu_text_console_flush(s);\n+}\n+\n /* called when an ascii key is pressed */\n void qemu_text_console_handle_keysym(QemuTextConsole *s, int keysym)\n {\n QemuVT100 *vt = &s->vt;\n uint8_t buf[16], *q;\n int c;\n- uint32_t num_free;\n \n switch(keysym) {\n case QEMU_KEY_CTRL_UP:\n@@ -361,9 +369,7 @@ void qemu_text_console_handle_keysym(QemuTextConsole *s, int keysym)\n if (vt->echo) {\n qemu_chr_write(s->chr, buf, q - buf, true);\n }\n- num_free = fifo8_num_free(&s->out_fifo);\n- fifo8_push_all(&s->out_fifo, buf, MIN(num_free, q - buf));\n- kbd_send_chars(s);\n+ qemu_text_console_write(s, buf, q - buf);\n break;\n }\n }\n@@ -677,13 +683,6 @@ static void vc_put_one(VCChardev *vc, int ch)\n vt->x++;\n }\n \n-static void vc_respond_str(VCChardev *vc, const char *buf)\n-{\n- QemuTextConsole *s = vc->console;\n-\n- qemu_chr_be_write(s->chr, (const uint8_t *)buf, strlen(buf));\n-}\n-\n /* set cursor, checking bounds */\n static void vc_set_cursor(VCChardev *vc, int x, int y)\n {\n@@ -1028,13 +1027,13 @@ static void vc_putchar(VCChardev *vc, int ch)\n switch (vc->esc_params[0]) {\n case 5:\n /* report console status (always succeed)*/\n- vc_respond_str(vc, \"\\033[0n\");\n+ qemu_text_console_write(s, \"\\033[0n\", 4);\n break;\n case 6:\n /* report cursor position */\n response = g_strdup_printf(\"\\033[%d;%dR\",\n vt->y + 1, vt->x + 1);\n- vc_respond_str(vc, response);\n+ qemu_text_console_write(s, response, strlen(response));\n break;\n }\n break;\n@@ -1194,7 +1193,7 @@ static void vc_chr_accept_input(Chardev *chr)\n {\n VCChardev *drv = VC_CHARDEV(chr);\n \n- kbd_send_chars(drv->console);\n+ qemu_text_console_flush(drv->console);\n }\n \n static void vc_chr_set_echo(Chardev *chr, bool echo)\n","prefixes":["v2","24/67"]}