{"id":2222090,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222090/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-22-231416f76dc3@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410-qemu-vnc-v2-22-231416f76dc3@redhat.com>","date":"2026-04-10T19:18:44","name":"[v2,22/67] ui/console-vc: refactor text_console_resize() into vt100_set_image()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5f280e0be7ec81fef44b36085de5625541554f1c","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-22-231416f76dc3@redhat.com/mbox/","series":[{"id":499494,"url":"http://patchwork.ozlabs.org/api/1.1/series/499494/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494","date":"2026-04-10T19:18:23","name":"ui: add standalone VNC server over D-Bus","version":2,"mbox":"http://patchwork.ozlabs.org/series/499494/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222090/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222090/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=ETf79tEt;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsmrh3vzjz1y2d\n\tfor ; Sat, 11 Apr 2026 05:21:56 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBHPo-0006em-Cm; Fri, 10 Apr 2026 15:21:16 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHPj-0005wP-P8\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:21:11 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHPi-0001aq-8s\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:21:11 -0400","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-209-2ArQdatZMJKQFVrASN263Q-1; Fri,\n 10 Apr 2026 15:21:07 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 8888819560AA; Fri, 10 Apr 2026 19:21:06 +0000 (UTC)","from localhost (unknown [10.44.22.4])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 159FB1800357; Fri, 10 Apr 2026 19:21:04 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775848869;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=HrbyBCyRCrUTpCfsw4FXQ87PN8E4xHrqUwFNeptatsY=;\n b=ETf79tEtEDc2c9YmK71Xu8/AjQuJdMW4CsFKqe27Ydnp83ibnQMMeqYfl3zU6mkN4kxmz1\n 2WRo7QLa9UzmLHlTNGOErBXt/TR8+Om8UwDqdx/H8ht7tU1jgZIrMI2M5T/msqIcnUkBCA\n mDjldvS3Kfahl0VdUc8E39f0Rrj+SvQ=","X-MC-Unique":"2ArQdatZMJKQFVrASN263Q-1","X-Mimecast-MFC-AGG-ID":"2ArQdatZMJKQFVrASN263Q_1775848866","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Fri, 10 Apr 2026 23:18:44 +0400","Subject":"[PATCH v2 22/67] ui/console-vc: refactor text_console_resize()\n into vt100_set_image()","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260410-qemu-vnc-v2-22-231416f76dc3@redhat.com>","References":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","In-Reply-To":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=3458;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=hGNex5Z8ktmnpUuKhaz5DK+qq1hXD5X1R8yragDrE5U=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0U+HIV6XWW8Qz/7MOjA4aUz0nyXldqx1LE/\n BwtXpzSRiiJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNFAAKCRDa6OEJdZac\n 5aF0EACOYeHXi6Btb2ohEhaIeQA05wJCLLgak/Hz884HpdYIetGTvquYONb5bVlTX4B4ANhmLNS\n Yo9iNdGwpEhCPqo/x6cKlx1V+8xtJnZv7Im/3evQO6a+PIxCwxiryfEX8UJnpFjVN+3HSA/+uJH\n HSZQDKytWq1UcCPnaeD7Xjb9ltPyqbik+lJ+QourrHILp9170d+E9gyRAtmnLARt+QoAxcSHgxD\n gkKDC6mCgPCxOAc2vFnL4n/Ku60jZxV9MbtmRf+z/GspQEBHb5XFKp4G1S0o9oUCFAPeETk5p/V\n ZXaWO4iGc7Sas/SxKsvNS1+cA+odxpjBpnDcWeYA6bxoOvN0zZBXsbEUWZ9LA2Gh2/Q0VnZtUhQ\n GVPch1iUpf3+CtkfIqTmJDD4vHJtVIJwz8ML5+WV0zEpIjkVf3EPiKXfjf5xsPwjbL+6E5RpWTt\n VPwDYRzHZ0Hhfq8GVut5UxbhPG1SsFguqAJCqe9+yhAW2LLGopx0On+g/uqRCwaEpVCo4Z8mujl\n Zr7FxdNskKkuMnEw1ZgHpOEhfLBJpRpNmMtDS6sCyYnbGqQHW9yEu8pPwO7Ma3BtOAkIuWTWj/i\n qcYEqO4d4x/RPlEUivfdutKupSRi/NF7Sz+7FWHLZnG5EJxRtzLNT6oQxp6j/AOMleOD2STpvyN\n 3UXRk2/m35ksEyQ==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"7","X-Spam_score":"0.7","X-Spam_bar":"/","X-Spam_report":"(0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Decouple the resize logic from QemuTextConsole by operating on\nQemuVT100 and taking a pixman_image_t directly, instead of reaching\ninto the console's scanout surface. The callers now pass the image\nexplicitly, which makes the VT100 layer independent of the console\nobject hierarchy.\n\nReviewed-by: Philippe Mathieu-Daudé \nSigned-off-by: Marc-André Lureau \n---\n ui/console-vc.c | 40 +++++++++++++++++++---------------------\n 1 file changed, 19 insertions(+), 21 deletions(-)","diff":"diff --git a/ui/console-vc.c b/ui/console-vc.c\nindex c6846af3697..85c794062fc 100644\n--- a/ui/console-vc.c\n+++ b/ui/console-vc.c\n@@ -12,6 +12,7 @@\n #include \"ui/console.h\"\n #include \"ui/cp437.h\"\n \n+#include \"pixman.h\"\n #include \"trace.h\"\n #include \"console-priv.h\"\n \n@@ -397,44 +398,41 @@ static void text_console_update(void *opaque, console_ch_t *chardata)\n }\n }\n \n-static void text_console_resize(QemuTextConsole *t)\n+static void vt100_set_image(QemuVT100 *vt, pixman_image_t *image)\n {\n- QemuConsole *s = QEMU_CONSOLE(t);\n TextCell *cells, *c, *c1;\n int w1, x, y, last_width, w, h;\n \n- assert(s->scanout.kind == SCANOUT_SURFACE);\n-\n- t->vt.image = s->surface->image;\n- w = pixman_image_get_width(t->vt.image) / FONT_WIDTH;\n- h = pixman_image_get_height(t->vt.image) / FONT_HEIGHT;\n- if (w == t->vt.width && h == t->vt.height) {\n+ vt->image = image;\n+ w = pixman_image_get_width(image) / FONT_WIDTH;\n+ h = pixman_image_get_height(image) / FONT_HEIGHT;\n+ if (w == vt->width && h == vt->height) {\n return;\n }\n \n- last_width = t->vt.width;\n- t->vt.width = w;\n- t->vt.height = h;\n+ last_width = vt->width;\n+ vt->width = w;\n+ vt->height = h;\n \n- w1 = MIN(t->vt.width, last_width);\n+ w1 = MIN(vt->width, last_width);\n \n- cells = g_new(TextCell, t->vt.width * t->vt.total_height + 1);\n- for (y = 0; y < t->vt.total_height; y++) {\n- c = &cells[y * t->vt.width];\n+ cells = g_new(TextCell, vt->width * vt->total_height + 1);\n+ for (y = 0; y < vt->total_height; y++) {\n+ c = &cells[y * vt->width];\n if (w1 > 0) {\n- c1 = &t->vt.cells[y * last_width];\n+ c1 = &vt->cells[y * last_width];\n for (x = 0; x < w1; x++) {\n *c++ = *c1++;\n }\n }\n- for (x = w1; x < t->vt.width; x++) {\n+ for (x = w1; x < vt->width; x++) {\n c->ch = ' ';\n c->t_attrib = TEXT_ATTRIBUTES_DEFAULT;\n c++;\n }\n }\n- g_free(t->vt.cells);\n- t->vt.cells = cells;\n+ g_free(vt->cells);\n+ vt->cells = cells;\n }\n \n static void vc_put_lf(VCChardev *vc)\n@@ -1137,7 +1135,7 @@ static void text_console_invalidate(void *opaque)\n QemuTextConsole *s = QEMU_TEXT_CONSOLE(opaque);\n \n if (!QEMU_IS_FIXED_TEXT_CONSOLE(s)) {\n- text_console_resize(QEMU_TEXT_CONSOLE(s));\n+ vt100_set_image(&s->vt, QEMU_CONSOLE(s)->surface->image);\n }\n vt100_refresh(&s->vt);\n }\n@@ -1257,7 +1255,7 @@ static bool vc_chr_open(Chardev *chr, ChardevBackend *backend, Error **errp)\n \n /* set current text attributes to default */\n drv->t_attrib = TEXT_ATTRIBUTES_DEFAULT;\n- text_console_resize(s);\n+ vt100_set_image(&s->vt, QEMU_CONSOLE(s)->surface->image);\n \n if (chr->label) {\n char *msg;\n","prefixes":["v2","22/67"]}