{"id":2222089,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222089/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-17-231416f76dc3@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410-qemu-vnc-v2-17-231416f76dc3@redhat.com>","date":"2026-04-10T19:18:39","name":"[v2,17/67] ui/console-vc: make show_cursor() take vt100","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5bc0044307bcd3f337174bdb7a7361f3e62d41a8","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-17-231416f76dc3@redhat.com/mbox/","series":[{"id":499494,"url":"http://patchwork.ozlabs.org/api/1.1/series/499494/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494","date":"2026-04-10T19:18:23","name":"ui: add standalone VNC server over D-Bus","version":2,"mbox":"http://patchwork.ozlabs.org/series/499494/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222089/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222089/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=ghtcvanh;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsmrc5Z5Mz1y2d\n\tfor ; Sat, 11 Apr 2026 05:21:52 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBHPl-0006CA-F5; Fri, 10 Apr 2026 15:21:13 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHPJ-00059V-8H\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:20:50 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHPH-0001Dw-6k\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:20:44 -0400","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-597-Ub6Cv9fSM9-U5Yzm9hE_iw-1; Fri,\n 10 Apr 2026 15:20:38 -0400","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id EF328180034C; Fri, 10 Apr 2026 19:20:37 +0000 (UTC)","from localhost (unknown [10.44.22.4])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id D049D195608E; Fri, 10 Apr 2026 19:20:36 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775848840;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=wzw0Q7jMhFS0CoqoqexwKXYGuuONVk8KgOpTU6X44uM=;\n b=ghtcvanhfLeFMsADe2qeAp6wOQMFQVXeZDYlQO0BILXAqrFiSNkZgq76toWSwXfIYOf8+y\n gNILu+9QlSrKTMjNh8Omm5lqS6tC5InMjAxvIOACqQHwhHRoOy0pQAViAv7KwybdnRLYkU\n o+eLwC/uV0g8yT03ohoak82bNHVzFjs=","X-MC-Unique":"Ub6Cv9fSM9-U5Yzm9hE_iw-1","X-Mimecast-MFC-AGG-ID":"Ub6Cv9fSM9-U5Yzm9hE_iw_1775848838","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Fri, 10 Apr 2026 23:18:39 +0400","Subject":"[PATCH v2 17/67] ui/console-vc: make show_cursor() take vt100","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260410-qemu-vnc-v2-17-231416f76dc3@redhat.com>","References":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","In-Reply-To":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=2266;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=+MJMtm41zBshumDQWeZwFchRZmla0eMFHyqBboYlYwo=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0UGQCSmj+OldGGyA9i77jQ878tmP6Pc3ITH\n pLbwbHSHAKJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNFAAKCRDa6OEJdZac\n 5SqgD/97+RkVyBjeuglfl75mfumZ/yZm/7dbuf5OqVEMor3dKFyhAXcIQslj/EgOWtvVnAd0JX8\n EyvjnrzZJUiXvzYtWxxBoLbghl+8AWH+sFYiYKJrJscypzZWaE2BwLliSUC8JQEKheko2VmEu14\n AuvZjYaXhQz36Bu+qT3CJ2/RB/5px4CmZq6ICx9WhEkeuBYRS4TbK0zGfCXO2WrxZ7QychQ9B9+\n d1t8lpcgFMJYkuJpLII79Nqf4TTlInjAPUY5C9Y2BmWtu/0kvhdk8nV/8pr9L/Y7rDR+ZWLyu0/\n uCNNQ3G0L8jxe1RTlp0+eIvw0RJQ6lAMbCKgW7k2Y5k8RA30lX7DMrnBj04CSSgB/ztFRvr1VXh\n lKlmdlt23UJUzQCo+fX1AangdmUh84Dj7va9Jc3DGiu07M9/azFeRT2eto9wC0NigM7OXwSo/VQ\n qMD140wKNGBh5SdMInIXKcE3lTjsKqyO3WLNYRca90L+xspW5w2AKqtdf0/vWx+cLzwKwVZwgcu\n u69+GQwFpcaUruWEetts7SYrS1XPP9kQBc8NWdYu7XZJDhAGm4NNyqDGELnQl5SnV+MIFLRjLy1\n lcWT0GUJjtHWrHvHjPiXGrzYuCDojFL1Ca909yx+ZA7De1AxgOOcG4hiciF/Xmsi9cYQY7c/o60\n ZKnmYjATFXsRcqw==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Decouples glyph rendering from the console object,\ncontinuing the QemuVT100 abstraction introduced in the previous commits.\n\nReviewed-by: Philippe Mathieu-Daudé \nSigned-off-by: Marc-André Lureau \n---\n ui/console-vc.c | 15 +++++++--------\n 1 file changed, 7 insertions(+), 8 deletions(-)","diff":"diff --git a/ui/console-vc.c b/ui/console-vc.c\nindex 9566ce592f2..61d72a0cc27 100644\n--- a/ui/console-vc.c\n+++ b/ui/console-vc.c\n@@ -195,9 +195,8 @@ static void vt100_invalidate_xy(QemuVT100 *vt, int x, int y)\n }\n }\n \n-static void console_show_cursor(QemuTextConsole *s, int show)\n+static void vt100_show_cursor(QemuVT100 *vt, int show)\n {\n- QemuVT100 *vt = &s->vt;\n TextCell *c;\n int y, y1;\n int x = vt->x;\n@@ -217,11 +216,11 @@ static void console_show_cursor(QemuTextConsole *s, int show)\n if (show && cursor_visible_phase) {\n TextAttributes t_attrib = TEXT_ATTRIBUTES_DEFAULT;\n t_attrib.invers = !(t_attrib.invers); /* invert fg and bg */\n- vt100_putcharxy(&s->vt, x, y, c->ch, &t_attrib);\n+ vt100_putcharxy(vt, x, y, c->ch, &t_attrib);\n } else {\n- vt100_putcharxy(&s->vt, x, y, c->ch, &(c->t_attrib));\n+ vt100_putcharxy(vt, x, y, c->ch, &(c->t_attrib));\n }\n- vt100_invalidate_xy(&s->vt, x, y);\n+ vt100_invalidate_xy(vt, x, y);\n }\n }\n \n@@ -253,7 +252,7 @@ static void console_refresh(QemuTextConsole *s)\n y1 = 0;\n }\n }\n- console_show_cursor(s, 1);\n+ vt100_show_cursor(&s->vt, 1);\n dpy_gfx_update(QEMU_CONSOLE(s), 0, 0, w, h);\n }\n \n@@ -1084,11 +1083,11 @@ static int vc_chr_write(Chardev *chr, const uint8_t *buf, int len)\n vt->update_y0 = vt->height * FONT_HEIGHT;\n vt->update_x1 = 0;\n vt->update_y1 = 0;\n- console_show_cursor(s, 0);\n+ vt100_show_cursor(vt, 0);\n for(i = 0; i < len; i++) {\n vc_putchar(drv, buf[i]);\n }\n- console_show_cursor(s, 1);\n+ vt100_show_cursor(vt, 1);\n if (vt->update_x0 < vt->update_x1) {\n dpy_gfx_update(QEMU_CONSOLE(s), vt->update_x0, vt->update_y0,\n vt->update_x1 - vt->update_x0,\n","prefixes":["v2","17/67"]}