{"id":2222087,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222087/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-23-231416f76dc3@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410-qemu-vnc-v2-23-231416f76dc3@redhat.com>","date":"2026-04-10T19:18:45","name":"[v2,23/67] ui/console-vc: move vc_put_lf() to VT100 layer as vt100_put_lf()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"77eff0c5e1b17bab789a4494d031d28bf2797f4e","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-23-231416f76dc3@redhat.com/mbox/","series":[{"id":499494,"url":"http://patchwork.ozlabs.org/api/1.1/series/499494/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494","date":"2026-04-10T19:18:23","name":"ui: add standalone VNC server over D-Bus","version":2,"mbox":"http://patchwork.ozlabs.org/series/499494/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222087/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222087/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=jSfT/D3/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsmrZ75Gbz1y2d\n\tfor ; Sat, 11 Apr 2026 05:21:50 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBHQ0-0007Un-4E; Fri, 10 Apr 2026 15:21:28 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHPp-0006uI-Pu\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:21:18 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHPo-0001bG-52\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:21:17 -0400","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-198-33THIKEINRa3I6ztWQeWAA-1; Fri,\n 10 Apr 2026 15:21:13 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 938011800371; Fri, 10 Apr 2026 19:21:12 +0000 (UTC)","from localhost (unknown [10.44.22.4])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 68DE718002A6; Fri, 10 Apr 2026 19:21:10 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775848875;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=7wOl7UndXUNuRv23Xd7plO7oSwHYgXZFefU88CGlrWo=;\n b=jSfT/D3/aoQ+x8ejo9asTSgef4TKTwdwVQh0QoERE+J5VajlQaFFH8rupxng0UtawYz+YT\n GwzwFWKZpolEm0iPx/00GcLmlqSitoC2l/hKPBUvTSgJwDyATZFphjQA6jiyKb00rKTVH8\n TvQPj+EMMEiqcBbcSuAMmciYBnuBkOs=","X-MC-Unique":"33THIKEINRa3I6ztWQeWAA-1","X-Mimecast-MFC-AGG-ID":"33THIKEINRa3I6ztWQeWAA_1775848872","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Fri, 10 Apr 2026 23:18:45 +0400","Subject":"[PATCH v2 23/67] ui/console-vc: move vc_put_lf() to VT100 layer as\n vt100_put_lf()","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260410-qemu-vnc-v2-23-231416f76dc3@redhat.com>","References":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","In-Reply-To":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1898;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=AbfZ7yrsZMJ8QK+onxLgGeGlwus1yT9WAbcxhWv1EDs=;\n b=kA0DAAoB2ujhCXWWnOUByyZiAGnZTRSgbJELCZ8+YVtBLxn0WLm/AHqIyV2ivFLGAgPYD2etz\n YkCMwQAAQoAHRYhBIepvZM/h8YG0nb2Ldro4Ql1lpzlBQJp2U0UAAoJENro4Ql1lpzlMxoP/RSI\n elvMxJ19JraDqcVVMUxnkrDAmV/xshygLsDF52ImukkKWInt3zGyhphnjjMtlKnT9v7IjtIX8Li\n g/t5mOyVjlFK1bqSq6suD9dvt/6+YH0JejpJ8MSIAVjMWjIhw5UJdtXRSS8Z3Q7EFk7mRbblDlL\n 7JQFZVJmqiaIWMgqkztaScjpGNeaOoWePErc6mjuz46rON/4y7qYUHzc7HRB7LU+k/7pQQgs0/V\n Ry6tajdhRwphgnxFoFoLGwJUoDuwzAyYBbJxLIGV/4RlzJSJUuyuP+J/pVNIY9h/hArN3mz/jZe\n Ww7F65Z7FINndZJW01D5I7KBL/MHR3YezSpH+Sz93Fy2sKajaW2fuor8HMMv+oeNLuaeHx6z9jY\n 91UhLypBjLZfAwYUp5LTEBF7LYMIfCBZyJZcq/VfAAhOCs4hDbqCMJkZ2IC5i3derqCjCU40lpZ\n 56CgVgnUkBe/pKCT1dX/H2umtxBNanTcA9OQZU6fy86TZWH8LRvyXBadK+Ioa8hVOBHrCeKIazK\n NAwL0vLUhwEfFVAFbvXKk7wtGK3x6fuZSYrhK4Q2eTzWc8QVpbYdk1N0xYtCyQKeil9tpNGL/0X\n pVt4gaEO49hA/OvChzOwM5ymg08xTc88gJd4n2uHKEZ3tEym7nzOBl0QxQ5j5CDHUulfm6kFGPG\n zOoBp","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Decouple the line-feed handling from VCChardev by operating on\nQemuVT100 directly. The function no longer needs the chardev or\nconsole pointers — callers pass &s->vt instead. This continues the\neffort to make the VT100 terminal emulation self-contained.\n\nReviewed-by: Philippe Mathieu-Daudé \nSigned-off-by: Marc-André Lureau \n---\n ui/console-vc.c | 10 ++++------\n 1 file changed, 4 insertions(+), 6 deletions(-)","diff":"diff --git a/ui/console-vc.c b/ui/console-vc.c\nindex 85c794062fc..a367622d819 100644\n--- a/ui/console-vc.c\n+++ b/ui/console-vc.c\n@@ -435,10 +435,8 @@ static void vt100_set_image(QemuVT100 *vt, pixman_image_t *image)\n vt->cells = cells;\n }\n \n-static void vc_put_lf(VCChardev *vc)\n+static void vt100_put_lf(QemuVT100 *vt)\n {\n- QemuTextConsole *s = vc->console;\n- QemuVT100 *vt = &s->vt;\n TextCell *c;\n int x, y1;\n \n@@ -669,7 +667,7 @@ static void vc_put_one(VCChardev *vc, int ch)\n if (vt->x >= vt->width) {\n /* line wrap */\n vt->x = 0;\n- vc_put_lf(vc);\n+ vt100_put_lf(vt);\n }\n y1 = (vt->y_base + vt->y) % vt->total_height;\n c = &vt->cells[y1 * vt->width + vt->x];\n@@ -853,7 +851,7 @@ static void vc_putchar(VCChardev *vc, int ch)\n vt->x = 0;\n break;\n case '\\n': /* newline */\n- vc_put_lf(vc);\n+ vt100_put_lf(&s->vt);\n break;\n case '\\b': /* backspace */\n if (vt->x > 0)\n@@ -862,7 +860,7 @@ static void vc_putchar(VCChardev *vc, int ch)\n case '\\t': /* tabspace */\n if (vt->x + (8 - (vt->x % 8)) > vt->width) {\n vt->x = 0;\n- vc_put_lf(vc);\n+ vt100_put_lf(vt);\n } else {\n vt->x = vt->x + (8 - (vt->x % 8));\n }\n","prefixes":["v2","23/67"]}