{"id":2222084,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222084/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-19-231416f76dc3@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410-qemu-vnc-v2-19-231416f76dc3@redhat.com>","date":"2026-04-10T19:18:41","name":"[v2,19/67] ui/console-vc: console_refresh() -> vt100_refresh()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"494a96b180f59ee89fe51e4531c25c10118c8fce","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-19-231416f76dc3@redhat.com/mbox/","series":[{"id":499494,"url":"http://patchwork.ozlabs.org/api/1.1/series/499494/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494","date":"2026-04-10T19:18:23","name":"ui: add standalone VNC server over D-Bus","version":2,"mbox":"http://patchwork.ozlabs.org/series/499494/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222084/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222084/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=NjWfm8Tv;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsmr24W6wz1y2d\n\tfor ; Sat, 11 Apr 2026 05:21:22 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBHPk-00062S-Qe; Fri, 10 Apr 2026 15:21:12 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHPU-0005N9-Ss\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:21:00 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHPQ-0001Q5-SB\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:20:55 -0400","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-681-nEzCD_YROImaoDvcWAUpFw-1; Fri,\n 10 Apr 2026 15:20:50 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 79AB8180044D; Fri, 10 Apr 2026 19:20:49 +0000 (UTC)","from localhost (unknown [10.44.22.4])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 46748180057F; Fri, 10 Apr 2026 19:20:47 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775848851;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=35NB0NPv2qOWBVLdjvh0a4RCEHDwikxV3x+wq6dGcfw=;\n b=NjWfm8TvlfVVLRDLeTO+ttXLaOixwvHJJmVP2XKFXF6MmcwICK1cvPjtxqNUdF2yn/7WNp\n u+5XuVKd6O9pfd2TPOOMLVT8oDs5Cp+hGlljzQbrAi120q3B+K0Ka66WUeHmH8Blg3kXvb\n vsDDr5xOc3usiC5uf+Oh5uiYylRLjNU=","X-MC-Unique":"nEzCD_YROImaoDvcWAUpFw-1","X-Mimecast-MFC-AGG-ID":"nEzCD_YROImaoDvcWAUpFw_1775848849","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Fri, 10 Apr 2026 23:18:41 +0400","Subject":"[PATCH v2 19/67] ui/console-vc: console_refresh() -> vt100_refresh()","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260410-qemu-vnc-v2-19-231416f76dc3@redhat.com>","References":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","In-Reply-To":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1727;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=Alv36LrSEk9pffbsC7R8BXcgJH+s8HLIVfm8/6cC23I=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0UTC5YnAx3mhJRtjWlIqasqVJDGZhAcwAaI\n +MFO5Xw9CCJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNFAAKCRDa6OEJdZac\n 5aFEEACLRFsKMZr8qCaCwzt+QoEcPge1PEDuVs9OqT+ZcBrOsXsJfHQ/69gbwYBF7aI2x3MkQLf\n s4PWaUpME6JhZuDP5SDGAe+5saE/E11UR0YTk3cwzi7Nl6orGiRwlMfnwPpJc7IRuCmpO6v5YHj\n z8YGHYoWFwbqY/DgW62pVwXfxOoPl8qn7LAjLal/v+r0ir81BKLDAaZKBJecY9A6bE4d5goSCZF\n 5xmlXxXd6stNxu3xxpuGzf5dY+3lZQnIR3z87GFY7+aOMHKpoNRw3LyZ+jEXbv7WS1oZNsfGinC\n UZDFkLQbgOL/pQ7As7sSLM4SWFZZ9OeNzCuov74IwSrWvRcrtlU4a0x7eswfJf7J1eb5VryrE4/\n lFgFqmlpB1JGw+m4BjxwOkGXU3uLIn1RVRxHRwMT9KZ6IAqKuGYh0Qzw1VM11lv+JuOS+TyZRPY\n u+ctXTFpSygNVevk8rLw2MHKdy/Vcz7myDcViwRRPUM9zbCMxprmQt5B8QrZlHo+SB9nR3jRNTs\n OcYM3xwcII7O7LJJTXlkNHWqRGvYz2fIhB2zIblYK8ErVkULURIohF+dwm9nIvKa+52fX9rg70K\n 20Bg9SsWRWMmuGf8b2j4JJvBNauw7ekAt/OUGrpv2U1oMQKT0Sh42AEgE7IaXz1F1ulsVq5LCx/\n 0jyXfbQXrvaaouQ==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"This decouples glyph rendering from the console object, continuing the\nQemuVT100 abstraction introduced in the previous commits.\n\nReviewed-by: Philippe Mathieu-Daudé \nSigned-off-by: Marc-André Lureau \n---\n ui/console-vc.c | 11 +++++------\n 1 file changed, 5 insertions(+), 6 deletions(-)","diff":"diff --git a/ui/console-vc.c b/ui/console-vc.c\nindex f8682d2d1dc..d46dcb6a678 100644\n--- a/ui/console-vc.c\n+++ b/ui/console-vc.c\n@@ -232,9 +232,8 @@ static void vt100_image_update(QemuVT100 *vt, int x, int y, int width, int heigh\n vt->image_update(vt, x, y, width, height);\n }\n \n-static void console_refresh(QemuTextConsole *s)\n+static void vt100_refresh(QemuVT100 *vt)\n {\n- QemuVT100 *vt = &s->vt;\n TextCell *c;\n int x, y, y1;\n int w = pixman_image_get_width(vt->image);\n@@ -260,8 +259,8 @@ static void console_refresh(QemuTextConsole *s)\n y1 = 0;\n }\n }\n- vt100_show_cursor(&s->vt, 1);\n- vt100_image_update(&s->vt, 0, 0, w, h);\n+ vt100_show_cursor(vt, 1);\n+ vt100_image_update(vt, 0, 0, w, h);\n }\n \n static void console_scroll(QemuTextConsole *s, int ydelta)\n@@ -291,7 +290,7 @@ static void console_scroll(QemuTextConsole *s, int ydelta)\n vt->y_displayed = vt->total_height - 1;\n }\n }\n- console_refresh(s);\n+ vt100_refresh(&s->vt);\n }\n \n static void kbd_send_chars(QemuTextConsole *s)\n@@ -1127,7 +1126,7 @@ static void text_console_invalidate(void *opaque)\n if (!QEMU_IS_FIXED_TEXT_CONSOLE(s)) {\n text_console_resize(QEMU_TEXT_CONSOLE(s));\n }\n- console_refresh(s);\n+ vt100_refresh(&s->vt);\n }\n \n static void\n","prefixes":["v2","19/67"]}