{"id":2222083,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222083/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-16-231416f76dc3@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410-qemu-vnc-v2-16-231416f76dc3@redhat.com>","date":"2026-04-10T19:18:38","name":"[v2,16/67] ui/console-vc: make invalidate_xy() take vt100","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"eb1b05eae572b38c61bcfd10e603822a7c499019","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-16-231416f76dc3@redhat.com/mbox/","series":[{"id":499494,"url":"http://patchwork.ozlabs.org/api/1.1/series/499494/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494","date":"2026-04-10T19:18:23","name":"ui: add standalone VNC server over D-Bus","version":2,"mbox":"http://patchwork.ozlabs.org/series/499494/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222083/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222083/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=ay3qL9Ko;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsmqz2lD3z20HT\n\tfor ; Sat, 11 Apr 2026 05:21:19 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBHPk-000613-F5; Fri, 10 Apr 2026 15:21:12 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHPE-00051f-37\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:20:41 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHPB-0001Aq-Jt\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:20:39 -0400","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-315-0Y_XP9TWOxqWfo6igi5P8Q-1; Fri,\n 10 Apr 2026 15:20:33 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 252BE180057A; Fri, 10 Apr 2026 19:20:32 +0000 (UTC)","from localhost (unknown [10.44.22.4])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 0053A180049F; Fri, 10 Apr 2026 19:20:30 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775848836;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=8Zn7scE4lRCbc2GAfCsAVHlUaaYW/OSWPb6ggmWUO1c=;\n b=ay3qL9Ko4/HQkmFF6coWUtig9OO7aGnGhW+MoS/tFHUlHe3WqSZXKKzA9abhRFoimKgxn+\n gUM2ZztM+uJGRa6Ujx3C5a2Jq8Ec8wtKZIq76v+pXkAnG+D1ntFU7VU/vUhsKmCvyujq9j\n 72z4KDzg6nifSy+efXLlyPg+RAkG0/A=","X-MC-Unique":"0Y_XP9TWOxqWfo6igi5P8Q-1","X-Mimecast-MFC-AGG-ID":"0Y_XP9TWOxqWfo6igi5P8Q_1775848832","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Fri, 10 Apr 2026 23:18:38 +0400","Subject":"[PATCH v2 16/67] ui/console-vc: make invalidate_xy() take vt100","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260410-qemu-vnc-v2-16-231416f76dc3@redhat.com>","References":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","In-Reply-To":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=2178;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=jvcgWFNlKqlrN3nVcfOXq9ZC2/xDMncef+UtF1pVUuQ=;\n b=owEBbAKT/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0U4AM+QDPfGOpu9rVejfoMBydoLI85vdCIg\n fuurh5dRjGJAjIEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNFAAKCRDa6OEJdZac\n 5eReD/jh99E1jBIhmZFu6EH1u+gN9rCYVbQAt93K5FTBe7UKKtuE2lJOx7Zx3yBTCn6uBLDy3hu\n qLNmKbr2mzrS2vRRhH4INv0EV3fKYfwn7ilJwbo1DJQkBZH1ouJi66Jiyd39xQc8c+XPvaJA9S4\n EZmoKoRzGULXNcPxuZ6ORdbSdgqraPZ0f1Bk9vp2VvZo6JvIgl2QyCInPrlZ3JxUplY6UB3CbPS\n XE2L4+p7SFkLDelLMSi1NUBdhF8I+yoYghSvbw7Dz0bo2OpqK4tOBPEFHj1pK1ZnDEpFaE55H1m\n xxeACkHmh54H2zPVB4VmNT+P/LIiQctndp8uCwEo9FJxWzb3FFcRizddWWb/CXiQFGPDs+yrPMZ\n fU1wet6DRPEErB6lsBxepWHOIhE+c//oIkfyOIuIV47GG3KVpCov0GQCN/s0OoAJ/fYVOcbG9tP\n IRAVdQwTnOSoPB/EAkTIqTtiMtGEb5UmR2p1cIk7RjmETaccdAHJeRGwp5pLTLqfaDsQ5ypoumw\n hjui2QJUBPNFfmcksDAAZRE1N7KT4w3MBK3I2iP+rIg8ZhbUWKNl+7DrE3m+t4BvjfjaTOfEjwL\n mMnwWkWQzj6f1j1YZxj6E1tYIJTFPMIlb/kRx0bPdtF77VPgA9PHY1xH/cb/Jj0foZa0IjdYEby\n 5dRdKfZWbP3x4","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"This decouples glyph rendering from the console object, continuing the\nQemuVT100 abstraction introduced in the previous commits.\n\nStyle fixes.\n\nReviewed-by: Philippe Mathieu-Daudé \nSigned-off-by: Marc-André Lureau \n---\n ui/console-vc.c | 23 +++++++++++------------\n 1 file changed, 11 insertions(+), 12 deletions(-)","diff":"diff --git a/ui/console-vc.c b/ui/console-vc.c\nindex cf087c64fb2..9566ce592f2 100644\n--- a/ui/console-vc.c\n+++ b/ui/console-vc.c\n@@ -179,21 +179,20 @@ static void vt100_putcharxy(QemuVT100 *vt, int x, int y, int ch,\n &fgcol, &bgcol, x, y, FONT_WIDTH, FONT_HEIGHT);\n }\n \n-static void invalidate_xy(QemuTextConsole *s, int x, int y)\n+static void vt100_invalidate_xy(QemuVT100 *vt, int x, int y)\n {\n- QemuVT100 *vt = &s->vt;\n-\n- if (!qemu_console_is_visible(QEMU_CONSOLE(s))) {\n- return;\n- }\n- if (vt->update_x0 > x * FONT_WIDTH)\n+ if (vt->update_x0 > x * FONT_WIDTH) {\n vt->update_x0 = x * FONT_WIDTH;\n- if (vt->update_y0 > y * FONT_HEIGHT)\n+ }\n+ if (vt->update_y0 > y * FONT_HEIGHT) {\n vt->update_y0 = y * FONT_HEIGHT;\n- if (vt->update_x1 < (x + 1) * FONT_WIDTH)\n+ }\n+ if (vt->update_x1 < (x + 1) * FONT_WIDTH) {\n vt->update_x1 = (x + 1) * FONT_WIDTH;\n- if (vt->update_y1 < (y + 1) * FONT_HEIGHT)\n+ }\n+ if (vt->update_y1 < (y + 1) * FONT_HEIGHT) {\n vt->update_y1 = (y + 1) * FONT_HEIGHT;\n+ }\n }\n \n static void console_show_cursor(QemuTextConsole *s, int show)\n@@ -222,7 +221,7 @@ static void console_show_cursor(QemuTextConsole *s, int show)\n } else {\n vt100_putcharxy(&s->vt, x, y, c->ch, &(c->t_attrib));\n }\n- invalidate_xy(s, x, y);\n+ vt100_invalidate_xy(&s->vt, x, y);\n }\n }\n \n@@ -594,7 +593,7 @@ static void vc_update_xy(VCChardev *vc, int x, int y)\n c = &vt->cells[y1 * vt->width + x];\n vt100_putcharxy(vt, x, y2, c->ch,\n &(c->t_attrib));\n- invalidate_xy(s, x, y2);\n+ vt100_invalidate_xy(&s->vt, x, y2);\n }\n }\n \n","prefixes":["v2","16/67"]}