{"id":2222081,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222081/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-12-231416f76dc3@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410-qemu-vnc-v2-12-231416f76dc3@redhat.com>","date":"2026-04-10T19:18:34","name":"[v2,12/67] ui/console: dispatch get_label() through QOM virtual method","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a476f19eb4e2c3c84685e53c7e5cc8479fe9e1e5","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-12-231416f76dc3@redhat.com/mbox/","series":[{"id":499494,"url":"http://patchwork.ozlabs.org/api/1.1/series/499494/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494","date":"2026-04-10T19:18:23","name":"ui: add standalone VNC server over D-Bus","version":2,"mbox":"http://patchwork.ozlabs.org/series/499494/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222081/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222081/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=ACcwmoiR;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsmqh1hw7z1y2d\n\tfor ; Sat, 11 Apr 2026 05:21:04 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBHOn-0004Gu-4F; Fri, 10 Apr 2026 15:20:13 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHOl-0004Aa-9x\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:20:11 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHOj-00015C-1m\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:20:10 -0400","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-230-Y0gyWIl_PmKPSk47N0Bkpw-1; Fri,\n 10 Apr 2026 15:20:07 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 87265195605E\n for ; Fri, 10 Apr 2026 19:20:06 +0000 (UTC)","from localhost (unknown [10.44.22.4])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 4E6BF3000C16; Fri, 10 Apr 2026 19:20:04 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775848808;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=0I2+yZ98E836Z2P9dlsrUG3JAUWuXDSLpAuU+eC392E=;\n b=ACcwmoiRaAZPt7oMemWY7eEpEw/WFRr1zpo7XVDsRr5J548c2KSZxN7jUQp/Q8JMOldkj0\n RaLgxbH9oeJW/wMfwGo3Frok8UgQa572sqHe1dPRYRXZft1toKCw+Wqo0mjHd2CphZQdLO\n cBnU/7SVY6OcnVqf5+RdTUbPD2Hkr0M=","X-MC-Unique":"Y0gyWIl_PmKPSk47N0Bkpw-1","X-Mimecast-MFC-AGG-ID":"Y0gyWIl_PmKPSk47N0Bkpw_1775848806","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Fri, 10 Apr 2026 23:18:34 +0400","Subject":"[PATCH v2 12/67] ui/console: dispatch get_label() through QOM\n virtual method","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260410-qemu-vnc-v2-12-231416f76dc3@redhat.com>","References":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","In-Reply-To":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=6932;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=VZpzpANVaAkXTsjt5tv6uI07yEgnJRkVBs8sY4GwLtQ=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0UCt4OpQ/403qw7n7WYHgEhNC/f6K6g/ErF\n LEGrqgB1NuJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNFAAKCRDa6OEJdZac\n 5ShKD/9rw3Bl3TP6Gk/yM+YumAzUovg5wDf4+x8X+9fwCbpMtti9dihwUC2XGk/dHm2jn+JOCAH\n RnwPmYSfgMQNFLCm+7SbSmw9NuX3r4MplJaVOsi2gUJs2Z8cvjMv3AxW3orFMHzkCs33cxzEkHS\n SZaqEje33lSSKDWTVDdFR95/TsKJ3ZK5TP79IjgG7kbo+laenNX0JmA4wcT29/cd3MmsO6E4Pu6\n 9bWDR769IjG2RsmlUVzKy/96gQ1bInmu7KnsrWemW529GH5bujdzjOIw0ejPpcXeqklK7hfC4zB\n Kk68L0jQzZbjVk1/0MwD77t52q+r59ucyGkIaNokSJMu+JqIj+S6ELm1W2N7vBEnX9ShaOSXsxL\n 3n+F5kdJ0FpUQuRZnRKw7junMuYcLz1bsfF3vzSAX0oEZp1Jk5duL0hYyGchlJ/0LI4reC/8ouJ\n NYgbQGzEHzyinCIs0WoB5AaSKZ5Dd38vIIvgqwss8S7KP1muuiCN6TQOTPPRkwfxTS/Bjp4Ur7J\n 1CycWb7CCLn5ksmNmVGAIA6yU3h3wTGsL1gqmZOvtpHkO88HoXvyrN5KGGECL9NnTHPzR+gy2Ka\n /H54wZ6ofUZhF0Z8a9jwY9nXGKo6d/ntQH530vuyMEM6IouodAlwZYzG4vlgMMLfZi3Ajcvrlp8\n Tng7/mtdQf59vDQ==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"7","X-Spam_score":"0.7","X-Spam_bar":"/","X-Spam_report":"(0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Replace the type-checking chain in qemu_console_get_label() (using\nQEMU_IS_GRAPHIC_CONSOLE/QEMU_IS_TEXT_CONSOLE) with a QemuConsoleClass\nvirtual method, allowing each console subclass to provide its own\nget_label implementation.\n\nReviewed-by: Daniel P. Berrangé \nSigned-off-by: Marc-André Lureau \n---\n include/ui/console.h | 2 +\n ui/console-priv.h | 1 -\n ui/console-vc-stubs.c | 6 ---\n ui/console-vc.c | 12 ++++--\n ui/console.c | 101 +++++++++++++++++++++++++++-----------------------\n 5 files changed, 65 insertions(+), 57 deletions(-)","diff":"diff --git a/include/ui/console.h b/include/ui/console.h\nindex 08082389f71..395a723e318 100644\n--- a/include/ui/console.h\n+++ b/include/ui/console.h\n@@ -129,6 +129,8 @@ void console_handle_touch_event(QemuConsole *con,\n \n struct QemuConsoleClass {\n ObjectClass parent_class;\n+\n+ char * (*get_label)(QemuConsole *con);\n };\n \n typedef struct ScanoutTexture {\ndiff --git a/ui/console-priv.h b/ui/console-priv.h\nindex 43ceb8122f1..2c2cfd99570 100644\n--- a/ui/console-priv.h\n+++ b/ui/console-priv.h\n@@ -36,7 +36,6 @@ struct QemuConsole {\n };\n \n void qemu_text_console_update_size(QemuTextConsole *c);\n-const char * qemu_text_console_get_label(QemuTextConsole *c);\n void qemu_text_console_update_cursor(void);\n void qemu_text_console_handle_keysym(QemuTextConsole *s, int keysym);\n \ndiff --git a/ui/console-vc-stubs.c b/ui/console-vc-stubs.c\nindex b63e2fb2345..8a7f19c1f44 100644\n--- a/ui/console-vc-stubs.c\n+++ b/ui/console-vc-stubs.c\n@@ -14,12 +14,6 @@ void qemu_text_console_update_size(QemuTextConsole *c)\n {\n }\n \n-const char *\n-qemu_text_console_get_label(QemuTextConsole *c)\n-{\n- return NULL;\n-}\n-\n void qemu_text_console_update_cursor(void)\n {\n }\ndiff --git a/ui/console-vc.c b/ui/console-vc.c\nindex bd816d45759..7b9acf1adb1 100644\n--- a/ui/console-vc.c\n+++ b/ui/console-vc.c\n@@ -125,10 +125,12 @@ static const pixman_color_t color_table_rgb[2][8] = {\n static bool cursor_visible_phase;\n static QEMUTimer *cursor_timer;\n \n-const char *\n-qemu_text_console_get_label(QemuTextConsole *c)\n+static char *\n+qemu_text_console_get_label(QemuConsole *c)\n {\n- return c->chr ? c->chr->label : NULL;\n+ QemuTextConsole *tc = QEMU_TEXT_CONSOLE(c);\n+\n+ return tc->chr ? g_strdup(tc->chr->label) : NULL;\n }\n \n static void qemu_console_fill_rect(QemuConsole *con, int posx, int posy,\n@@ -1114,9 +1116,13 @@ qemu_text_console_finalize(Object *obj)\n static void\n qemu_text_console_class_init(ObjectClass *oc, const void *data)\n {\n+ QemuConsoleClass *cc = QEMU_CONSOLE_CLASS(oc);\n+\n if (!cursor_timer) {\n cursor_timer = timer_new_ms(QEMU_CLOCK_REALTIME, cursor_timer_cb, NULL);\n }\n+\n+ cc->get_label = qemu_text_console_get_label;\n }\n \n static const GraphicHwOps text_console_ops = {\ndiff --git a/ui/console.c b/ui/console.c\nindex f445db11389..24e4761e1f9 100644\n--- a/ui/console.c\n+++ b/ui/console.c\n@@ -436,9 +436,58 @@ qemu_graphic_console_prop_get_head(Object *obj, Visitor *v, const char *name,\n visit_type_uint32(v, name, &c->head, errp);\n }\n \n+static bool\n+qemu_graphic_console_is_multihead(QemuGraphicConsole *c)\n+{\n+ QemuConsole *con;\n+\n+ QTAILQ_FOREACH(con, &consoles, next) {\n+ QemuGraphicConsole *candidate;\n+\n+ if (!QEMU_IS_GRAPHIC_CONSOLE(con)) {\n+ continue;\n+ }\n+\n+ candidate = QEMU_GRAPHIC_CONSOLE(con);\n+ if (candidate->device != c->device) {\n+ continue;\n+ }\n+\n+ if (candidate->head != c->head) {\n+ return true;\n+ }\n+ }\n+ return false;\n+}\n+\n+static char *\n+qemu_graphic_console_get_label(QemuConsole *con)\n+{\n+ QemuGraphicConsole *c = QEMU_GRAPHIC_CONSOLE(con);\n+\n+ if (c->device) {\n+ DeviceState *dev;\n+ bool multihead;\n+\n+ dev = DEVICE(c->device);\n+ multihead = qemu_graphic_console_is_multihead(c);\n+ if (multihead) {\n+ return g_strdup_printf(\"%s.%d\", dev->id ?\n+ dev->id :\n+ object_get_typename(c->device),\n+ c->head);\n+ } else {\n+ return g_strdup(dev->id ? : object_get_typename(c->device));\n+ }\n+ }\n+ return g_strdup(\"VGA\");\n+}\n+\n static void\n qemu_graphic_console_class_init(ObjectClass *oc, const void *data)\n {\n+ QemuConsoleClass *cc = QEMU_CONSOLE_CLASS(oc);\n+\n object_class_property_add_link(oc, \"device\", TYPE_DEVICE,\n offsetof(QemuGraphicConsole, device),\n object_property_allow_set_link,\n@@ -446,6 +495,8 @@ qemu_graphic_console_class_init(ObjectClass *oc, const void *data)\n object_class_property_add(oc, \"head\", \"uint32\",\n qemu_graphic_console_prop_get_head,\n NULL, NULL, NULL);\n+\n+ cc->get_label = qemu_graphic_console_get_label;\n }\n \n static void\n@@ -1347,56 +1398,12 @@ bool qemu_console_is_gl_blocked(QemuConsole *con)\n return con->gl_block;\n }\n \n-static bool qemu_graphic_console_is_multihead(QemuGraphicConsole *c)\n-{\n- QemuConsole *con;\n-\n- QTAILQ_FOREACH(con, &consoles, next) {\n- QemuGraphicConsole *candidate;\n-\n- if (!QEMU_IS_GRAPHIC_CONSOLE(con)) {\n- continue;\n- }\n-\n- candidate = QEMU_GRAPHIC_CONSOLE(con);\n- if (candidate->device != c->device) {\n- continue;\n- }\n-\n- if (candidate->head != c->head) {\n- return true;\n- }\n- }\n- return false;\n-}\n-\n char *qemu_console_get_label(QemuConsole *con)\n {\n- if (QEMU_IS_GRAPHIC_CONSOLE(con)) {\n- QemuGraphicConsole *c = QEMU_GRAPHIC_CONSOLE(con);\n- if (c->device) {\n- DeviceState *dev;\n- bool multihead;\n-\n- dev = DEVICE(c->device);\n- multihead = qemu_graphic_console_is_multihead(c);\n- if (multihead) {\n- return g_strdup_printf(\"%s.%d\", dev->id ?\n- dev->id :\n- object_get_typename(c->device),\n- c->head);\n- } else {\n- return g_strdup(dev->id ? : object_get_typename(c->device));\n- }\n- }\n- return g_strdup(\"VGA\");\n- } else if (QEMU_IS_TEXT_CONSOLE(con)) {\n- const char *label = qemu_text_console_get_label(QEMU_TEXT_CONSOLE(con));\n- if (label) {\n- return g_strdup(label);\n- }\n+ char *label = QEMU_CONSOLE_GET_CLASS(con)->get_label(con);\n+ if (label) {\n+ return label;\n }\n-\n return g_strdup_printf(\"vc%d\", con->index);\n }\n \n","prefixes":["v2","12/67"]}