{"id":2222078,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222078/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-10-231416f76dc3@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410-qemu-vnc-v2-10-231416f76dc3@redhat.com>","date":"2026-04-10T19:18:32","name":"[v2,10/67] ui/console-vc: ignore string-type escape sequences","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c4804fbc4c77ad32e40729e3ff09e08974bd4fc4","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-10-231416f76dc3@redhat.com/mbox/","series":[{"id":499494,"url":"http://patchwork.ozlabs.org/api/1.1/series/499494/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494","date":"2026-04-10T19:18:23","name":"ui: add standalone VNC server over D-Bus","version":2,"mbox":"http://patchwork.ozlabs.org/series/499494/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222078/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222078/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=F5ZFh+Il;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsmqM103Vz1y2d\n\tfor ; Sat, 11 Apr 2026 05:20:47 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBHOc-0003eM-8K; Fri, 10 Apr 2026 15:20:02 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHOa-0003Tq-E4\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:20:00 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHOZ-0000qM-10\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:20:00 -0400","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-h-bk7hw6MnKbfBnvI-fy8g-1; Fri,\n 10 Apr 2026 15:19:55 -0400","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 30EAE1800BED\n for ; Fri, 10 Apr 2026 19:19:54 +0000 (UTC)","from localhost (unknown [10.44.22.4])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 1133D19560AB; Fri, 10 Apr 2026 19:19:52 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775848798;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=BVtXUd3/vnIW9OWxR+IrxGHFdO8ndQ7MDKjHO+ZSuxs=;\n b=F5ZFh+Ilr50rZq2FQXNpei9roqRweULwE4fcjVb1YEToJDFwS04/DDzCsSdbo6N7G0B4Oa\n 4mD33kzJDaSckbl6q+b7DBSiIzNqMbnNVPIn7b2KhqNRVMDFRV/cjwwrAcBMoWJXXZ2iVR\n 8U1hRtq//R0WVge6MjBYHVctmDlefGY=","X-MC-Unique":"h-bk7hw6MnKbfBnvI-fy8g-1","X-Mimecast-MFC-AGG-ID":"h-bk7hw6MnKbfBnvI-fy8g_1775848794","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Fri, 10 Apr 2026 23:18:32 +0400","Subject":"[PATCH v2 10/67] ui/console-vc: ignore string-type escape\n sequences","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260410-qemu-vnc-v2-10-231416f76dc3@redhat.com>","References":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","In-Reply-To":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=2045;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=m7qmdCz70Vht0Po69gBkjQ+7bxeu8B0z/LwcEPzXT8o=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0UWMOYphewUu/SP9fn+qqHNkY4OwSH4wRqq\n hxvCdAa3aiJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNFAAKCRDa6OEJdZac\n 5TK0D/wI6POFjveO6ZH1hK70vYP14aBpIO8mx9oogGIW9vVCeDJAo3gzDDp+X7wZa7JXA3+o4vd\n ve3aC1Ry17qu4eA8s1wT3YGVzfclxY0vDt3krCSvCDXHYtt13wVOqEPu/ZwX8Ly1jrp5V7z8M1t\n /NesmOXx9uVRq+vlvDyUi9kAsUKIUoS7mLAUb5IeNj9cEVLbZF7vB67pSfeUgYR1MGgSQVDzpwC\n tp2pRYnpffzHdjbQTSxLP4hSexn8R/faSq+7azwQfbVk2bMSHndd7sRlpK6SX8p/UyZrbkv7kIl\n wSpgvIDSHlU4dlXfeXf7PXK7TcVjZFNwFcT9A2ccVGLGT0nuaLp58IB0KaOKOjVDQj3HA3XRkCU\n wuDKorb1ZdIWcrj68KQeddI6LD4Q5sAIWgj4bmD9q+pYuYpNckC9hYSTzyrNMSj4YUz6TUtYp8t\n pJCpHdPRndvbyE1wMBrju5kLJAMjqCmi7bkiyuJ+TOm5+WRtQap4zmVDl5pZ2mX5xeX4+6X5iK5\n npCSELRu85Rg7bCqs3x+yIa4+zJev80nKvM90DwzBwxn3IZ0vDmQ0IG9BAUm4PymUvc1dPhqFth\n R0CnJ7xh+e5hIrTOrIuSnmjS9HlxQ3L/qKR1m2/eqJPo+rznQLMiNywyDyGyH4/3NZgkZ6aUrRX\n 3fttw4clpeYmGbw==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Modern terminals and applications emit OSC (Operating System Command),\nDCS, SOS, PM, and APC escape sequences (e.g. for setting window\ntitles). The text console currently does not recognise these\nstring-type introducers, so each byte of the payload is interpreted as\na normal character or a new escape, producing garbage on screen.\n\nAdd a TTY_STATE_OSC state that silently consumes all bytes until the\nsequence is terminated by BEL or ST (ESC \\).\n\nSigned-off-by: Marc-André Lureau \n---\n ui/console-vc.c | 15 +++++++++++++++\n 1 file changed, 15 insertions(+)","diff":"diff --git a/ui/console-vc.c b/ui/console-vc.c\nindex d9d6966410a..f1d38ee8ada 100644\n--- a/ui/console-vc.c\n+++ b/ui/console-vc.c\n@@ -45,6 +45,7 @@ enum TTYState {\n TTY_STATE_CSI,\n TTY_STATE_G0,\n TTY_STATE_G1,\n+ TTY_STATE_OSC,\n };\n \n typedef struct QemuTextConsole {\n@@ -868,6 +869,10 @@ static void vc_putchar(VCChardev *vc, int ch)\n vc->state = TTY_STATE_G0;\n } else if (ch == ')') {\n vc->state = TTY_STATE_G1;\n+ } else if (ch == ']' || ch == 'P' || ch == 'X'\n+ || ch == '^' || ch == '_') {\n+ /* String sequences: OSC, DCS, SOS, PM, APC */\n+ vc->state = TTY_STATE_OSC;\n } else if (ch == '7') {\n vc_save_cursor(vc);\n vc->state = TTY_STATE_NORM;\n@@ -1026,6 +1031,16 @@ static void vc_putchar(VCChardev *vc, int ch)\n break;\n }\n break;\n+ case TTY_STATE_OSC: /* Operating System Command: ESC ] ... BEL/ST */\n+ if (ch == '\\a') {\n+ /* BEL terminates OSC */\n+ vc->state = TTY_STATE_NORM;\n+ } else if (ch == 27) {\n+ /* ESC might start ST (ESC \\) */\n+ vc->state = TTY_STATE_ESC;\n+ }\n+ /* All other bytes are silently consumed */\n+ break;\n case TTY_STATE_G0: /* set character sets */\n case TTY_STATE_G1: /* set character sets */\n switch (ch) {\n","prefixes":["v2","10/67"]}