{"id":2222076,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222076/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-6-231416f76dc3@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410-qemu-vnc-v2-6-231416f76dc3@redhat.com>","date":"2026-04-10T19:18:28","name":"[v2,06/67] ui/vnc-jobs: narrow taking the queue lock","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e8f0f355b7f6dfe619ec71ff75765c9f72cd1b03","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-6-231416f76dc3@redhat.com/mbox/","series":[{"id":499494,"url":"http://patchwork.ozlabs.org/api/1.1/series/499494/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494","date":"2026-04-10T19:18:23","name":"ui: add standalone VNC server over D-Bus","version":2,"mbox":"http://patchwork.ozlabs.org/series/499494/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222076/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222076/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=izwaU7qv;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsmpr42Stz1y2d\n\tfor ; Sat, 11 Apr 2026 05:20:20 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBHOH-0002Vl-EU; Fri, 10 Apr 2026 15:19:41 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHOD-0002V7-Ct\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:19:37 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHOB-0000W2-JK\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:19:36 -0400","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-99-fVKq_1h7MVaasg-dBvEBhA-1; Fri,\n 10 Apr 2026 15:19:32 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id E2D231955DB2\n for ; Fri, 10 Apr 2026 19:19:29 +0000 (UTC)","from localhost (unknown [10.44.22.4])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id D924719560AB; Fri, 10 Apr 2026 19:19:28 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775848774;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=04H11uqkKPsmfZAF9wEtytacoQ7tjN07AWbO6BWGtZQ=;\n b=izwaU7qv00AimSjYmRPOfdTAsfGB0jP6Z1TngTpDC5Cfn50QWmGRDFuVWf0oK7t8L2THHC\n pUo9RnZ+YdseNFrq4QEZeRIVLdQjXXM80LR+VwTjX2QzLLqUMB6JrYsST/7h3ZXa+SCIwD\n Y1eVTSxOXVagzHyQh0N4VFv1MkWH1M0=","X-MC-Unique":"fVKq_1h7MVaasg-dBvEBhA-1","X-Mimecast-MFC-AGG-ID":"fVKq_1h7MVaasg-dBvEBhA_1775848770","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Fri, 10 Apr 2026 23:18:28 +0400","Subject":"[PATCH v2 06/67] ui/vnc-jobs: narrow taking the queue lock","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260410-qemu-vnc-v2-6-231416f76dc3@redhat.com>","References":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","In-Reply-To":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1736;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=KoLQMmYbBIOnREXI2mU7J3ttjR2QtUJlnlZbP6oVDa0=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0T/v09UM7pdXc1+Xyeo0y3ldzufWSAD/bAE\n pStwf3Y7mKJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNEwAKCRDa6OEJdZac\n 5dsLD/4wlxZeF7b44RGF/ez3ZuSqSOgGM2VqPPFQNSlD/aDhaMu0+dlT0HBmCQ0wmQJ+yPStzjT\n on3fXdNe7u+P6yO0IFbfdX2HW9KBHlnjYFrrtBSzsmtzbg8xXyaAFKPNV2qFLJG/9reT64YdFfR\n K82pm0r1IkFZFVshVi9DDdjjICFBVJ8sSIllEjYzv2bBJ7VyW9N7IJ6pIq4fB1nxfXy8lydmvdJ\n Tf629AcZzJmvW3VtRnpj7zHEHebN9hcMx87+nfBnZxuhtKDzSZZ2VeoxE0Sm1f0tG/7+2VoqUZJ\n UE4IAO9H54SOMewWzPhJZKKaLS/fJukW3VWJg3lgtgDDTI4kkqmXehp/LFVuGRhG5J/aPEIb/T1\n pr7Lm88rk0xy9bfEmU50apkY4HTd378IdM3AeDjttzZtEK3aWOMMpgDvwj0qkwZutx/GD0Jzm4G\n 7Z1DdyZd3eyC3NPYhXACLnNBMW7hmM1CrDAqElHdB8JtuCfz6ALP1dKTRzgp9I5scXAZIWqVlds\n xH6eUrYjsT4vCmKzB1uMTUXXuxQvq+sKuey3iXwhgPzJteaAAP5GGhOfMNYZ+91FmGcPD9h1AeL\n NnvUgKUujBUquMdLl7fl6uZywNzW0sMibl06TgfQIVwsGMRodfsKOgr3C41YIhjRHpwOyyz/SiM\n bguyrTUtLWpNRyg==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"7","X-Spam_score":"0.7","X-Spam_bar":"/","X-Spam_report":"(0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"It's not needed unless manipulating the queue.\n\nSigned-off-by: Marc-André Lureau \n---\n ui/vnc-jobs.c | 17 +++++++++++------\n 1 file changed, 11 insertions(+), 6 deletions(-)","diff":"diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c\nindex 28a4738f1ec..9c17d684c9e 100644\n--- a/ui/vnc-jobs.c\n+++ b/ui/vnc-jobs.c\n@@ -83,26 +83,26 @@ VncJob *vnc_job_new(VncState *vs)\n \n assert(vs->magic == VNC_MAGIC);\n job->vs = vs;\n- vnc_lock_queue(queue);\n QLIST_INIT(&job->rectangles);\n- vnc_unlock_queue(queue);\n return job;\n }\n \n+/*\n+ * Do not call this after pushing the job.\n+ */\n int vnc_job_add_rect(VncJob *job, int x, int y, int w, int h)\n {\n VncRectEntry *entry = g_new0(VncRectEntry, 1);\n \n trace_vnc_job_add_rect(job->vs, job, x, y, w, h);\n+ assert(!QTAILQ_IN_USE(job, next));\n \n entry->rect.x = x;\n entry->rect.y = y;\n entry->rect.w = w;\n entry->rect.h = h;\n \n- vnc_lock_queue(queue);\n QLIST_INSERT_HEAD(&job->rectangles, entry, next);\n- vnc_unlock_queue(queue);\n return 1;\n }\n \n@@ -120,16 +120,21 @@ static void vnc_job_free(VncJob *job)\n g_free(job);\n }\n \n+/*\n+ * Push a job onto the queue. Ownership of the job is transferred.\n+ */\n void vnc_job_push(VncJob *job)\n {\n- vnc_lock_queue(queue);\n+ assert(!QTAILQ_IN_USE(job, next));\n+\n if (QLIST_EMPTY(&job->rectangles)) {\n vnc_job_free(job);\n } else {\n+ vnc_lock_queue(queue);\n QTAILQ_INSERT_TAIL(&queue->jobs, job, next);\n qemu_cond_broadcast(&queue->cond);\n+ vnc_unlock_queue(queue);\n }\n- vnc_unlock_queue(queue);\n }\n \n static bool vnc_has_job_locked(VncState *vs)\n","prefixes":["v2","06/67"]}