{"id":2222073,"url":"http://patchwork.ozlabs.org/api/1.1/patches/2222073/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-3-231416f76dc3@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.1/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260410-qemu-vnc-v2-3-231416f76dc3@redhat.com>","date":"2026-04-10T19:18:25","name":"[v2,03/67] ui/vnc-jobs: vnc_has_job_locked() argument cannot be NULL","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a6f2dc689d628a91bc12db20d96e2d74e85843e6","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.1/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260410-qemu-vnc-v2-3-231416f76dc3@redhat.com/mbox/","series":[{"id":499494,"url":"http://patchwork.ozlabs.org/api/1.1/series/499494/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499494","date":"2026-04-10T19:18:23","name":"ui: add standalone VNC server over D-Bus","version":2,"mbox":"http://patchwork.ozlabs.org/series/499494/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222073/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222073/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=csGdwroj;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsmpm3Gnnz1y2d\n\tfor ; Sat, 11 Apr 2026 05:20:16 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBHNv-0002Gp-6G; Fri, 10 Apr 2026 15:19:19 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHNs-0002Ga-JD\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:19:16 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBHNq-0000On-9J\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 15:19:16 -0400","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-606--WHcnR5mOeu6OJUR6XBkRg-1; Fri,\n 10 Apr 2026 15:19:12 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 6E0CD180034C\n for ; Fri, 10 Apr 2026 19:19:11 +0000 (UTC)","from localhost (unknown [10.44.22.4])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 4BA2E3000C16; Fri, 10 Apr 2026 19:19:09 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775848753;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=YNC6v0P1xzOIZIP6aHqQfMFudfdgW80spUvHLw0+FaM=;\n b=csGdwrojnXH/V8pg0pzIDZSOUswysNsKQ6XxYTzifQRZ9XXe4u0j7/FyKdfcBEHPzdznSt\n 7hmBSIPaO4N3R+JI1l3XizZ5H272nR5xoHndiIO+J4TZ8kcVUorgbQFysCJ3C/GqvFb/3m\n HELqQvVvH6QnuYtCidr2TWk1bKtzD2s=","X-MC-Unique":"-WHcnR5mOeu6OJUR6XBkRg-1","X-Mimecast-MFC-AGG-ID":"-WHcnR5mOeu6OJUR6XBkRg_1775848751","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Fri, 10 Apr 2026 23:18:25 +0400","Subject":"[PATCH v2 03/67] ui/vnc-jobs: vnc_has_job_locked() argument cannot\n be NULL","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260410-qemu-vnc-v2-3-231416f76dc3@redhat.com>","References":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","In-Reply-To":"<20260410-qemu-vnc-v2-0-231416f76dc3@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=686;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=8lTDGJSHd1oC47RSN2DU3h4RCwiGcEBrgwXT5KJMEUs=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp2U0TzoSrmap6Ei8tkfeYA6nR9/46PRkHe2AdY\n gZ3TlkHo5iJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCadlNEwAKCRDa6OEJdZac\n 5eNZEAC0Es+Bs67QOPOtfiazyqBCWDmeGBiYt4Ev0jxETfW7IylmSgTjMCbeQlaFs+cEaJGXim0\n tmLR2+eHwtbPA1Jz/3YCs62m21A1pdhQw1PORjSd0kTQbCByM+VCLufcQQefteyYcx8hR2Ibz7B\n UFa9OdUQ0vkR+oy8vvxjeYDR5nw7SGyoEYSqHhNjgWVqGwzhEfFCp5sj/0udfniwVbt9PSsV8If\n cmPKange5piFbaHwEf9ihfrMAf0iWdNi/eY15WuLK5T0sY+R5VSL1DzC4YjPoNC+hSiMtWhCd3+\n seYMO/a7sNwhauqZxVgAzGD+NE/jC4+LM7M3luSQSR9UwcHWlUFOeSv5StnU9BDWGQwoX0N0tPZ\n 6PMvsYdjFcUzeizyiRXFRgJKQ8OKvC2epMyl9kFWak/RscUue9q3z5BMy7ZIh0VNHCT1iQjGVVJ\n oJVDtw2HYtapD09EvTqVOcH3cAH2+byvBnnFyo8lts5sBDKlQay7BNbUwUaowib8YHTS8LcpjsP\n UGlmS/X7Zt3k7GloRchfF7feF8lgHOT0tsVMUXsdvF+Ew6HFrfi8wwfAItnE6coAlWrsfZIAFe9\n zU7Um/NkUn5craRWHkFEm51+mTaoyOYmoWsS5R9qCCoXcocdpZ1HX/uFaNhaWymEAk0JJTYeCPh\n s0N8mB+MCuJKI2A==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The only caller, vnc_jobs_join() cannot take vs == NULL argument, or it\nwould later crash.\n\nReviewed-by: Daniel P. Berrangé \nSigned-off-by: Marc-André Lureau \n---\n ui/vnc-jobs.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c\nindex 4dd7ccad969..8cb30e72276 100644\n--- a/ui/vnc-jobs.c\n+++ b/ui/vnc-jobs.c\n@@ -138,7 +138,7 @@ static bool vnc_has_job_locked(VncState *vs)\n VncJob *job;\n \n QTAILQ_FOREACH(job, &queue->jobs, next) {\n- if (job->vs == vs || !vs) {\n+ if (job->vs == vs) {\n return true;\n }\n }\n","prefixes":["v2","03/67"]}